Re: [virtio-dev] packed ring layout proposal v2

2017-07-20 Thread Michael S. Tsirkin
org; > > virtualizat...@lists.linux-foundation.org > > Subject: Re: [virtio-dev] packed ring layout proposal v2 > > > > On Sun, Jul 16, 2017 at 06:00:45AM +, Lior Narkis wrote: > > > > -Original Message- > > > > From: virtio-dev@lists.oasis-o

RE: [virtio-dev] packed ring layout proposal v2

2017-07-19 Thread Lior Narkis
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, July 18, 2017 7:23 PM > To: Lior Narkis > Cc: virtio-dev@lists.oasis-open.org; virtualizat...@lists.linux-foundation.org > Subject: Re: [virtio-dev] packed ring layout proposal v

Re: [virtio-dev] packed ring layout proposal v2

2017-07-18 Thread Michael S. Tsirkin
> > To: virtio-dev@lists.oasis-open.org > > Cc: virtualizat...@lists.linux-foundation.org > > Subject: [virtio-dev] packed ring layout proposal v2 > > > > This is an update from v1 version. > > Changes: > > - update event suppression mechanism >

RE: [virtio-dev] packed ring layout proposal v2

2017-07-15 Thread Lior Narkis
Subject: [virtio-dev] packed ring layout proposal v2 > > This is an update from v1 version. > Changes: > - update event suppression mechanism > - separate options for indirect and direct s/g > - lots of new features > > --- > > Performance analysis of this is in my k

Re: [virtio-dev] packed ring layout proposal v2

2017-07-10 Thread Amnon Ilan
+Lior - Original Message - > From: "Michael S. Tsirkin" > To: "Cornelia Huck" > Cc: "Paolo Bonzini" , > virtualizat...@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org > Sent: Tuesday, March 7, 2017 10:33:57 PM > Subject:

Re: [virtio-dev] packed ring layout proposal v2

2017-03-07 Thread Michael S. Tsirkin
On Tue, Mar 07, 2017 at 04:53:53PM +0100, Cornelia Huck wrote: > On Wed, 22 Feb 2017 18:43:05 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Feb 09, 2017 at 05:11:05PM +0100, Cornelia Huck wrote: > > > > >>> * Non power-of-2 ring sizes > > > > >>> > > > > >>> As the ring simply wraps around, t

Re: [virtio-dev] packed ring layout proposal v2

2017-03-07 Thread Cornelia Huck
On Wed, 22 Feb 2017 18:43:05 +0200 "Michael S. Tsirkin" wrote: > On Thu, Feb 09, 2017 at 05:11:05PM +0100, Cornelia Huck wrote: > > > >>> * Non power-of-2 ring sizes > > > >>> > > > >>> As the ring simply wraps around, there's no reason to > > > >>> require ring size to be power of two. > > > >>>

Re: [virtio-dev] packed ring layout proposal v2

2017-02-28 Thread Yuanhan Liu
On Wed, Mar 01, 2017 at 06:14:21AM +0200, Michael S. Tsirkin wrote: > > > > That said, if it's "16: 16" and if we use only 8 bits for batch, we > > > > could still have another 8 bit for anything else, say the number of > > > > desc for a single pkt. With that, the num_buffers of mergeable Rx > > >

Re: [virtio-dev] packed ring layout proposal v2

2017-02-28 Thread Michael S. Tsirkin
On Wed, Mar 01, 2017 at 11:57:15AM +0800, Yuanhan Liu wrote: > On Wed, Mar 01, 2017 at 03:02:29AM +0200, Michael S. Tsirkin wrote: > > > > * Descriptor ring: > > > > > > > > Guest adds descriptors with unique index values and DESC_HW set in > > > > flags. > > > > Host overwrites used descriptors

Re: [virtio-dev] packed ring layout proposal v2

2017-02-28 Thread Yuanhan Liu
On Wed, Mar 01, 2017 at 03:02:29AM +0200, Michael S. Tsirkin wrote: > > > * Descriptor ring: > > > > > > Guest adds descriptors with unique index values and DESC_HW set in flags. > > > Host overwrites used descriptors with correct len, index, and DESC_HW > > > clear. Flags are always set/cleared

Re: [virtio-dev] packed ring layout proposal v2

2017-02-28 Thread Michael S. Tsirkin
On Tue, Feb 28, 2017 at 01:02:18PM +0800, Yuanhan Liu wrote: > On Wed, Feb 08, 2017 at 05:20:14AM +0200, Michael S. Tsirkin wrote: > > This is an update from v1 version. > > Changes: > > - update event suppression mechanism > > - separate options for indirect and direct s/g > > - lots of new featur

Re: [virtio-dev] packed ring layout proposal v2

2017-02-27 Thread Yuanhan Liu
On Wed, Feb 08, 2017 at 05:20:14AM +0200, Michael S. Tsirkin wrote: > This is an update from v1 version. > Changes: > - update event suppression mechanism > - separate options for indirect and direct s/g > - lots of new features > > --- > > Performance analysis of this is in my kvm forum 2016 pre

Re: [virtio-dev] packed ring layout proposal v2

2017-02-22 Thread Michael S. Tsirkin
On Thu, Feb 09, 2017 at 05:11:05PM +0100, Cornelia Huck wrote: > > >>> * Non power-of-2 ring sizes > > >>> > > >>> As the ring simply wraps around, there's no reason to > > >>> require ring size to be power of two. > > >>> It can be made a separate feature though. > > >> > > >> Power of 2 ring size

RE: [virtio-dev] packed ring layout proposal v2

2017-02-22 Thread Chien, Roger S
From: virtio-dev@lists.oasis-open.org [mailto:virtio-dev@lists.oasis-open.org] On Behalf Of Michael S. Tsirkin Sent: Wednesday, February 8, 2017 11:20 AM To: virtio-dev@lists.oasis-open.org Cc: virtualizat...@lists.linux-foundation.org Subject: [virtio-dev] packed ring layout proposal v2 This i

Re: [virtio-dev] packed ring layout proposal v2

2017-02-10 Thread Paolo Bonzini
- Original Message - > From: "Michael S. Tsirkin" > To: "Paolo Bonzini" > Cc: virtio-dev@lists.oasis-open.org, virtualizat...@lists.linux-foundation.org > Sent: Friday, February 10, 2017 4:20:17 PM > Subject: Re: [virtio-dev] packed ring layout propo

Re: [virtio-dev] packed ring layout proposal v2

2017-02-10 Thread Michael S. Tsirkin
On Fri, Feb 10, 2017 at 12:32:49PM +0100, Paolo Bonzini wrote: > > > On 09/02/2017 19:24, Michael S. Tsirkin wrote: > >> I don't know. Power of 2 ring size is pretty standard, I'd rather avoid > >> the complication and the gratuitous difference with 1.0. > > > > I thought originally there's a re

Re: [virtio-dev] packed ring layout proposal v2

2017-02-10 Thread Paolo Bonzini
On 09/02/2017 19:24, Michael S. Tsirkin wrote: >> I don't know. Power of 2 ring size is pretty standard, I'd rather avoid >> the complication and the gratuitous difference with 1.0. > > I thought originally there's a reason 1.0 rings had to be powers of two > but now I don't see why. OK, we can

Re: [virtio-dev] packed ring layout proposal v2

2017-02-09 Thread Michael S. Tsirkin
On Thu, Feb 09, 2017 at 04:48:53PM +0100, Paolo Bonzini wrote: > > > On 08/02/2017 20:59, Michael S. Tsirkin wrote: > > We couldn't decide what's better for everyone in 1.0 days and I doubt > > we'll be able to now, but yes, benchmarking is needed to make > > sire it's required. Very easy to remo

Re: [virtio-dev] packed ring layout proposal v2

2017-02-09 Thread Cornelia Huck
On Thu, 9 Feb 2017 16:48:53 +0100 Paolo Bonzini wrote: > On 08/02/2017 20:59, Michael S. Tsirkin wrote: > > We couldn't decide what's better for everyone in 1.0 days and I doubt > > we'll be able to now, but yes, benchmarking is needed to make > > sire it's required. Very easy to remove or not to

Re: [virtio-dev] packed ring layout proposal v2

2017-02-09 Thread Paolo Bonzini
On 08/02/2017 20:59, Michael S. Tsirkin wrote: > We couldn't decide what's better for everyone in 1.0 days and I doubt > we'll be able to now, but yes, benchmarking is needed to make > sire it's required. Very easy to remove or not to use/support in > drivers/devices though. Fair enough, but of

Re: [virtio-dev] packed ring layout proposal v2

2017-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2017 at 06:41:40PM +0100, Paolo Bonzini wrote: > > > On 08/02/2017 04:20, Michael S. Tsirkin wrote: > > * Scatter/gather support > > > > We can use 1 bit to chain s/g entries in a request, same as virtio 1.0: > > > > /* This marks a buffer as continuing via the next field. */ >

Re: [virtio-dev] packed ring layout proposal v2

2017-02-08 Thread Paolo Bonzini
On 08/02/2017 04:20, Michael S. Tsirkin wrote: > * Scatter/gather support > > We can use 1 bit to chain s/g entries in a request, same as virtio 1.0: > > /* This marks a buffer as continuing via the next field. */ > #define VRING_DESC_F_NEXT 1 > > Unlike virtio 1.0, all descriptors must