RE: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-28 Thread Cornelia Huck
On Thu, Apr 28 2022, Parav Pandit wrote: > All above comments are taken care now with Cornelia's wording for your input > and by correctly updating device side section now. > Sending v3. Honestly, I think it's a bit early for sending a v3 already, since it seems we've not reached complete

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-28 Thread Jason Wang
On Thu, Apr 28, 2022 at 2:30 PM Michael S. Tsirkin wrote: > > On Thu, Apr 28, 2022 at 02:13:42PM +0800, Jason Wang wrote: > > > queue_reset removal has far more editorial changes. > > > Before I update the v4 to incorporate, please discuss/sync with Michael > > > or others what is best course of

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-28 Thread Michael S. Tsirkin
On Thu, Apr 28, 2022 at 02:13:42PM +0800, Jason Wang wrote: > > queue_reset removal has far more editorial changes. > > Before I update the v4 to incorporate, please discuss/sync with Michael or > > others what is best course of action from spec timing perspective. > > I am ok either way to

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-28 Thread Michael S. Tsirkin
On Thu, Apr 28, 2022 at 02:10:46PM +0800, Jason Wang wrote: > On Thu, Apr 28, 2022 at 12:56 PM Michael S. Tsirkin wrote: > > > > On Thu, Apr 28, 2022 at 11:43:16AM +0800, Jason Wang wrote: > > > > > > 在 2022/4/28 11:24, Parav Pandit 写道: > > > > > > > > > From: Jason Wang > > > > > Sent:

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-28 Thread Jason Wang
On Thu, Apr 28, 2022 at 12:00 PM Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Wednesday, April 27, 2022 11:41 PM > > > > > > Hypervisor needs to trap the access to q_reset, otherwise there will be a > > race anyhow. So it knows the device is being reset and only after the device > >

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-28 Thread Jason Wang
On Thu, Apr 28, 2022 at 12:56 PM Michael S. Tsirkin wrote: > > On Thu, Apr 28, 2022 at 11:43:16AM +0800, Jason Wang wrote: > > > > 在 2022/4/28 11:24, Parav Pandit 写道: > > > > > > > From: Jason Wang > > > > Sent: Wednesday, April 27, 2022 11:15 PM > > > > > > > > On Wed, Apr 27, 2022 at 11:39 PM

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Thu, Apr 28, 2022 at 11:43:16AM +0800, Jason Wang wrote: > > 在 2022/4/28 11:24, Parav Pandit 写道: > > > > > From: Jason Wang > > > Sent: Wednesday, April 27, 2022 11:15 PM > > > > > > On Wed, Apr 27, 2022 at 11:39 PM Parav Pandit wrote: > > > > > > > > > From: Michael S. Tsirkin > > > > >

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Jason Wang
On Wed, Apr 27, 2022 at 7:46 PM Xuan Zhuo wrote: > > On Wed, 27 Apr 2022 19:29:37 +0800, Jason Wang wrote: > > On Wed, Apr 27, 2022 at 6:26 PM Parav Pandit wrote: > > > > > > Currently when driver initiates a queue reset, device is expected > > > to communicate reset status to the driver by

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Jason Wang
在 2022/4/28 11:24, Parav Pandit 写道: From: Jason Wang Sent: Wednesday, April 27, 2022 11:15 PM On Wed, Apr 27, 2022 at 11:39 PM Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday, April 27, 2022 11:30 AM On Wed, Apr 27, 2022 at 02:51:36PM +, Parav Pandit wrote: From:

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Jason Wang
在 2022/4/28 00:15, Parav Pandit 写道: From: Parav Pandit Sent: Wednesday, April 27, 2022 11:58 AM But this is so basic. It's hard to gaze at this spec for coming years and the code to see, Hey sometimes 0 means disabled, sometime 0 means still enabled, sometime 1 means enabled, and sometimes 1

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Jason Wang
On Wed, Apr 27, 2022 at 11:39 PM Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, April 27, 2022 11:30 AM > > > > On Wed, Apr 27, 2022 at 02:51:36PM +, Parav Pandit wrote: > > > > > > > From: Jason Wang > > > > Sent: Wednesday, April 27, 2022 7:30 AM > > > > > > > >

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 01:25:59PM +0300, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 04:15:05PM +, Parav Pandit wrote: > > > From: Parav Pandit > > Sent: Wednesday, April 27, 2022 11:58 AM > > > > But this is so basic. > > It's hard to gaze at this spec for coming years and the code to see, Hey > > sometimes 0 means disabled, sometime 0 means still

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 03:57:35PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, April 27, 2022 11:44 AM > > > > On Wed, Apr 27, 2022 at 03:39:40PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Wednesday, April 27, 2022 11:30

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 03:39:40PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, April 27, 2022 11:30 AM > > > > On Wed, Apr 27, 2022 at 02:51:36PM +, Parav Pandit wrote: > > > > > > > From: Jason Wang > > > > Sent: Wednesday, April 27, 2022 7:30 AM > > > >

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 02:51:36PM +, Parav Pandit wrote: > > > From: Jason Wang > > Sent: Wednesday, April 27, 2022 7:30 AM > > > > On Wed, Apr 27, 2022 at 6:26 PM Parav Pandit wrote: > > > > > > example flow: > > > a) 0,0 -> device init time value > > > b) 1,0 -> vq is enabled by driver

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Xuan Zhuo
On Wed, 27 Apr 2022 19:29:37 +0800, Jason Wang wrote: > On Wed, Apr 27, 2022 at 6:26 PM Parav Pandit wrote: > > > > Currently when driver initiates a queue reset, device is expected > > to communicate reset status to the driver by changing the value of the > > queue_reset register twice. First

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Jason Wang
On Wed, Apr 27, 2022 at 6:26 PM Parav Pandit wrote: > > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to