Re: [virtio-dev] [PATCH v3 2/2] virtio: pci support virtqueue reset

2021-09-28 Thread Cornelia Huck
On Tue, Sep 28 2021, Xuan Zhuo wrote: > On Mon, 27 Sep 2021 16:51:43 +0200, Cornelia Huck wrote: >> MMIO can probably use a similar mechanism. >> >> For CCW, maybe we can add a payload to the existing RESET command if the >> feature has been negotiated; the queue can

[virtio-dev] Re: [PATCH v4 1/3] virtio: introduce virtqueue reset as basic facility

2021-09-28 Thread Cornelia Huck
On Tue, Sep 28 2021, Xuan Zhuo wrote: > This patch allows the driver to reset a queue individually. > > This is very common on general network equipment. By disabling a queue, > you can quickly reclaim the buffer currently on the queue. If necessary, > we can reinitialize the queue separately. >

[virtio-dev] Re: [PATCH v4 2/3] virtio: pci support virtqueue reset

2021-09-28 Thread Cornelia Huck
On Tue, Sep 28 2021, Xuan Zhuo wrote: > PCI support virtqueue reset. > > virtio_pci_common_cfg add "queue_reset" to support virtqueue reset. > The driver uses this to selectively reset the queue. > > Signed-off-by: Xuan Zhuo > --- > content.tex | 28 > 1 file change

[virtio-dev] Re: [PATCH v4 3/3] virtio: mmio support virtqueue reset

2021-09-28 Thread Cornelia Huck
On Tue, Sep 28 2021, Xuan Zhuo wrote: > mmio support virtqueue reset. > > MMIO Device Register Layout "QueueReady" to support virtqueue reset. > The driver uses this to selectively reset the queue. > > Signed-off-by: Xuan Zhuo > --- > content.tex | 29 - > 1 file cha

Re: [virtio-dev] Re: [PATCH v4 1/3] virtio: introduce virtqueue reset as basic facility

2021-09-29 Thread Cornelia Huck
On Wed, Sep 29 2021, Jason Wang wrote: > On Wed, Sep 29, 2021 at 10:01 AM Xuan Zhuo wrote: >> >> On Tue, 28 Sep 2021 12:06:01 +0200, Cornelia Huck wrote: >> > On Tue, Sep 28 2021, Xuan Zhuo wrote: >> > >> > > This patch allows the driver to rese

[virtio-dev] Re: [PATCH v4 2/3] virtio: pci support virtqueue reset

2021-09-29 Thread Cornelia Huck
On Wed, Sep 29 2021, Xuan Zhuo wrote: > On Tue, 28 Sep 2021 12:20:46 +0200, Cornelia Huck wrote: >> On Tue, Sep 28 2021, Xuan Zhuo wrote: >> > +The device MUST reset the queue when 1 is written to \field{queue_reset}, >> > and >> > +present a 1 in \field{q

Re: [virtio-dev] Re: [PATCH v4 1/3] virtio: introduce virtqueue reset as basic facility

2021-09-30 Thread Cornelia Huck
On Thu, Sep 30 2021, Jason Wang wrote: > On Thu, Sep 30, 2021 at 12:24 AM Cornelia Huck wrote: >> >> On Wed, Sep 29 2021, Jason Wang wrote: >> >> > On Wed, Sep 29, 2021 at 10:01 AM Xuan Zhuo >> > wrote: >> >> >> >> On Tue, 28 S

[virtio-dev] Re: [PATCH v4 2/3] virtio: pci support virtqueue reset

2021-09-30 Thread Cornelia Huck
On Thu, Sep 30 2021, Jason Wang wrote: > On Thu, Sep 30, 2021 at 12:33 AM Cornelia Huck wrote: >> >> On Wed, Sep 29 2021, Xuan Zhuo wrote: >> >> > On Tue, 28 Sep 2021 12:20:46 +0200, Cornelia Huck >> > wrote: >> >> On Tue, Sep 28 2021, X

Re: [virtio-dev] [PATCH v5 1/3] virtio: introduce virtqueue reset as basic facility

2021-10-01 Thread Cornelia Huck
On Fri, Oct 01 2021, Xuan Zhuo wrote: > This patch allows the driver to reset a queue individually. > > This is very common on general network equipment. By disabling a queue, > you can quickly reclaim the buffer currently on the queue. If necessary, > we can reinitialize the queue separately. >

Re: [virtio-dev] [PATCH] Add device reset timeout field

2021-10-01 Thread Cornelia Huck
On Thu, Sep 30 2021, Parav Pandit wrote: > Motivation: > == > Currently when driver initiates a device reset operation, a device may > not be able finish the reset operation immediately. In such case driver > waits for an arbitrary amount of time in a hope that device will finish > the re

[virtio-dev] Re: [PATCH] content: Remove duplicate paragraph

2021-10-04 Thread Cornelia Huck
On Thu, Sep 30 2021, Jean-Philippe Brucker wrote: > It looks like commit 356aeeb40d7a ("content: add vendor specific cfg > type") had a merge issue. It includes the device normative paragraph for > Shared memory capability, which was already added right above it by > commit 855ad7af2bd6 ("shared

[virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Cornelia Huck
On Sun, Oct 03 2021, "Michael S. Tsirkin" wrote: > Sent too early. So here's what I propose. Could you pls take a look > and if you like this, post a ccw section? We have not talked about the mmio transport so far, but I guess it should be fine as legacy and standard are separated. > There's al

[virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Cornelia Huck
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > On Mon, Oct 04, 2021 at 02:01:14PM +0200, Cornelia Huck wrote: >> On Sun, Oct 03 2021, "Michael S. Tsirkin" wrote: >> > @@ -160,6 +163,33 @@ \subsection{Legacy Interface: A Note on Feature >>

RE: [virtio-dev] [PATCH] Add device reset timeout field

2021-10-04 Thread Cornelia Huck
On Fri, Oct 01 2021, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Friday, October 1, 2021 5:31 PM >> >> On Thu, Sep 30 2021, Parav Pandit wrote: >> > [..] > >> > +Once the driver initiates a reset, the device may not be able to >> &g

Re: [virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-04 Thread Cornelia Huck
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > On Mon, Oct 04, 2021 at 04:27:23PM +0200, Cornelia Huck wrote: >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: >> >> > On Mon, Oct 04, 2021 at 02:01:14PM +0200, Cornelia Huck wrote: >> &

RE: [virtio-dev] [PATCH] Add device reset timeout field

2021-10-04 Thread Cornelia Huck
On Tue, Oct 05 2021, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Monday, October 4, 2021 9:09 PM > > >> On Fri, Oct 01 2021, Parav Pandit wrote: >> >> >> From: Cornelia Huck >> >> Sent: Friday, October 1, 2021 5:31 P

Re: [virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-05 Thread Cornelia Huck
On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: > On Mon, Oct 04, 2021 at 05:45:06PM +0200, Cornelia Huck wrote: >> On Mon, Oct 04 2021, "Michael S. Tsirkin" wrote: >> >> > On Mon, Oct 04, 2021 at 04:27:23PM +0200, Cornelia Huck wrote: >> &

Re: [virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify

2021-10-05 Thread Cornelia Huck
On Tue, Oct 05 2021, "Michael S. Tsirkin" wrote: > On Tue, Oct 05, 2021 at 01:17:51PM +0200, Halil Pasic wrote: >> On Mon, 4 Oct 2021 16:01:12 -0400 >> "Michael S. Tsirkin" wrote: >> >> > > >> > > Ok, so what about something like >> > > >> > > "If FEATURES_OK is not set, the driver MAY change

[virtio-dev] Re: [PATCH] virtio-iommu: Rework the bypass feature

2021-10-05 Thread Cornelia Huck
On Thu, Sep 30 2021, Jean-Philippe Brucker wrote: > The VIRTIO_IOMMU_F_BYPASS feature is awkward to use and incomplete. > Although it is implemented by QEMU, it is not supported by any driver as > far as I know. Replace it with a new VIRTIO_IOMMU_F_BYPASS_CONFIG > feature. The old feature bit is

[virtio-dev] Re: [PATCH] virtio-iommu: Rework the bypass feature

2021-10-05 Thread Cornelia Huck
On Tue, Oct 05 2021, "Michael S. Tsirkin" wrote: > On Tue, Oct 05, 2021 at 06:57:50PM +0200, Cornelia Huck wrote: >> On Thu, Sep 30 2021, Jean-Philippe Brucker wrote: >> > \item[VIRTIO_IOMMU_F_BYPASS (3)] >> > - When not attached to a domain, endpoint

[virtio-dev] Re: [PATCH v5] virtio-pmem: PMEM device spec

2021-10-06 Thread Cornelia Huck
On Wed, Oct 06 2021, Pankaj Gupta wrote: > Posting virtio specification for virtio pmem device. Virtio pmem is a > paravirtualized device which allows the guest to bypass page cache. > Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu > device is merged in Qemu 4.1. > > Signe

Re: [virtio-dev] Re: [PATCH v5] virtio-pmem: PMEM device spec

2021-10-06 Thread Cornelia Huck
On Wed, Oct 06 2021, Pankaj Gupta wrote: >> > +\subsubsection{ Workload specific mapping}\label{sec:Device Types / PMEM >> > Device / Possible Security Implications / Countermeasures / Workload} >> > +For SHARED mappings, for the workload is a single application inside >> > +the driver and there

[virtio-dev] Re: [PATCH v1] Add device reset timeout field

2021-10-06 Thread Cornelia Huck
rav Pandit > Reviewed-by: Max Gurtovoy > > --- > changelog: > v0->v1: > - v0: https://lists.oasis-open.org/archives/virtio-dev/202109/msg00133.html > - Addressed below comments from Cornelia Huck > - renamed VIRTIO_F_DEV_RESET_TO to VIRTIO_F_DEV_RESET_TIMEOUT > - rem

Re: [virtio-dev] Re: [PATCH v5] virtio-pmem: PMEM device spec

2021-10-06 Thread Cornelia Huck
On Wed, Oct 06 2021, Pankaj Gupta wrote: >> >> > +\subsubsection{ Workload specific mapping}\label{sec:Device Types / >> >> > PMEM Device / Possible Security Implications / Countermeasures / >> >> > Workload} >> >> > +For SHARED mappings, for the workload is a single application inside >> >> >

Re: [virtio-dev] Fwd: [PATCH v2] Provide detailed specification of virtio-blk lifetime metrics

2021-10-06 Thread Cornelia Huck
On Fri, Aug 06 2021, Enrico Granata wrote: > Hi folks, > I am back from my leave of absence, so thank you everyone for your patience > > This proposal has been outstanding for a while and didn't seem to > receive pushback, especially compared to the initial proposal > > Would it be the right time

[virtio-dev] Re: [PATCH v2] content: Remove duplicate paragraph

2021-10-07 Thread Cornelia Huck
On Wed, Oct 06 2021, Jean-Philippe Brucker wrote: > It looks like commit 356aeeb40d7a ("content: add vendor specific cfg > type") had a merge issue. It includes the device normative paragraph for > Shared memory capability, which was already added right above it by > commit 855ad7af2bd6 ("shared

[virtio-dev] Re: [PATCH v2] content: Remove duplicate paragraph

2021-10-07 Thread Cornelia Huck
On Wed, Oct 06 2021, Jean-Philippe Brucker wrote: > It looks like commit 356aeeb40d7a ("content: add vendor specific cfg > type") had a merge issue. It includes the device normative paragraph for > Shared memory capability, which was already added right above it by > commit 855ad7af2bd6 ("shared

[virtio-dev] RE: [PATCH v2] Add device reset timeout field

2021-10-07 Thread Cornelia Huck
On Thu, Oct 07 2021, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Thursday, October 7, 2021 2:23 AM >> On Wed, Oct 06, 2021 at 04:11:19PM +, Parav Pandit wrote: >> > >> > > From: Michael S. Tsirkin >> > > Sent: Wednesday, October 6, 2021 8:52 PM >> > > second, I don't see a sto

[virtio-dev] RE: [PATCH v2] Add device reset timeout field

2021-10-08 Thread Cornelia Huck
On Thu, Oct 07 2021, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Thursday, October 7, 2021 9:41 PM >> On Thu, Oct 07 2021, Parav Pandit wrote: >> >> >> From: Michael S. Tsirkin >> >> Sent: Thursday, October 7, 2021 2:23 AM On Wed, Oct

[virtio-dev] Re: [PATCH v2] Add device reset timeout field

2021-10-08 Thread Cornelia Huck
On Fri, Oct 08 2021, "Michael S. Tsirkin" wrote: > On Fri, Oct 08, 2021 at 10:59:02AM +, Parav Pandit wrote: >> It may be even a pre-boot environment where 100msec or 10msec may be too >> short interval as other extreme of VM boot time example. > > I don't really know what this means. We are

[virtio-dev] RE: [PATCH v2] Add device reset timeout field

2021-10-11 Thread Cornelia Huck
On Mon, Oct 11 2021, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Saturday, October 9, 2021 4:39 AM >> >> On Fri, Oct 08, 2021 at 01:23:52PM +, Parav Pandit wrote: >> > >> > >> > > From: Michael S. Tsirkin >> > > Sent: Friday, October 8, 2021 6:27 PM >> > >> > > > 2. A sriov VF

[virtio-dev] RE: [PATCH v2] Add device reset timeout field

2021-10-11 Thread Cornelia Huck
On Mon, Oct 11 2021, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Monday, October 11, 2021 8:29 PM >> >> On Mon, Oct 11 2021, Parav Pandit wrote: >> > I think read only device reset timeout is most elegant option during device >> initialization

[virtio-dev] Re: [PATCH V5 2/2] virtio: i2c: Allow zero-length transactions

2021-10-13 Thread Cornelia Huck
On Tue, Oct 12 2021, Viresh Kumar wrote: > The I2C protocol allows zero-length requests with no data, like the > SMBus Quick command, where the command is inferred based on the > read/write flag itself. > > In order to allow such a request, allocate another bit, > VIRTIO_I2C_FLAGS_M_RD(1), in the

[virtio-dev] Re: [PATCH V5 2/2] virtio: i2c: Allow zero-length transactions

2021-10-13 Thread Cornelia Huck
On Wed, Oct 13 2021, Viresh Kumar wrote: > On 13-10-21, 11:26, Cornelia Huck wrote: >> On Tue, Oct 12 2021, Viresh Kumar wrote: >> > @@ -124,13 +140,23 @@ \subsubsection{Device Operation: Operation >> > Status}\label{sec:Device Types / I2C >> > >>

[virtio-dev] Re: [PATCH V5 2/2] virtio: i2c: Allow zero-length transactions

2021-10-13 Thread Cornelia Huck
On Wed, Oct 13 2021, Viresh Kumar wrote: > On 13-10-21, 11:26, Cornelia Huck wrote: >> On Tue, Oct 12 2021, Viresh Kumar wrote: >> > +A device SHOULD implement the VIRTIO_I2C_F_ZERO_LENGTH_REQUEST feature. >> >> Same here, I would make this "MUST

[virtio-dev] Re: [PATCH V9] virtio-gpio: Add support for interrupts

2021-10-14 Thread Cornelia Huck
On Tue, Oct 12 2021, Viresh Kumar wrote: > This patch adds support for interrupts to the virtio-gpio specification. > This uses the feature bit 0 for the same. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/114 > Cc: Marc Zyngier > Cc: Thomas Gleixner > Reviewed-by: Linus Walleij >

[virtio-dev] Re: [PATCH V9] virtio-gpio: Add support for interrupts

2021-10-14 Thread Cornelia Huck
On Thu, Oct 14 2021, Viresh Kumar wrote: > On 14-10-21, 12:12, Cornelia Huck wrote: >> What triggers the device to configure the GPIO lines in that state? Is >> that something that it should already do when it decides to offer the >> feature bit? > > Yes, it

Re: [virtio-dev] Fwd: [PATCH v2] Provide detailed specification of virtio-blk lifetime metrics

2021-10-14 Thread Cornelia Huck
On Wed, Oct 06 2021, Enrico Granata wrote: > I would very much favor that - thanks for bringing this thread back to > attention Merged now, thank you for your patience. - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.o

[virtio-dev] Re: [PATCH v6] virtio-pmem: PMEM device spec

2021-10-14 Thread Cornelia Huck
On Wed, Oct 06 2021, Pankaj Gupta wrote: > Posting virtio specification for virtio pmem device. Virtio pmem is a > paravirtualized device which allows the guest to bypass page cache. > Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu > device is merged in Qemu 4.1. > > Revie

[virtio-dev] RE: [PATCH v2] Add device reset timeout field

2021-10-14 Thread Cornelia Huck
On Fri, Oct 15 2021, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Friday, October 15, 2021 3:59 AM >> >> On Thu, Oct 14, 2021 at 05:35:37PM +, Parav Pandit wrote: >> > Below changes are good for v3? >> > 1. driver should use device reset time during initialization stage >> >> H

[virtio-dev] RE: [PATCH v2] Add device reset timeout field

2021-10-15 Thread Cornelia Huck
On Fri, Oct 15 2021, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Friday, October 15, 2021 12:22 PM >> >> On Fri, Oct 15 2021, Parav Pandit wrote: >> >> >> From: Michael S. Tsirkin >> >> Sent: Friday, October 15, 2021 3:59 A

[virtio-dev] Re: [PATCH v6] virtio-pmem: PMEM device spec

2021-10-15 Thread Cornelia Huck
On Fri, Oct 15 2021, Pankaj Gupta wrote: >> So, I ran into some problems while trying to apply this. >> >> First, this is against an older version of the tree, so it did not apply >> cleanly. > > Sorry! somehow i missed this. No worries, I fixed that up; but rebasing makes things easier for the

[virtio-dev] Re: [PATCH v3] virtio-iommu: Rework the bypass feature

2021-11-03 Thread Cornelia Huck
On Fri, Oct 22 2021, Jean-Philippe Brucker wrote: > The VIRTIO_IOMMU_F_BYPASS feature is awkward to use and incomplete. > Although it is implemented by QEMU, it is not supported by any driver as > far as I know. Replace it with a new VIRTIO_IOMMU_F_BYPASS_CONFIG > feature. > > Two features are mi

[virtio-dev] Re: [PATCH v6 1/3] virtio: introduce virtqueue reset as basic facility

2021-11-04 Thread Cornelia Huck
On Fri, Oct 15 2021, Xuan Zhuo wrote: > This patch allows the driver to reset a queue individually. > > This is very common on general network equipment. By disabling a queue, > you can quickly reclaim the buffer currently on the queue. If necessary, > we can reinitialize the queue separately. >

Re: [virtio-dev] [RFC PATCH v5] virtio-video: Add virtio video device specification

2021-11-10 Thread Cornelia Huck
On Wed, Jan 20 2021, Alexandre Courbot wrote: > From: Keiichi Watanabe > > The virtio video encoder and decoder devices are virtual devices that > support video encoding and decoding respectively. Although they are > different devices, they use the same protocol. > > Signed-off-by: Dmitry Sepp

[virtio-dev] Re: [PATCH v3 1/2] content: Explain better the status clearing bits

2021-11-12 Thread Cornelia Huck
On Thu, Nov 11 2021, Eugenio Pérez wrote: > The spec tells that "The driver MUST NOT clear a device status bit", but > a device using PCI transport reset a virtio device writing 0 to device I think MMIO uses that mechanism as well? > status. In some way, that is to clear all its bits. > > Inste

[virtio-dev] Re: [PATCH v3] virtio-mmio: Specify wait needed in driver during reset

2021-11-26 Thread Cornelia Huck
On Fri, Nov 26 2021, Jason Wang wrote: > On Fri, Nov 26, 2021 at 5:25 AM Michael S. Tsirkin wrote: >> >> On Tue, Aug 31, 2021 at 07:27:53PM +0530, Srivatsa Vaddagiri wrote: >> > Reset of a virtio-mmio device is initiated by writing 0 to its Status >> > register. >> > In case of some devices, th

Re: [virtio-dev] [PATCH v7 0/3] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-12-14 Thread Cornelia Huck
mmar correction >> > >> > v6: >> > The device MUST present consistent default values after queue reset. >> > >> > v5: >> > It is defined in the transports that the device can modify the default >> > value after reset, and the drive

Re: [virtio-dev] Any update on new spec review/release date?

2021-12-20 Thread Cornelia Huck
On Fri, Nov 05 2021, Cameron Esfahani wrote: > Hey all! > > I’ve finally caught up on all my KVM Forum presentations and was wondering if > there was any updates on what the release schedule for the next version of > the virtio specification will be? > > I thought there was a plan to have an up

[virtio-dev] Plans for releasing a VIRTIO 1.2 spec

2021-12-20 Thread Cornelia Huck
We are due (or rather overdue) for a new release of the VIRTIO spec. As doing a release takes some time, we need to tie things up soon (remember that there will also be a next revision for changes that don't make the cut.) We propose to declare a freeze on changes starting January 25th, 2022 (no n

[virtio-dev] Re: [virtio-comment] Plans for releasing a VIRTIO 1.2 spec

2021-12-20 Thread Cornelia Huck
On Mon, Dec 20 2021, Christian Schoenebeck wrote: > On Montag, 20. Dezember 2021 13:47:03 CET Cornelia Huck wrote: >> We are due (or rather overdue) for a new release of the VIRTIO spec. As >> doing a release takes some time, we need to tie things up soon (remember >> that

Re: [virtio-dev] Re: [PATCH v7] virtio-net: support device stats

2022-01-10 Thread Cornelia Huck
On Fri, Jan 07 2022, Jason Wang wrote: > On Fri, Jan 7, 2022 at 11:03 AM Xuan Zhuo wrote: >> >> On Thu, 6 Jan 2022 12:00:14 +0800, Jason Wang wrote: >> > On Wed, Jan 5, 2022 at 10:49 AM Xuan Zhuo >> > wrote: >> > > >> > > This patch allows the driver to obtain some statistics from the device.

Re: [virtio-dev] [PATCH v7] virtio-net: support device stats

2022-01-10 Thread Cornelia Huck
On Wed, Jan 05 2022, Xuan Zhuo wrote: > This patch allows the driver to obtain some statistics from the device. > > In the back-end implementation, we can count a lot of such information, > which can be used for debugging and judging the running status of the > back-end. We hope to directly displ

[virtio-dev] Re: [PATCH v8] virtio-net: support device stats

2022-01-11 Thread Cornelia Huck
ope to directly display it to the user through ethtool. > > Signed-off-by: Xuan Zhuo > Reviewed-by: Jason Wang > --- > > v8: > 1. Modified based on comments by Cornelia Huck > > v7: > 1. add rx_reset, tx_reset > 2. add device normative and dirver normative >

[virtio-dev] [oasis-tcs/virtio-spec] Device specific Feature bits numbering is not aligned (Issue #131)

2022-01-12 Thread Cornelia Huck
> Feature bits 56 to 63 are taken by the virtio-net device and not reflected in > the generic feature bits accounting. Thank you for reporting this, forwarding to the lists for discussion. It seems like we're in a bit of a pickle: The spec says that the higher feature bits are reserved for fut

[virtio-dev] [PATCH] Reserve more feature bits for device type usage

2022-01-14 Thread Cornelia Huck
anges in existing device and driver implementations.) Reported-by: Max Gurtovoy Fixes: https://github.com/oasis-tcs/virtio-spec/issues/131 Signed-off-by: Cornelia Huck --- content.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content.tex b/content.tex index 32de668

Re: [virtio-dev] spec inconsistency: Device Configuration Interrupt bit in ISR status

2022-01-14 Thread Cornelia Huck
On Fri, Jan 14 2022, "Michael S. Tsirkin" wrote: > It is unfortunate that it does not copy this requirement in more places, > and that the non-conformance text is incomplete and does not > mention the MSI-X usage at all. > > I propose to extend 4.1.4.5 ISR status capability and > 4.1.5.4 Notific

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-17 Thread Cornelia Huck
On Fri, Jan 14 2022, "Michael S. Tsirkin" wrote: > We state that drivers can access config fields before FEATURES_OK. We do > however need them to write the features before accessing config > otherwise our forward compatibility won't work. > > We require devices to allow access to config space if

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Cornelia Huck
On Tue, Jan 18 2022, Xuan Zhuo wrote: >> > > above you said bytes sent. >> > >> > I mean, all about GSO are statistics based on big packets. So here is the >> > package from Guest, and rx is the package passed to Guest. >> >> it's a subtle distinction that we need to make. > > I will make this cl

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Cornelia Huck
On Tue, Jan 18 2022, Xuan Zhuo wrote: > On Tue, 18 Jan 2022 09:39:04 +0100, Cornelia Huck wrote: >> On Tue, Jan 18 2022, Xuan Zhuo wrote: >> >> >> > > above you said bytes sent. >> >> > >> >> > I mean, all about GSO are statistic

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-19 Thread Cornelia Huck
On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > On Wed, Jan 19, 2022 at 01:23:43PM +0100, Halil Pasic wrote: >> On Mon, 17 Jan 2022 17:26:10 -0500 >> "Michael S. Tsirkin" wrote: >> >> > On Mon, Jan 17, 2022 at 04:39:32PM +0100, Cornelia

Re: [virtio-dev] [PATCH] virtio: clarify feature negotiation

2022-01-20 Thread Cornelia Huck
On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > On Wed, Jan 19, 2022 at 06:50:18PM +0100, Cornelia Huck wrote: >> On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: >> >> > On Wed, Jan 19, 2022 at 01:23:43PM +0100, Halil Pasic wrote: >> >

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-20 Thread Cornelia Huck
On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: > On Wed, Jan 19, 2022 at 01:23:19PM +0100, Halil Pasic wrote: >> On Fri, 14 Jan 2022 17:50:51 -0500 >> "Michael S. Tsirkin" wrote: >> > Subject: virtio: clarify feature negotiation >> > @@ -500,8 +500,13 @@ \section{Device Initialization}\label{s

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-21 Thread Cornelia Huck
On Fri, Jan 21 2022, Halil Pasic wrote: > On Thu, 20 Jan 2022 14:05:37 +0100 > Cornelia Huck wrote: > >> On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: >> >> > On Wed, Jan 19, 2022 at 01:23:19PM +0100, Halil Pasic wrote: >> My take would be:

[virtio-dev] The virtio spec is now in FREEZE for 1.2

2022-01-25 Thread Cornelia Huck
The virtio spec is now in freeze for the upcoming 1.2 release. What does this mean? - No more issues will be accepted into the 1.2 release, i.e. no more votes will be started. Anything outstanding will be delayed until after we have released 1.2 (which we hope to have done by the end of Marc

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-25 Thread Cornelia Huck
On Mon, Jan 24 2022, "Michael S. Tsirkin" wrote: > It's true. However, that's a generic rule and specific devices > can differ. and if you look at specific instances, you will > see that they typically require that the feature is negotiated. > For example: > > \item If the VIRTIO_BLK_F_BLK_SIZE f

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-25 Thread Cornelia Huck
On Mon, Jan 24 2022, Halil Pasic wrote: > On Fri, 21 Jan 2022 17:05:07 +0100 > Cornelia Huck wrote: > >> On Fri, Jan 21 2022, Halil Pasic wrote: >> >> > On Thu, 20 Jan 2022 14:05:37 +0100 >> > Cornelia Huck wrote: >> > >&g

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Cornelia Huck
On Mon, Jan 24 2022, Max Gurtovoy wrote: > In one of the many use cases a user wants to manipulate features and > configuration of the virtio devices regardless of the device type > (net/block/console). Some of this configuration is generic enough. i.e > Number of MSI-X vectors of a virtio PCI VF

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Cornelia Huck
On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > On Fri, Jan 28, 2022 at 01:14:14PM +0100, Cornelia Huck wrote: >> On Mon, Jan 24 2022, Max Gurtovoy wrote: >> > +\section{Admin Virtqueues}\label{sec:Basic Facilities of a Virtio Device >> > / Admin Virtqu

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Cornelia Huck
On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > On Fri, Jan 28, 2022 at 04:49:34PM +0100, Cornelia Huck wrote: >> On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: >> >> > On Fri, Jan 28, 2022 at 01:14:14PM +0100, Cornelia Huck wrote: &g

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-28 Thread Cornelia Huck
On Fri, Jan 28 2022, "Michael S. Tsirkin" wrote: > On Fri, Jan 28, 2022 at 05:14:37PM +0100, Cornelia Huck wrote: >> Maybe pci gets a new entry in common_cfg, mmio gets a new register, and >> ccw gets a new command? > > That's fine. > >> (Al

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
n 1/30/2022 11:40 AM, Michael S. Tsirkin wrote: >> > > > On Sun, Jan 30, 2022 at 11:13:38AM +0200, Max Gurtovoy wrote: >> > > > > On 1/29/2022 5:53 AM, Jason Wang wrote: >> > > > > > On Fri, Jan 28, 2022 at 11:52 PM Michael S. Tsirki

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: > On Mon, Jan 31, 2022 at 10:16:43AM +0100, Cornelia Huck wrote: >> On Sun, Jan 30 2022, "Michael S. Tsirkin" wrote: >> >> > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: >> >

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: > On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck wrote: >> On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: >> >> > On Mon, Jan 31, 2022 at 10:16:43AM +0100, Cornelia Huck wrote: >> &

Re: [virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Mon, Jan 31 2022, Halil Pasic wrote: > On Mon, 31 Jan 2022 10:16:43 +0100 > Cornelia Huck wrote: >> For ccw, I'd do something like >> >> #define CCW_CMD_READ_MISC_CONF 0x82 >> >> struct virtio_misc_conf { >>be16 admin_queue_index;

[virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-01-31 Thread Cornelia Huck
On Mon, Jan 31 2022, Halil Pasic wrote: > On Mon, 31 Jan 2022 09:52:54 -0500 > "Michael S. Tsirkin" wrote: > >> On Mon, Jan 31, 2022 at 03:26:36PM +0100, Cornelia Huck wrote: >> > On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: >> > >

Re: [virtio-dev] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue

2022-02-01 Thread Cornelia Huck
On Tue, Feb 01 2022, Halil Pasic wrote: > On Mon, 31 Jan 2022 18:10:39 +0100 > Cornelia Huck wrote: > >> On Mon, Jan 31 2022, Halil Pasic wrote: >> >> > On Mon, 31 Jan 2022 09:52:54 -0500 >> > "Michael S. Tsirkin" wrote: >> > >

[virtio-dev] Re: [PATCH] Reserve more feature bits for device type usage

2022-02-02 Thread Cornelia Huck
On Wed, Feb 02 2022, Max Gurtovoy wrote: > On 1/14/2022 1:12 PM, Cornelia Huck wrote: >> Feature bits 41 and above are noted as being reserved for future >> extensions. However, the net device has been using bits in that space >> for some time now, as it already used up the

[virtio-dev] Re: [PATCH] Reserve more feature bits for device type usage

2022-02-02 Thread Cornelia Huck
On Wed, Feb 02 2022, Max Gurtovoy wrote: > On 2/2/2022 1:52 PM, Cornelia Huck wrote: >> On Wed, Feb 02 2022, Max Gurtovoy wrote: >> >>> On 1/14/2022 1:12 PM, Cornelia Huck wrote: >>>> Feature bits 41 and above are noted as being reserved for future >>

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-03 Thread Cornelia Huck
On Thu, Feb 03 2022, Max Gurtovoy wrote: > In one of the many use cases a user wants to manipulate features and > configuration of the virtio devices regardless of the device type > (net/block/console). Some of this configuration is generic enough. i.e > Number of MSI-X vectors of a virtio PCI VF

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-07 Thread Cornelia Huck
On Mon, Feb 07 2022, "Michael S. Tsirkin" wrote: > On Mon, Feb 07, 2022 at 12:14:33PM +0200, Max Gurtovoy wrote: >> >> On 2/3/2022 3:09 PM, Cornelia Huck wrote: >> > On Thu, Feb 03 2022, Max Gurtovoy wrote: >> > > +commands to manip

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-07 Thread Cornelia Huck
On Mon, Feb 07 2022, Max Gurtovoy wrote: > On 2/7/2022 1:51 PM, Cornelia Huck wrote: >> On Mon, Feb 07 2022, "Michael S. Tsirkin" wrote: >> >>> On Mon, Feb 07, 2022 at 12:14:33PM +0200, Max Gurtovoy wrote: >>>> On 2/3/2022 3:09 PM, Cornelia Huck

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-08 Thread Cornelia Huck
On Tue, Feb 08 2022, Max Gurtovoy wrote: > On 2/8/2022 8:45 AM, Michael S. Tsirkin wrote: >> On Tue, Feb 08, 2022 at 02:41:44AM +0200, Max Gurtovoy wrote: >>> On 2/7/2022 6:18 PM, Michael S. Tsirkin wrote: On Mon, Feb 07, 2022 at 04:58:19PM +0200, Max Gurtovoy wrote: > On 2/7/2022 12:39

[virtio-dev] RE: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-08 Thread Cornelia Huck
On Tue, Feb 08 2022, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Tuesday, February 8, 2022 12:13 PM > >> On Tue, Feb 08, 2022 at 06:25:41AM +, Parav Pandit wrote: >> > >> > > From: Michael S. Tsirkin >> > > Sent: Monday, February 7, 2022 4:09 PM >> > > >> > > Next, trying to th

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-08 Thread Cornelia Huck
On Tue, Feb 08 2022, "Michael S. Tsirkin" wrote: > On Tue, Feb 08, 2022 at 01:32:12PM +, Parav Pandit wrote: >> >> > From: Cornelia Huck >> > Sent: Tuesday, February 8, 2022 6:50 PM >> > >> > On Tue, Feb 08 2022, Parav Pandit wrot

Re: [virtio-dev] RE: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-08 Thread Cornelia Huck
On Tue, Feb 08 2022, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Tuesday, February 8, 2022 8:29 PM > >> very specific (essentially PCI-specific), we need to at least answer the >> question >> "how could this work for things that are not PCI?"

[virtio-dev] Re: [PATCH v3 1/4] Add virtio Admin virtqueue

2022-02-08 Thread Cornelia Huck
On Tue, Feb 08 2022, "Michael S. Tsirkin" wrote: > On Tue, Feb 08, 2022 at 03:59:13PM +0100, Cornelia Huck wrote: >> On Tue, Feb 08 2022, "Michael S. Tsirkin" wrote: >> >> > On Tue, Feb 08, 2022 at 01:32:12PM +0000, Parav Pandit wrote: >> >

Re: [virtio-dev] [PATCH] packed-ring: fix some typos

2022-03-24 Thread Cornelia Huck
On Thu, Mar 24 2022, "Michael S. Tsirkin" wrote: > flag is misnamed in a couple of places. s//The VIRTQ_DESC_F_INDIRECT_FLAG / > > Signed-off-by: Michael S. Tsirkin > --- > packed-ring.tex | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [virtio-dev] [PATCH] packed-ring: fix some typos

2022-03-24 Thread Cornelia Huck
On Thu, Mar 24 2022, "Michael S. Tsirkin" wrote: > On Thu, Mar 24, 2022 at 12:23:23PM +0100, Cornelia Huck wrote: >> On Thu, Mar 24 2022, "Michael S. Tsirkin" wrote: >> >> > flag is misnamed in a couple of places. >> >> s//The VIRTQ_D

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-04-07 Thread Cornelia Huck
[sorry about resurrecting an undead thread; I'm trying to collect some editorial changes] On Wed, Jan 26 2022, Jean-Philippe Brucker wrote: > On Mon, Jan 24, 2022 at 04:42:35PM -0500, Michael S. Tsirkin wrote: >> So from that point of view, we are actually relaxing the requirements, >> and yes w

Re: [virtio-dev] [PATCH] virtio-gpio: offered -> negotiated

2022-04-13 Thread Cornelia Huck
On Tue, Jan 25 2022, "Michael S. Tsirkin" wrote: > virtqueues are only discovered after FEATURES_OK. > As such it makes no sense to talk about virtqueues being affected by > features which are offered but not negotiated, and doing so will confuse > the reader. > > Signed-off-by: Michael S. Tsirki

[virtio-dev] Re: [virtio-comment] [PATCH] packed-ring.tex: link conformance statements

2022-04-19 Thread Cornelia Huck
On Tue, Apr 19 2022, "Michael S. Tsirkin" wrote: > Link conformance statements into conformance chapter. > > Signed-off-by: Michael S. Tsirkin > --- > conformance.tex | 9 + > packed-ring.tex | 16 +--- > 2 files changed, 14 insertions(+), 11 deletions(-) > > diff --git a/c

Re: [virtio-dev] [PATCH] packed-ring: fix some typos

2022-04-20 Thread Cornelia Huck
On Thu, Mar 24 2022, "Michael S. Tsirkin" wrote: > flag is misnamed in a couple of places. > > Signed-off-by: Michael S. Tsirkin > --- > packed-ring.tex | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, applied as editorial update. --

[virtio-dev] Re: [virtio-comment] [PATCH] packed-ring.tex: link conformance statements

2022-04-20 Thread Cornelia Huck
On Tue, Apr 19 2022, "Michael S. Tsirkin" wrote: > Link conformance statements into conformance chapter. > > Signed-off-by: Michael S. Tsirkin > --- > conformance.tex | 9 + > packed-ring.tex | 16 +--- > 2 files changed, 14 insertions(+), 11 deletions(-) Thanks, pushed as

Re: [virtio-dev] [PATCH] content.tex: drop space after \field

2022-04-20 Thread Cornelia Huck
On Tue, Apr 19 2022, "Michael S. Tsirkin" wrote: > always use \field{foo} not \field {foo}, the latter confuses > latexdiff. > > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, pushed as an editorial update. --

Re: [virtio-dev] [PATCH] fixupdiff: escape ^ caret

2022-04-20 Thread Cornelia Huck
On Tue, Apr 19 2022, "Michael S. Tsirkin" wrote: > Since commit: > > commit 1e30753d53d222fbe955f0643583d756105d557e > Author: Jan Kiszka > Date: Fri Oct 11 13:43:41 2019 +0200 > > Fix ^= in example code > > Trying to escaping ^ here only leaves the backslash in the output. > > Sig

[virtio-dev] Re: [virtio-comment] [PATCH] packed-ring.tex: link conformance statements

2022-04-21 Thread Cornelia Huck
On Wed, Apr 20 2022, "Michael S. Tsirkin" wrote: > On Wed, Apr 20, 2022 at 12:02:03PM +0200, Cornelia Huck wrote: >> On Tue, Apr 19 2022, "Michael S. Tsirkin" wrote: >> >> > Link conformance statements into conformance chapter.

[virtio-dev] Re: [virtio-comment] [PATCH] make-setup-generated.sh: get version from spec string

2022-04-21 Thread Cornelia Huck
On Thu, Apr 21 2022, "Michael S. Tsirkin" wrote: > Signed-off-by: Michael S. Tsirkin > --- > make-setup-generated.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Cornelia Huck -

[virtio-dev] Re: [virtio] [PATCH] virtio-html.cfg: use variable for spec version

2022-04-21 Thread Cornelia Huck
On Thu, Apr 21 2022, "Michael S. Tsirkin" wrote: > this way it gets updated automatically > > Signed-off-by: Michael S. Tsirkin > --- > virtio-html.cfg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

[virtio-dev] Re: [virtio-comment] [PATCH] revision: update date

2022-04-21 Thread Cornelia Huck
On Thu, Apr 21 2022, "Michael S. Tsirkin" wrote: > --- > REVISION-DATE | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@l

<    1   2   3   4   5   6   7   8   >