Re: [PATCH 2/3] Virtio draft IV: the block driver

2007-07-23 Thread Christian Borntraeger
+#ifdef __KERNEL__ +struct gendisk; +struct virtio_device; + +struct gendisk *virtblk_probe(struct virtqueue *vq); Hello Rusty, I am currently do some prototyping with virtio IV and found tis small issue in the block device. virtblk_probe requires a declaration of virtqueue, not

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Rusty Russell
On Mon, 2007-07-23 at 17:12 -0700, Andrew Morton wrote: On Sat, 21 Jul 2007 11:17:58 +1000 Rusty Russell [EMAIL PROTECTED] wrote: The netfilter code had very good documentation: the Netfilter Hacking HOWTO. Noone ever read it. So this time I'm trying something different, using a bit

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Linus Torvalds
On Tue, 24 Jul 2007, Rusty Russell wrote: Indeed, no code changes, and I feel strongly that it should go into 2.6.23 because it's *fun*. And (as often complained) there's not enough poetry in the kernel. There's a reason for that. There once was a lad from Braidwood With

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Rusty Russell
On Mon, 2007-07-23 at 18:18 -0700, Linus Torvalds wrote: On Tue, 24 Jul 2007, Rusty Russell wrote: Indeed, no code changes, and I feel strongly that it should go into 2.6.23 because it's *fun*. And (as often complained) there's not enough poetry in the kernel. There's a reason for

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Randy Dunlap
On Mon, 23 Jul 2007 17:12:38 -0700 Andrew Morton wrote: On Sat, 21 Jul 2007 11:17:58 +1000 Rusty Russell [EMAIL PROTECTED] wrote: The netfilter code had very good documentation: the Netfilter Hacking HOWTO. Noone ever read it. So this time I'm trying something different, using a bit

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Rene Herman
On 07/24/2007 03:18 AM, Linus Torvalds wrote: PS. Nothing rhymes with Ballalaba. There once was a woman from Ballalaba who hid kernel bugs in her djellabah. When her husband found out, he objected loud, and got her expelled from the casbah! Rene.

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Randy Dunlap
On Mon, 23 Jul 2007 19:21:13 -0700 Randy Dunlap wrote: On Mon, 23 Jul 2007 17:12:38 -0700 Andrew Morton wrote: On Sat, 21 Jul 2007 11:17:58 +1000 Rusty Russell [EMAIL PROTECTED] wrote: The netfilter code had very good documentation: the Netfilter Hacking HOWTO. Noone ever read

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Rusty Russell
On Mon, 2007-07-23 at 20:06 -0700, Randy Dunlap wrote: On Mon, 23 Jul 2007 19:21:13 -0700 Randy Dunlap wrote: It's great that Rusty took the time to produce all of this documentation. Few people do that today. Thanks Randy, it was something of an experiment. We'll see if it has the desired