On Tue, 20 Nov 2007, Ingo Molnar wrote:
> * Steven Rostedt <[EMAIL PROTECTED]> wrote:
>
> > With PVOPS on it gives compiler warnings without that explict cast.
> > Without looking at the code, IIRC with non-PVOPS it is a macro
> > directly into asm, so it didn't matter what the cast was. But wit
On Tue, 20 Nov 2007, Ingo Molnar wrote:
>
> i dont think there's ever any true need (and good cause) to force
> integer type casts like that at the callee site.
Unless you mean we should do something like this:
static inline void __wrmsrl(unsigned int msr, unsigned long long val);
#define wrmsr(
* Steven Rostedt <[EMAIL PROTECTED]> wrote:
> > On Fri, Nov 09, 2007 at 04:42:48PM -0200, Glauber de Oliveira Costa wrote:
> > > - wrmsrl(MSR_CSTAR, ia32_cstar_target);
> > > + wrmsrl(MSR_CSTAR, (u64)ia32_cstar_target);
> >
> > Hmm, why do you add explicit casts? The compiler should convert that
On Mon, 19 Nov 2007, Bastian Blank wrote:
> On Fri, Nov 09, 2007 at 04:42:48PM -0200, Glauber de Oliveira Costa wrote:
> > - wrmsrl(MSR_CSTAR, ia32_cstar_target);
> > + wrmsrl(MSR_CSTAR, (u64)ia32_cstar_target);
>
> Hmm, why do you add explicit casts? The compiler should convert that
> correc
* Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote:
> > I'm getting link errors in 32-bit:
> >
> > arch/x86/kernel/built-in.o: In function `native_smp_send_reschedule':
> > /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/smpcommon.c:262:
> > undefined reference to `genapic'
> > arch/x86/k
Am Montag, 19. November 2007 schrieb Rusty Russell:
> This fixes a potential dangling xmit problem.
>
> We also suppress refill interrupts until we need them.
> (Anthony and I have been working on performance recently, so this
> is a WIP).
>
> Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
Tha
