Re: Next steps with pv_ops for Xen

2007-12-03 Thread Gerd Hoffmann
Stephen C. Tweedie wrote: Hi all, driver domains Looked at the gntdev (grant table mappings for user space) driver, noticed that one is not self-contained. It needs a hook for page unmapping: http://xenbits.xensource.com/xen-3.1-testing.hg?rev/7180d2e61f92 plus an

Re: [Xen-devel] Re: Next steps with pv_ops for Xen

2007-12-03 Thread Gerd Hoffmann
Derek Murray wrote: I take the blame for that one. I added the hook because, if a process were to die whilst holding one or more grants, there were no hooks that would make it possible to carry out the grant-unmap. All existing hooks on either the device or the VMA were called *after* the PTEs

Re: [Xen-devel] Re: Next steps with pv_ops for Xen

2007-12-03 Thread Derek Murray
Gerd Hoffmann wrote: Derek Murray wrote: I take the blame for that one. I added the hook because, if a process were to die whilst holding one or more grants, there were no hooks that would make it possible to carry out the grant-unmap. All existing hooks on either the device or the VMA were

Re: [Xen-devel] Re: Next steps with pv_ops for Xen

2007-12-03 Thread Derek Murray
I take the blame for that one. I added the hook because, if a process were to die whilst holding one or more grants, there were no hooks that would make it possible to carry out the grant-unmap. All existing hooks on either the device or the VMA were called *after* the PTEs were cleared. It

Re: [Xen-devel] Re: Next steps with pv_ops for Xen

2007-12-03 Thread Mark Williamson
It gets better, though. The same hook is used in the version of blktap in linux-2.6.18-xen (not, as far as I can see, in the sparse tree for xen-3.1-testing): Oh, I'm thinking more in the direction of killing blktap altogether in favor of a pure userspace implementation on top of

RE: [Xen-devel] Re: Next steps with pv_ops for Xen

2007-12-03 Thread D.G. Murray
Hi Mark, Maybe a change to the gntdev userspace API to allow batching of mapping requests? Something along the lines of the following? /** * Memory maps one or more grant references from one or more domains to a * contiguous local address range. Mappings should be unmapped with *

Re: [Xen-devel] Re: Next steps with pv_ops for Xen

2007-12-03 Thread Mark Williamson
Hi Mark, Maybe a change to the gntdev userspace API to allow batching of mapping requests? Something along the lines of the following? Just like that :-D When you said multiple syscalls per mapping I assumed you meant that we'd lose the batching you get by doing a mulicall. If it's