Anthony Liguori wrote:
It would be very useful too to write vb->num_pages into the config space
whenever it was updated. This way, the host can easily keep track of
where the guest is at in terms of ballooning.
OTOH it's currently pretty obvious (and usually fatal) if the gue
Rusty Russell wrote:
After discussions with Anthony Liguori, it seems that the virtio
balloon can be made even simpler. Here's my attempt.
Since the balloon requires Guest cooperation anyway, there seems
little reason to force it to tell the Host when it wants to reuse a
page. It can simply fa
Hello,
Rusty Russell wrote:
> There are three possibilities: (1) force everyone to use void *, (2)
> force
> everyone to be type-correct, (3) allow both with some tricks. Currently
> we're on (1). For kthread, with only dozens of users, I chose (2) (very
> simple, easy to understand). I
On Saturday 19 January 2008 12:44:52 Tejun Heo wrote:
> Tejun Heo wrote:
> > so I think the question is "do we want to change all callbacks to
> > take native pointer type instead of void pointer?".
>
> Lemme clarity myself a bit. I'm not saying that we should convert all
> at once or literally ev
Exporrt check_tsc_unstable function as GPL symbol. lguest is
a user of it.
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
arch/x86/kernel/tsc_64.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/tsc_64.c b/arch/x86/kernel/tsc_64.c
inde
export __supported_pte_mask variable as GPL symbol.
lguest is a user of it.
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
arch/x86/kernel/setup64.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/setup64.c b/arch/x86/kernel/setup64.c
in
Hello, Rusty.
Rusty Russell wrote:
> On Saturday 19 January 2008 10:12:33 Tejun Heo wrote:
>> Type safety is good but I doubt this would be worth the complexity. It
>> has some benefits but there's much larger benefit in keeping things in
>> straight C. People know that functions take fixed type
x86_64 don't expose the intermediate representation with one underline,
_PAGE_KERNEL, just the double-underlined one.
Use it, to get a common ground between 32 and 64-bit
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
drivers/lguest/page_tables.c |4 ++--
1 files changed, 2
This patch adds the sched.h header explicitly to lguest_user file,
and avoid depending on it being included somewhere else.
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
drivers/lguest/lguest_user.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/driver
This patch adds the hrtimer.h header explicitly to lg.h file,
and avoid depending on it being included somewhere else.
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
drivers/lguest/lg.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/lguest/lg.h
This patch adds the ktime.h header explicitly to hypercalls file,
and avoid depending on it being included somewhere else.
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
drivers/lguest/hypercalls.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/
On Saturday 19 January 2008 10:12:33 Tejun Heo wrote:
> Type safety is good but I doubt this would be worth the complexity. It
> has some benefits but there's much larger benefit in keeping things in
> straight C. People know that functions take fixed types and are also
> familiar with the conven
On Jan 18, 2008 8:02 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
> * Zachary Amsden <[EMAIL PROTECTED]> wrote:
>
> > > but in exchange you broke all of 32-bit with CONFIG_PARAVIRT=y.
> > > Which means you did not even build-test it on 32-bit, let alone boot
> > > test it...
> >
> > Why are we rush
Right now, I have lguest in-tree module compiling on x86_64.
It's not yet on a sendable state, since the module itself isn't loading.
However, this subset of the series is pretty straightforward, and I'm sending it
now aiming at reducing the delta size in the future ;-)
Have fun,
__
On Fri, Jan 18, 2008 at 12:26:13PM -0800, Chris Wright wrote:
> * Glauber de Oliveira Costa ([EMAIL PROTECTED]) wrote:
> > lookup_address() receives two parameters, but efi_64.c call
> > is passing only one. It's actually preventing the tree from compiling
> >
> > Signed-off-by: Glauber de Oliveir
Tejun Heo wrote:
> so I think the question is "do we want to change all callbacks to
> take native pointer type instead of void pointer?".
Lemme clarity myself a bit. I'm not saying that we should convert all
at once or literally every callback should be converted. What I'm
saying is whether we'
Rusty Russell wrote:
> Just a trivial example.
> ---
> drivers/lguest/lguest_device.c |3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -r 00ab7672f658 drivers/lguest/lguest_device.c
> --- a/drivers/lguest/lguest_device.c Thu Jan 17 16:54:00 2008 +1100
> +++ b/drivers/lguest/
Sam Ravnborg wrote:
Are we going to see this for other archs than just x86?
If so then please add this to include/asm-generic/vmlinux.lds.h
In theory other architectures could use a similar mechanism, but for now
its x86 specific.
J
___
Virtu
Zachary Amsden wrote:
Why are we rushing so much to do 64-bit paravirt that we are breaking
working configurations? If the developement is going to be this
chaotic, it should be done and tested out of tree until it can
stabilize.
x86.git is out of the mainline tree, and it seems to be worki
On Saturday 19 January 2008 07:45:41 Jeff Garzik wrote:
> Rusty Russell wrote:
> > -static irqreturn_t lguest_interrupt(int irq, void *_vq)
> > +static irqreturn_t lguest_interrupt(int irq, struct virtqueue *vq)
> > {
> > - struct virtqueue *vq = _vq;
> > struct lguest_device_desc *desc = to
Rusty Russell wrote:
Just a trivial example.
---
drivers/lguest/lguest_device.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -r 00ab7672f658 drivers/lguest/lguest_device.c
--- a/drivers/lguest/lguest_device.cThu Jan 17 16:54:00 2008 +1100
+++ b/drivers/lguest/lguest_devic
Rusty Russell wrote:
This patch lets interrupt handler functions have their natural type
(ie. exactly match the data pointer type); for transition it allows
the old irq_handler_t type as well.
To do this it uses a gcc extension, cast-to-union, which allows a type
to be cast to any type within th
* Zachary Amsden <[EMAIL PROTECTED]> wrote:
> > but in exchange you broke all of 32-bit with CONFIG_PARAVIRT=y.
> > Which means you did not even build-test it on 32-bit, let alone boot
> > test it...
>
> Why are we rushing so much to do 64-bit paravirt that we are breaking
> working configura
On Fri, 2008-01-18 at 22:37 +0100, Ingo Molnar wrote:
> * Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
> > > The first fix is not even specific for PARAVIRT, and it's actually
> > > preventing the whole tree from booting.
> >
> > on CONFIG_EFI, indeed :)
>
> but in exchange you broke all of 32-bit
* Ingo Molnar <[EMAIL PROTECTED]> wrote:
> > The first fix is not even specific for PARAVIRT, and it's actually
> > preventing the whole tree from booting.
>
> on CONFIG_EFI, indeed :)
but in exchange you broke all of 32-bit with CONFIG_PARAVIRT=y. Which
means you did not even build-test it o
On Fri, Jan 18, 2008 at 03:20:24PM -0200, Glauber de Oliveira Costa wrote:
> This patch adds the __parainstructions section to vmlinux.lds.S.
> It's needed for the patching system.
>
> Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
> ---
> arch/x86/kernel/vmlinux_64.lds.S |8 +++
* Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote:
>
> This small series provides some more fixes towards the goal to have
> the PARAVIRT selectable for x86_64. After that, just some more small
> steps are needed.
thanks, applied.
> The first fix is not even specific for PARAVIRT, and it
Just a trivial example.
---
drivers/lguest/lguest_device.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -r 00ab7672f658 drivers/lguest/lguest_device.c
--- a/drivers/lguest/lguest_device.cThu Jan 17 16:54:00 2008 +1100
+++ b/drivers/lguest/lguest_device.cThu Jan 17 16:59
* Glauber de Oliveira Costa ([EMAIL PROTECTED]) wrote:
> lookup_address() receives two parameters, but efi_64.c call
> is passing only one. It's actually preventing the tree from compiling
>
> Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
Good catch, I know I don't test with CONFIG
This patch lets interrupt handler functions have their natural type
(ie. exactly match the data pointer type); for transition it allows
the old irq_handler_t type as well.
To do this it uses a gcc extension, cast-to-union, which allows a type
to be cast to any type within the union. When used in
Glauber de Oliveira Costa wrote:
__pmd, pmd_val and set_pud are used before they are defined (as static)
We move them a little up in the file, so it doesn't happen.
Hm, in my original patches I put the #ifdef CONFIG_X86_PAE below the
PAGETABLE_LEVELS section. Does that work? Or is that an
This patch adds the __parainstructions section to vmlinux.lds.S.
It's needed for the patching system.
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
arch/x86/kernel/vmlinux_64.lds.S |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/v
__pmd, pmd_val and set_pud are used before they are defined (as static)
We move them a little up in the file, so it doesn't happen.
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
include/asm-x86/paravirt.h | 84 ++--
1 files changed, 42
x86_64 lacks a native_init_IRQ() function, so we turn the arch's
init_IRQ() function into a native construct
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
arch/x86/kernel/i8259_64.c |4 +++-
include/asm-x86/hw_irq_64.h |1 +
2 files changed, 4 insertions(+), 1 deletion
This patch adds the constant PARAVIRT needs in asm_offsets_64.c
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
arch/x86/kernel/asm-offsets_64.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/asm-offsets_64.c b/arch/x86/kern
Since the cr8 manipulation functions ended up staying in the tree,
they can't be defined just when PARAVIRT is off: In this patch,
those functions are defined for the PARAVIRT case too.
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
include/asm-x86/system.h | 30 ++
With PARAVIRT, we actually have arch_{dup,exit}_mmap functions,
so we can't include the generic header
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
include/asm-x86/mmu_context_64.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/asm-x86/mmu_co
This patch adds room for read and write_cr8 functions back in
pv_cpu_ops struct
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
include/asm-x86/paravirt.h | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/include/asm-x86/paravirt.h b/include/
We use a __stringify construction at paravirt_patch_64.c.
It's better practice to include the stringify header directly
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
arch/x86/kernel/paravirt_patch_64.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arc
Hi,
This small series provides some more fixes towards the goal
to have the PARAVIRT selectable for x86_64. After that, just
some more small steps are needed.
The first fix is not even specific for PARAVIRT, and it's actually
preventing the whole tree from booting.
_
lookup_address() receives two parameters, but efi_64.c call
is passing only one. It's actually preventing the tree from compiling
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
arch/x86/kernel/efi_64.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/ar
This patch fills in the read and write cr8 fields with their
native version
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
arch/x86/kernel/paravirt.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt
42 matches
Mail list logo
