Re: [PATCH RFC 4/5] tun: vringfd xmit support.

2008-04-06 Thread Herbert Xu
Rusty Russell <[EMAIL PROTECTED]> wrote: > > +/* We are done with this skb: put it in the used pile. */ > +static void skb_finished(struct skb_shared_info *sinfo) > +{ > + struct skb_shinfo_tun *sht = (void *)(sinfo + 1); > + > + /* FIXME: Race prevention */ > + vring_used_buffer_

[PATCH] virtio: remove overzealous BUG_ON.

2008-04-06 Thread Rusty Russell
The 'disable_cb' callback is designed as an optimization to tell the host we don't need callbacks now. As it is not reliable, the debug check is overzealous: it can happen on two CPUs at the same time. Document this. Even if it were reliable, the virtio_net driver doesn't disable callbacks on tr

Re: [PATCHv3 1/3] x86: use ELF format in compressed images.

2008-04-06 Thread H. Peter Anvin
Yinghai Lu wrote: > On Sun, Apr 6, 2008 at 9:38 AM, H. Peter Anvin <[EMAIL PROTECTED]> wrote: >> Yinghai Lu wrote: >> >>> so will cost every bzImage extra memory copy? that could be 18M or >>> even more big. >>> >> I wouldn't worry about that. You will typically have several copies of the >> imag

Re: [PATCHv3 1/3] x86: use ELF format in compressed images.

2008-04-06 Thread H. Peter Anvin
Yinghai Lu wrote: > so will cost every bzImage extra memory copy? that could be 18M or > even more big. I wouldn't worry about that. You will typically have several copies of the images during the execution of the boot loader. -hpa ___ Virtual

Re: [PATCHv3 1/3] x86: use ELF format in compressed images.

2008-04-06 Thread Ian Campbell
On Sun, 2008-04-06 at 00:03 -0700, Yinghai Lu wrote: > so will cost every bzImage extra memory copy? that could be 18M or > even more big. Is it a huge deal for something that happens exactly once on boot? How does the time take compare with the time to do the decompression? 18M seems like an aw

Re: [kvm-devel] [Patch][00/18] kvm-ia64 for kernel V10

2008-04-06 Thread Avi Kivity
Zhang, Xiantao wrote: > Compared with V9, just fixed indentation issues in patch 12. I put it > the patchset in > git://git.kernel.org/pub/scm/linux/kernel/git/xiantao/kvm-ia64.git > kvm-ia64-mc10. Please help to review. > Specially, the first two patches (TR Management patch and > smp_call_functi

Re: kernel BUG at drivers/virtio/virtio_ring.c:218!

2008-04-06 Thread Balaji Rao
On Sunday 06 April 2008 12:56:33 pm Rusty Russell wrote: > On Sunday 06 April 2008 00:53:39 Balaji Rao wrote: > > On Friday 04 April 2008 01:46:21 pm Balaji Rao wrote: > > > Hi Rusty, > > > > > > I hit a bug in virtio_ring.c:218 when I was stressing virtio_net using > > > kvm with -smp 4. > > > > >

Re: kernel BUG at drivers/virtio/virtio_ring.c:218!

2008-04-06 Thread Rusty Russell
On Sunday 06 April 2008 00:53:39 Balaji Rao wrote: > On Friday 04 April 2008 01:46:21 pm Balaji Rao wrote: > > Hi Rusty, > > > > I hit a bug in virtio_ring.c:218 when I was stressing virtio_net using > > kvm with -smp 4. > > > > static void vring_disable_cb(struct virtqueue *_vq) > > { > >