Re: [PATCH RFC 2/5] vringfd base/offset

2008-04-07 Thread Arnd Bergmann
On Saturday 05 April 2008, Rusty Russell wrote: >  static const struct file_operations vring_fops = { > .release= vring_release, > .write  = vring_write, > .poll   = vring_poll, > +   .ioctl  = vring_ioctl, >  }; This should also set the

Re: [PATCH RFC 1/5] vringfd syscall

2008-04-07 Thread Arnd Bergmann
On Saturday 05 April 2008, Rusty Russell wrote: > +asmlinkage long sys_vringfd(void __user *addr, > +       unsigned num_descs, > +       u16 __user *last_used) > +{ > +   int fd, err; > +   struct file *filp; > +   struct vring_info *vr; > + > + 

Re: Call for Presentations: KVM Forum 2008

2008-04-07 Thread Rusty Russell
On Tuesday 08 April 2008 10:17:26 Avi Kivity wrote: > [Note: KVM Forum registration is now open at > http://kforum.qumranet.com/KVMForum/about_kvmforum.php] > > This is the Call for Presentations for the second annual KVM Developer's > Forum, to be held on June 10-13, 2008, in Napa, California, USA

Re: [PATCH RFC 4/5] tun: vringfd xmit support.

2008-04-07 Thread Rusty Russell
On Monday 07 April 2008 17:35:28 David Miller wrote: > From: Rusty Russell <[EMAIL PROTECTED]> > Date: Mon, 7 Apr 2008 17:24:51 +1000 > > > On Monday 07 April 2008 15:13:44 Herbert Xu wrote: > > > On second thought, this is not going to work. The network stack > > > can clone individual pages out

Re: [PATCH RFC 1/5] vringfd syscall

2008-04-07 Thread Rusty Russell
On Tuesday 08 April 2008 03:54:34 Jonathan Corbet wrote: > Hey, Rusty, > > > For virtualization, we've developed virtio_ring for efficient > > communication. This would also work well for userspace-kernel > > communication, particularly for things like the tun device. By using the > > same ABI, we

Call for Presentations: KVM Forum 2008

2008-04-07 Thread Avi Kivity
[Note: KVM Forum registration is now open at http://kforum.qumranet.com/KVMForum/about_kvmforum.php] This is the Call for Presentations for the second annual KVM Developer's Forum, to be held on June 10-13, 2008, in Napa, California, USA [1]. We are looking for presentations on KVM development,

[PATCH] virtio_net: remove overzealous printk

2008-04-07 Thread Anthony Liguori
The 'disable_cb' is really just a hint and as such, it's possible for more work to get queued up while callbacks are disabled. Under stress with an SMP guest, this printk triggers very frequently. There is no race here, this is how things are designed to work so let's just remove the printk. Sig

Re: [PATCH] virtio: remove overzealous BUG_ON.

2008-04-07 Thread Rusty Russell
On Monday 07 April 2008 23:50:24 Anthony Liguori wrote: > Rusty Russell wrote: > > The 'disable_cb' callback is designed as an optimization to tell the host > > we don't need callbacks now. As it is not reliable, the debug check is > > overzealous: it can happen on two CPUs at the same time. Docu

Re: [PATCHv3 1/3] x86: use ELF format in compressed images.

2008-04-07 Thread Yinghai Lu
On Sun, Apr 6, 2008 at 9:38 AM, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Yinghai Lu wrote: > > > so will cost every bzImage extra memory copy? that could be 18M or > > even more big. > > > > I wouldn't worry about that. You will typically have several copies of the > images during the executio

Re: [PATCHv3 1/3] x86: use ELF format in compressed images.

2008-04-07 Thread Yinghai Lu
On Sun, Apr 6, 2008 at 10:25 AM, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > > Yinghai Lu wrote: > > > On Sun, Apr 6, 2008 at 9:38 AM, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > > > > > Yinghai Lu wrote: > > > > > > > > > > so will cost every bzImage extra memory copy? that could be 18M or > > > >

Re: [PATCHv3 1/3] x86: use ELF format in compressed images.

2008-04-07 Thread Yinghai Lu
On Wed, Feb 13, 2008 at 1:54 PM, Ian Campbell <[EMAIL PROTECTED]> wrote: > This allows other boot loaders such as the Xen domain builder the > opportunity to extract the ELF file. > > Signed-off-by: Ian Campbell <[EMAIL PROTECTED]> > Cc: Thomas Gleixner <[EMAIL PROTECTED]> > Cc: Ingo Molnar <[E

Re: [PATCH] virtio: remove overzealous BUG_ON.

2008-04-07 Thread Anthony Liguori
Rusty Russell wrote: > The 'disable_cb' callback is designed as an optimization to tell the host > we don't need callbacks now. As it is not reliable, the debug check is > overzealous: it can happen on two CPUs at the same time. Document this. > > Even if it were reliable, the virtio_net driver

Re: [PATCH RFC 4/5] tun: vringfd xmit support.

2008-04-07 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Mon, 7 Apr 2008 17:24:51 +1000 > On Monday 07 April 2008 15:13:44 Herbert Xu wrote: > > On second thought, this is not going to work. The network stack > > can clone individual pages out of this skb and put it into a new > > skb. Therefore whatever s

Re: [PATCH RFC 4/5] tun: vringfd xmit support.

2008-04-07 Thread Rusty Russell
On Monday 07 April 2008 15:13:44 Herbert Xu wrote: > Rusty Russell <[EMAIL PROTECTED]> wrote: > > +/* We are done with this skb: put it in the used pile. */ > > +static void skb_finished(struct skb_shared_info *sinfo) > > +{ > > + struct skb_shinfo_tun *sht = (void *)(sinfo + 1); > > + > > +