Re: [PATCH 1/4] Add helper functions for paravirtual clocksources.

2008-05-22 Thread Jeremy Fitzhardinge
Gerd Hoffmann wrote: Jeremy Fitzhardinge wrote: +static unsigned pvclock_get_time_values(struct pvclock_shadow_time *dst, +struct kvm_vcpu_time_info *src) I think the kvm_* types should be renamed. xen_* would make some sense since the ABI originated with

Re: [Fwd: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe]

2008-05-22 Thread Jens Axboe
On Thu, May 22 2008, Rusty Russell wrote: On Wednesday 21 May 2008 23:12:39 Chris Lalancette wrote: diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 4962e62..c678ac5 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -294,6 +294,7 @@

Re: [Fwd: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe]

2008-05-22 Thread Chris Lalancette
Jens Axboe wrote: On Thu, May 22 2008, Rusty Russell wrote: On Wednesday 21 May 2008 23:12:39 Chris Lalancette wrote: diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 4962e62..c678ac5 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@

Re: [Fwd: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe]

2008-05-22 Thread Jens Axboe
On Thu, May 22 2008, Chris Lalancette wrote: Jens Axboe wrote: On Thu, May 22 2008, Rusty Russell wrote: On Wednesday 21 May 2008 23:12:39 Chris Lalancette wrote: diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 4962e62..c678ac5 100644 ---

Re: [Fwd: [PATCH]: Fix silly output for virtio devices in /proc/interrupts]

2008-05-22 Thread Chris Lalancette
Rusty Russell wrote: On Wednesday 21 May 2008 23:13:05 Chris Lalancette wrote: Author: Chris Lalancette [EMAIL PROTECTED] Date: Thu May 15 09:04:55 2008 -0400 register_virtio_device was doing something silly, in that it was overwriting what the calling driver stuck into .bus_id for the

Re: [Fwd: [PATCH]: Fix silly output for virtio devices in /proc/interrupts]

2008-05-22 Thread Christian Borntraeger
Am Donnerstag, 22. Mai 2008 schrieb Rusty Russell: virtio: S/390 set name of virtio devices directly. Chris has a patch 'Fix silly output for virtio devices in /proc/interrupts' which requires callers to the virtio driver infrastructure to set the bus_ids themselves. This does that for