RE: [PATCH 08/27] ia64/xen: define helper functions for xen hypercalls.

2008-06-17 Thread Luck, Tony
+/* + * Hypercalls without parameter. + */ +#define __HCALL0(name,hcall) \ + GLOBAL_ENTRY(name); \ + break hcall; \ Should Linux code be made aware of the "break" numbers that are being used for hypercalls (so it doesn't try to re-use them for

Re: [Xen-ia64-devel] [PATCH 04/27] ia64/xen: introduce definitions necessary for ia64/xen hypercalls.

2008-06-17 Thread Aron Griffis
Hi Yamahata-san, Who is the copyright holder on this file? Thanks, Aron Isaku Yamahata wrote: [Tue Jun 10 2008, 03:47:00AM EDT] > diff --git a/include/asm-ia64/xen/interface.h > b/include/asm-ia64/xen/interface.h > new file mode 100644 > index 000..c0770a4 > --- /dev/null > +++ b/include/a

RE: [PATCH 06/27] ia64/xen: define NET_SKB_NET to 18 if xen.

2008-06-17 Thread Luck, Tony
> Resolve it by increasing NET_SKB_NET from the default value 16 to 18. Typo? You mean NET_SKB_PAD here? But in include/linux/skbuff.h it says: "It must be a power of 2". Explain why 18 is ok. -Tony ___ Virtualization mailing list Virtualization@list

RE: [PATCH 04/27] ia64/xen: introduce definitions necessary for ia64/xen hypercalls.

2008-06-17 Thread Luck, Tony
03/27 was fine. 04/27 ... I've no idea what it is all for ... I expect I'll find out later in the patch series :-) One style quibble ... I don't see much of this elsewhere in the Linux code: +/* + * Local variables: + * mode: C + * c-set-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * ind

RE: [PATCH 02/27] ia64/xen: introduce synch bitops which is necessary for ia64/xen support.

2008-06-17 Thread Luck, Tony
Just started digging through these ... part 01/27 was fine. But here are a couple of comments for part 02/27 +/* + * Copyright 1992, Linus Torvalds. + * Heavily modified to provide guaranteed strong synchronisation + * when communicating with Xen or other guest OSes running on other CPUs. + */ Pr