Re: [RFC 1/3 v2] hvc_console: rework setup to replace irq functions with callbacks

2008-06-26 Thread Rusty Russell
On Friday 20 June 2008 23:24:08 Christian Borntraeger wrote: > I also kept hvc_struct defined in hvc_console.h so that hvc_irq.c can > access the irq_requested element. Added this fix: Fix compile of hvc_rtas.c Moving the struct definition out to the header had bad effect under one ppc64 config

Re: [PATCH 4/4] lguest: Use GSO/IFF_VNET_HDR extensions on tun/tap

2008-06-26 Thread Rusty Russell
On Friday 27 June 2008 04:16:25 Anthony Liguori wrote: > Rusty Russell wrote: > > On Thursday 26 June 2008 05:07:18 Anthony Liguori wrote: > >> Rusty Russell wrote: > >>> + add_feature(dev, VIRTIO_NET_F_GUEST_CSUM); > >> > >> You set this feature, but I never see the virtio-net driver acknowledge >

Re: [PATCH 4/4] lguest: Use GSO/IFF_VNET_HDR extensions on tun/tap

2008-06-26 Thread Anthony Liguori
Rusty Russell wrote: > On Thursday 26 June 2008 05:07:18 Anthony Liguori wrote: > >> Rusty Russell wrote: >> >>> @@ -1563,6 +1561,16 @@ static void setup_tun_net(char *arg) >>> /* Tell Guest what MAC address to use. */ >>> add_feature(dev, VIRTIO_NET_F_MAC); >>> add_feature(dev,