Re: [PATCH] stopmachine: add stopmachine_timeout

2008-07-14 Thread Heiko Carstens
> >> So I think monotonic wallclock time actually makes the most sense here. > > > > This is asking for trouble... a config option to disable this would be > > nice. But as I don't know which problem this patch originally addresses > > it might be that this is needed anyway. So lets see why we nee

Re: [PATCH] tun: Fix/rewrite packet filtering logic

2008-07-14 Thread David Miller
From: Max Krasnyansky <[EMAIL PROTECTED]> Date: Sat, 12 Jul 2008 01:52:54 -0700 > This is on top of the latest and greatest :). Assuming virt folks are ok with > the API this should go into 2.6.27. Really? :-) It doesn't apply cleanly to net-next-2.6, as I just tried to stick this into my tree.

Re: [PATCH] tun: Fix/rewrite packet filtering logic

2008-07-14 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Mon, 14 Jul 2008 22:16:02 -0700 (PDT) > It doesn't apply cleanly to net-next-2.6, as I just tried to > stick this into my tree. Ignore this, I did something stupid. ___ Virtualization mailing list Virtualizat

Re: [PATCH 4/5] virtio net: Allow receiving SG packets

2008-07-14 Thread Herbert Xu
On Mon, Jul 14, 2008 at 10:41:38PM -0500, Rusty Russell wrote: > > + /* If we can receive ANY GSO packets, we must allocate large ones. */ > + if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) > + || virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) > + || virtio_has_fea

Re: [PATCH 3/5] virtio net: Add ethtool ops for SG/GSO

2008-07-14 Thread Herbert Xu
On Mon, Jul 14, 2008 at 10:40:49PM -0500, Rusty Russell wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > > This patch adds some basic ethtool operations to virtio_net so > I could test SG without GSO (which was really useful because TSO > turned out to be buggy :) > > Signed-off-by: Rusty Russell

[PATCH 5/5] virtio_net: Recycle unused recv buffer pages for large skbs in net driver

2008-07-14 Thread Rusty Russell
If we hack the virtio_net driver to always allocate full-sized (64k+) skbuffs, the driver slows down (lguest numbers): Time to receive 1GB (small buffers): 10.85 seconds Time to receive 1GB (64k+ buffers): 24.75 seconds Of course, large buffers use up more space in the ring, so we increase t

[PATCH 4/5] virtio net: Allow receiving SG packets

2008-07-14 Thread Rusty Russell
From: Herbert Xu <[EMAIL PROTECTED]> Finally this patch lets virtio_net receive GSO packets in addition to sending them. This can definitely be optimised for the non-GSO case. For comparison the Xen approach stores one page in each skb and uses subsequent skb's pages to construct an SG skb inste

[PATCH 3/5] virtio net: Add ethtool ops for SG/GSO

2008-07-14 Thread Rusty Russell
From: Herbert Xu <[EMAIL PROTECTED]> This patch adds some basic ethtool operations to virtio_net so I could test SG without GSO (which was really useful because TSO turned out to be buggy :) Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> (remove MTU setting) --- drivers/net/virtio_net.c | 18

[PATCH 1/5] virtio_net: Set VIRTIO_NET_F_GUEST_CSUM feature

2008-07-14 Thread Rusty Russell
(I know you already have this, but included for completeness) From: Mark McLoughlin <[EMAIL PROTECTED]> We can handle receiving partial csums, so set the appropriate feature bit. Signed-off-by: Mark McLoughlin <[EMAIL PROTECTED]> Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- drivers/net/

Re: [PATCH] stopmachine: add stopmachine_timeout

2008-07-14 Thread Max Krasnyansky
Hidetoshi Seto wrote: > Heiko Carstens wrote: >> Hmm.. probably a stupid question: but what could happen that a real cpu >> (not virtual) becomes unresponsive so that it won't schedule a MAX_RT_PRIO-1 >> prioritized task for 5 seconds? > > The original problem (once I heard and easily reproduced

Re: [PATCH] stopmachine: add stopmachine_timeout

2008-07-14 Thread Max Krasnyansky
Heiko Carstens wrote: > On Mon, Jul 14, 2008 at 11:56:18AM -0700, Jeremy Fitzhardinge wrote: >> Rusty Russell wrote: >>> On Monday 14 July 2008 21:51:25 Christian Borntraeger wrote: Am Montag, 14. Juli 2008 schrieb Hidetoshi Seto: > + /* Wait all others come to life */ > +

Re: [PATCH] stopmachine: add stopmachine_timeout

2008-07-14 Thread Rusty Russell
On Tuesday 15 July 2008 07:20:26 Heiko Carstens wrote: > On Mon, Jul 14, 2008 at 11:56:18AM -0700, Jeremy Fitzhardinge wrote: > > Rusty Russell wrote: > > > On Monday 14 July 2008 21:51:25 Christian Borntraeger wrote: > > >> Am Montag, 14. Juli 2008 schrieb Hidetoshi Seto: > > >>> + /* Wait a

Re: [PATCH] stopmachine: add stopmachine_timeout

2008-07-14 Thread Heiko Carstens
On Mon, Jul 14, 2008 at 11:56:18AM -0700, Jeremy Fitzhardinge wrote: > Rusty Russell wrote: > > On Monday 14 July 2008 21:51:25 Christian Borntraeger wrote: > >> Am Montag, 14. Juli 2008 schrieb Hidetoshi Seto: > >> > >>> + /* Wait all others come to life */ > >>> + while (cpus_weight(prepared

Re: [PATCH] stopmachine: add stopmachine_timeout

2008-07-14 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > On Monday 14 July 2008 21:51:25 Christian Borntraeger wrote: > >> Am Montag, 14. Juli 2008 schrieb Hidetoshi Seto: >> >>> + /* Wait all others come to life */ >>> + while (cpus_weight(prepared_cpus) != num_online_cpus() - 1) { >>> + if (time_is_before_ji

Re: [PATCH] stopmachine: add stopmachine_timeout

2008-07-14 Thread Rusty Russell
On Monday 14 July 2008 21:51:25 Christian Borntraeger wrote: > Am Montag, 14. Juli 2008 schrieb Hidetoshi Seto: > > + /* Wait all others come to life */ > > + while (cpus_weight(prepared_cpus) != num_online_cpus() - 1) { > > + if (time_is_before_jiffies(limit)) > > +