Re: [PATCH RFC 0/2] qemu-kvm: MSI-X support

2009-05-11 Thread Anthony Liguori
Michael S. Tsirkin wrote: > Here's a draft MSI-X support patch. Among missing features: > save/load support, and command-line flag to control the > feature. This is on top of qemu-kvm: msi-x is disabled > without kvm interrupt injection support for now. > What's your impression of how much work

[PATCH 2/3] virtio_pci: split up vp_interrupt

2009-05-11 Thread Michael S. Tsirkin
This reorganizes virtio-pci code in vp_interrupt slightly, so that it's easier to add per-vq MSI support on top. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_pci.c | 53 +++--- 1 files changed, 34 insertions(+), 19 deletions(-) diff --git a/d

[PATCH 3/3] virtio_pci: optional MSI-X support

2009-05-11 Thread Michael S. Tsirkin
This implements optional MSI-X support in virtio_pci. MSI-X is used whenever the host supports at least 2 MSI-X vectors: 1 for configuration changes and 1 for virtqueues. Per-virtqueue vectors are allocated if enough vectors available. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_

[PATCHv3 0/3] virtio: MSI-X support

2009-05-11 Thread Michael S. Tsirkin
Here's an updated draft of virtio patches which work with the qemu-kvm code that I just posted. This still needs to be rebased on top of Rusty's recent virtqueue list patch. I am posting it in case people want to start trying MSI-X out. Michael S. Tsirkin (3): virtio: find_vqs/del_vqs virtio ope

[PATCH 1/3] virtio: find_vqs/del_vqs virtio operations

2009-05-11 Thread Michael S. Tsirkin
This replaces find_vq/del_vq with find_vqs/del_vqs virtio operations, and updates all drivers. This is needed for MSI support, because MSI needs to know the total number of vectors upfront. Signed-off-by: Michael S. Tsirkin --- drivers/block/virtio_blk.c | 11 +++--- drivers/char/hw_r

[PATCH RFC 0/2] qemu-kvm: MSI-X support

2009-05-11 Thread Michael S. Tsirkin
Here's a draft MSI-X support patch. Among missing features: save/load support, and command-line flag to control the feature. This is on top of qemu-kvm: msi-x is disabled without kvm interrupt injection support for now. Michael S. Tsirkin (2): qemu-kvm: add MSI-X support qemu-kvm: use common c

[PATCH 1/2] qemu-kvm: add MSI-X support

2009-05-11 Thread Michael S. Tsirkin
This adds (incomplete) MSI-X support to virtio net device. Missing is save/load support, and command-line flag to control the feature. Signed-off-by: Michael S. Tsirkin --- Makefile.target |2 +- hw/msix.c | 362 +++ hw/msix.h

[PATCH 2/2] qemu-kvm: use common code for assigned msix

2009-05-11 Thread Michael S. Tsirkin
For assigned devices, use common code to enable msi-x. Add "hack" option as assigned devices lack a standard way to get vector usage. Signed-off-by: Michael S. Tsirkin --- hw/device-assignment.c | 336 hw/device-assignment.h |8 +- hw/msix.c

Re: [PATCH] xen/blkfront: remove driver_data direct access of struct device

2009-05-11 Thread Jeremy Fitzhardinge
Roel Kluin wrote: > To avoid direct access to the driver_data pointer in struct device, the > functions dev_get_drvdata() and dev_set_drvdata() should be used. > Are these the same as the ones Greg KH posted last week? J > Signed-off-by: Roel Kluin > --- > diff --git a/drivers/block/xen-

[PATCH 3] xen-netfront: remove driver_data direct access of struct device

2009-05-11 Thread Roel Kluin
To avoid direct access to the driver_data pointer in struct device, the functions dev_get_drvdata() and dev_set_drvdata() should be used. Signed-off-by: Roel Kluin --- diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index f673253..8d88dae 100644 --- a/drivers/net/xen-netfront

[PATCH] xen pvfb: remove driver_data direct access of struct device

2009-05-11 Thread Roel Kluin
To avoid direct access to the driver_data pointer in struct device, the functions dev_get_drvdata() and dev_set_drvdata() should be used. Signed-off-by: Roel Kluin --- diff --git a/drivers/input/xen-kbdfront.c b/drivers/input/xen-kbdfront.c index 928d2ed..b115726 100644 --- a/drivers/input/xen-kb

[PATCH 2] xen pvfb: remove driver_data direct access of struct device

2009-05-11 Thread Roel Kluin
To avoid direct access to the driver_data pointer in struct device, the functions dev_get_drvdata() and dev_set_drvdata() should be used. Signed-off-by: Roel Kluin --- And another few, also see http://lkml.org/lkml/2009/5/4/353 diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront

[PATCH] xen/blkfront: remove driver_data direct access of struct device

2009-05-11 Thread Roel Kluin
To avoid direct access to the driver_data pointer in struct device, the functions dev_get_drvdata() and dev_set_drvdata() should be used. Signed-off-by: Roel Kluin --- diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 8f90508..ff09809 100644 --- a/drivers/block/xen-bl

Re: [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC)

2009-05-11 Thread Mark McLoughlin
On Mon, 2009-05-04 at 11:49 +0930, Rusty Russell wrote: > On Mon, 27 Apr 2009 05:13:53 pm Dor Laor wrote: > > Mark McLoughlin wrote: > > > Hi Rusty, > > > > > > On Thu, 2008-12-18 at 17:10 +, Mark McLoughlin wrote: > > > > > >> Add a new feature flag for indirect ring entries. These are ring