Re: [PATCH 1/4] virtio_blk: deprecate the 1024-byte ID field.

2009-09-30 Thread Christian Borntraeger
Am Dienstag 29 September 2009 19:18:09 schrieb Rusty Russell: PCI, lguest and s390 can all only support 256-byte configuration space. So, this giant field broke just about everyone. Unfortunately, removing it is not so simple: we don't want to break old userspace, but we're going to want to

[PATCH] virtio_ids: let virtio header files include virtio_ids.h and export it

2009-09-30 Thread Christian Borntraeger
[PATCH] virtio_ids: let header files include virtio_ids.h Rusty, commit 3ca4f5ca73057a617f9444a91022d7127041970a virtio: add virtio IDs file moved all device IDs into a single file. While the change itself is a very good one, it can break userspace applications. For example if a userspace

Re: [PATCH] virtio_ids: let virtio header files include virtio_ids.h and export it

2009-09-30 Thread Rusty Russell
On Wed, 30 Sep 2009 06:47:21 pm Christian Borntraeger wrote: [PATCH] virtio_ids: let header files include virtio_ids.h Thanks, applied. Rusty. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [Pv-drivers] [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread Arnd Bergmann
On Tuesday 29 September 2009, David Miller wrote: These header files are indeed shared with the host implementation, as you've guessed. If it's not a big deal, we would like to keep the names the same, just for our own sanity's sake? No. This isn't your source tree, it's everyone's.

RE: [Pv-drivers] [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread Bhavesh Davda
Hi Chris, Thanks a bunch for your really thorough review! I'll answer some of your questions here. Shreyas can respond to your comments about some of the coding style/comments/etc. in a separate mail. INTx, MSI, MSI-X (25 vectors) interrupts 16 Rx queues, 8 Tx queues

RE: [Pv-drivers] [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread Bhavesh Davda
Hi Arnd, On Tuesday 29 September 2009, Chris Wright wrote: +struct Vmxnet3_MiscConf { + struct Vmxnet3_DriverInfo driverInfo; + uint64_t uptFeatures; + uint64_t ddPA; /* driver data PA */ + uint64_t queueDescPA;

RE: [Pv-drivers] [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread Bhavesh Davda
Thanks a bunch for your really thorough review! I'll answer some of your questions here. Shreyas can respond to your comments about some of the coding style/comments/etc. in a separate mail. The style is less important at this stage, but certainly eases review to make it more consistent w/

Re: [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication

2009-09-30 Thread Amit Shah
On (Tue) Sep 29 2009 [15:31:23], Christian Borntraeger wrote: Am Dienstag 29 September 2009 15:09:50 schrieb Amit Shah: Great, thanks. However I was thinking of moving this init to the probe() routine instead of in the init_conosle routine just because multiple consoles can be added and we

virtio-blk + suspend to disk

2009-09-30 Thread Gleb Natapov
Hi, Does anybody knows is subject supported? It doesn't work and it seems that virtio-pci device has no way to know that suspend/resume happened. -- Gleb. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCHv5 3/3] vhost_net: a kernel-level virtio server

2009-09-30 Thread Gregory Haskins
Avi Kivity wrote: On 09/26/2009 12:32 AM, Gregory Haskins wrote: I realize in retrospect that my choice of words above implies vbus _is_ complete, but this is not what I was saying. What I was trying to convey is that vbus is _more_ complete. Yes, in either case some kind of glue needs to

INFO: task journal:337 blocked for more than 120 seconds

2009-09-30 Thread Shirley Ma
Hello all, Anybody found this problem before? I kept hitting this issue for 2.6.31 guest kernel even with a simple network test. INFO: task kjournal:337 blocked for more than 120 seconds. echo 0 /proc/sys/kernel/hung_task_timeout_sec disables this message. kjournald D 0041 0

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread Stephen Hemminger
On Wed, 30 Sep 2009 14:34:57 -0700 (PDT) Shreyas Bhatewara sbhatew...@vmware.com wrote: Note: your patch was linewrapped again + + +static void +vmxnet3_declare_features(struct vmxnet3_adapter *adapter, bool dma64) +{ + struct net_device *netdev = adapter-netdev; + +

RE: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread Shreyas Bhatewara
Stephen, Thanks for taking a look. -Original Message- From: Stephen Hemminger [mailto:shemmin...@vyatta.com] Sent: Wednesday, September 30, 2009 5:39 PM To: Shreyas Bhatewara Cc: linux-kernel; netdev; Stephen Hemminger; David S. Miller; Jeff Garzik; Anthony Liguori; Chris Wright;

Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3

2009-09-30 Thread David Miller
From: Stephen Hemminger shemmin...@vyatta.com Date: Wed, 30 Sep 2009 17:39:23 -0700 Why not use NETIF_F_LRO and ethtool to control LRO support? In fact, you must, in order to handle bridging and routing correctly. Bridging and routing is illegal with LRO enabled, so the kernel automatically