Re: [PULL] virtio fixes

2009-10-22 Thread Rusty Russell
On Thu, 22 Oct 2009 10:01:43 am Linus Torvalds wrote: On Mon, 19 Oct 2009, Rusty Russell wrote: ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git master Already up-to-date.. Forgot to push? Oops, overzealous master.kernel.org space reclamation

[PATCH] virtio-pci: fix per-vq MSI-X request logic

2009-10-22 Thread Michael S. Tsirkin
Commit f68d24082e22ccee3077d11aeb6dc5354f0ca7f1 in 2.6.32-rc1 broke requesting IRQs for per-VQ MSI-X vectors: - vector number was used instead of the vector itself - we try to request an IRQ for VQ which does not have a callback handler This is a regression that causes warnings in kernel log,

Re: [PATCH] virtio-pci: fix per-vq MSI-X request logic

2009-10-22 Thread Marcelo Tosatti
On Thu, Oct 22, 2009 at 03:06:06PM +0200, Michael S. Tsirkin wrote: Commit f68d24082e22ccee3077d11aeb6dc5354f0ca7f1 in 2.6.32-rc1 broke requesting IRQs for per-VQ MSI-X vectors: - vector number was used instead of the vector itself - we try to request an IRQ for VQ which does not have a

Re: INDIRECT and NEXT

2009-10-22 Thread Rusty Russell
On Thu, 22 Oct 2009 08:07:45 pm Michael S. Tsirkin wrote: Imagine an indirect entry where NEXT bit is also set. Hmm, so it's not obvious whether the kvm userspace code handles it correctly either. Want to hack something up to use NEXT + INDIRECT, then we can actually test it? If it doesn't