[PATCH] virtio: set pci bus master enable bit

2009-11-29 Thread Michael S. Tsirkin
As all virtio devices perform DMA, we must enable bus mastering for them to be spec compliant. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/virtio/virtio_pci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/virtio/virtio_pci.c

Re: [PATCH 08/28] virtio: console: remove global var

2009-11-29 Thread Rusty Russell
On Sat, 28 Nov 2009 05:20:31 pm Amit Shah wrote: From: Rusty Russell ru...@rustcorp.com.au Now we can use an allocation function to remove our global console variable. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Amit Shah amit.s...@redhat.com ---

Re: [PATCH 07/28] virtio: console: don't assume a single console port.

2009-11-29 Thread Rusty Russell
On Sat, 28 Nov 2009 05:20:30 pm Amit Shah wrote: Keep a list of all ports being used as a console, and provide a lock and a lookup function. The hvc callbacks only give us a vterm number, so we need to map this. OK, I think we can do better than this. How about we introduce a 'struct

Re: [PATCH 09/28] virtio: console: struct ports for multiple ports per device.

2009-11-29 Thread Rusty Russell
On Sat, 28 Nov 2009 05:20:32 pm Amit Shah wrote: @@ -196,7 +216,9 @@ static void virtcons_apply_config(struct virtio_device *dev) dev-config-get(dev, offsetof(struct virtio_console_config, rows), ws.ws_row,

Re: [PATCH 07/28] virtio: console: don't assume a single console port.

2009-11-29 Thread Amit Shah
On (Mon) Nov 30 2009 [12:20:02], Rusty Russell wrote: On Sat, 28 Nov 2009 05:20:30 pm Amit Shah wrote: Keep a list of all ports being used as a console, and provide a lock and a lookup function. The hvc callbacks only give us a vterm number, so we need to map this. OK, I think we can do

Re: [PATCH 08/28] virtio: console: remove global var

2009-11-29 Thread Amit Shah
On (Mon) Nov 30 2009 [12:27:21], Rusty Russell wrote: On Sat, 28 Nov 2009 05:20:31 pm Amit Shah wrote: From: Rusty Russell ru...@rustcorp.com.au Now we can use an allocation function to remove our global console variable. Signed-off-by: Rusty Russell ru...@rustcorp.com.au

Re: [PATCH 09/28] virtio: console: struct ports for multiple ports per device.

2009-11-29 Thread Amit Shah
On (Mon) Nov 30 2009 [12:39:52], Rusty Russell wrote: On Sat, 28 Nov 2009 05:20:32 pm Amit Shah wrote: @@ -196,7 +216,9 @@ static void virtcons_apply_config(struct virtio_device *dev) dev-config-get(dev, offsetof(struct virtio_console_config,