Re: [PATCH 18/31] virtio: console: Buffer data that comes from the host

2010-01-04 Thread Amit Shah
On (Mon) Jan 04 2010 [19:45:30], Rusty Russell wrote: > On Wed, 23 Dec 2009 01:04:28 am Amit Shah wrote: > > The console could be flooded with data from the host; handle this > > situation by buffering the data. > > Is this still true? If we only add_buf when we're ready, surely the host > can't

Re: [PATCH 18/31] virtio: console: Buffer data that comes from the host

2010-01-04 Thread Rusty Russell
On Wed, 23 Dec 2009 01:04:28 am Amit Shah wrote: > The console could be flooded with data from the host; handle this > situation by buffering the data. Is this still true? If we only add_buf when we're ready, surely the host can't flood us with one virtqueue per port? Thanks, Rusty.

Re: [Qemu-devel] Re: [PATCH v2] virtio-blk physical block size

2010-01-04 Thread Christoph Hellwig
On Mon, Jan 04, 2010 at 01:38:51PM +1030, Rusty Russell wrote: > I thought this was what I was doing, but I have shown over and over that > I have no idea about block devices. > > Our current driver treats BLK_SIZE as the logical and physical size (see > blk_queue_logical_block_size). > > I have