Re: [PATCH 1/2] Add 'serial' attribute to virtio-blk devices

2010-06-20 Thread john cooper
Rusty Russell wrote: > On Sat, 19 Jun 2010 04:08:02 am Ryan Harper wrote: >> Create a new attribute for virtio-blk devices that will fetch the serial >> number >> of the block device. This attribute can be used by udev to create disk/by-id >> symlinks for devices that don't have a UUID (filesyste

Re: [PATCH 2/2] Remove virtio_blk VBID ioctl

2010-06-20 Thread john cooper
Rusty Russell wrote: > On Sat, 19 Jun 2010 04:08:03 am Ryan Harper wrote: >> With the availablility of a sysfs device attribute for examining disk serial >> numbers the ioctl is no longer needed. The user-space changes for this >> aren't >> upstream yet so we don't have any users to worry about.

Re: [PATCH for-2.6.35] virtio_net: fix oom handling on tx

2010-06-20 Thread Rusty Russell
On Fri, 11 Jun 2010 04:33:43 am Michael S. Tsirkin wrote: > > > > @@ -572,12 +571,14 @@ again: > > > > > > > > /* This can happen with OOM and indirect buffers. */ > > > > if (unlikely(capacity < 0)) { > > > > - netif_stop_queue(dev); > > > > - dev_warn(

Re: [PATCH 2/2] Remove virtio_blk VBID ioctl

2010-06-20 Thread Ryan Harper
* Rusty Russell [2010-06-20 20:31]: > On Sat, 19 Jun 2010 04:08:03 am Ryan Harper wrote: > > With the availablility of a sysfs device attribute for examining disk serial > > numbers the ioctl is no longer needed. The user-space changes for this > > aren't > > upstream yet so we don't have any us

Re: [PATCH 1/2] Add 'serial' attribute to virtio-blk devices

2010-06-20 Thread Rusty Russell
On Sat, 19 Jun 2010 04:08:02 am Ryan Harper wrote: > Create a new attribute for virtio-blk devices that will fetch the serial > number > of the block device. This attribute can be used by udev to create disk/by-id > symlinks for devices that don't have a UUID (filesystem) associated with them. >

Re: [PATCH 2/2] Remove virtio_blk VBID ioctl

2010-06-20 Thread Rusty Russell
On Sat, 19 Jun 2010 04:08:03 am Ryan Harper wrote: > With the availablility of a sysfs device attribute for examining disk serial > numbers the ioctl is no longer needed. The user-space changes for this aren't > upstream yet so we don't have any users to worry about. If John Cooper acks this, I'l