Re: [RFC] virtio: Support releasing lock during kick

2010-06-24 Thread Stefan Hajnoczi
On Fri, Jun 25, 2010 at 4:09 AM, Rusty Russell wrote: > On Thu, 24 Jun 2010 03:00:30 pm Stefan Hajnoczi wrote: >> On Wed, Jun 23, 2010 at 11:12 PM, Anthony Liguori >> wrote: >> > Shouldn't it be possible to just drop the lock before invoking >> > virtqueue_kick() and reacquire it afterwards?  Th

Re: [RFC] virtio: Support releasing lock during kick

2010-06-24 Thread Rusty Russell
On Thu, 24 Jun 2010 03:00:30 pm Stefan Hajnoczi wrote: > On Wed, Jun 23, 2010 at 11:12 PM, Anthony Liguori > wrote: > > Shouldn't it be possible to just drop the lock before invoking > > virtqueue_kick() and reacquire it afterwards? There's nothing in that > > virtqueue_kick() path that the lock

Re: [PATCH 0/2] v2: Add 'serial' attribute to virtio-blk devices

2010-06-24 Thread Rusty Russell
On Thu, 24 Jun 2010 12:49:56 pm Ryan Harper wrote: > Using Rusty's suggestion I've respun the patch removing the special copy > function. I've tested this patch in a guest kernel with and without qemu > supplying serial numbers for the block devices and it's working as expected. > When qemu suppli