On Wed, Jul 14, 2010 at 01:42:59PM -0700, Shreyas Bhatewara wrote:
> +/* vmkernel and device backend shared definitions */
> +
> +#define VMXNET3_PLUGIN_NAME_LEN 256
> +#define VMXNET3_PLUGIN_REPOSITORY "/usr/lib/vmware/npa_plugins"
Why would the kernel care about this file path? And since when
On Wed, Jul 14, 2010 at 10:18:22AM -0700, Pankaj Thakkar wrote:
> The plugin is guest agnostic and hence we did not want to rely on any
> kernel provided functions. The plugin uses only the interface provided
> by the shell.
Really? vmxnet3_plugin.c is no supposed to use any kernel-provided
funct
On 07/14/2010 10:54 AM, David Miller wrote:
> And doing what you're doing is foolish on so many levels. One more
> duplication of code, one more place for unnecessary bugs to live, one
> more place that might need optimizations and thus require duplication
> of even more work people have done over
From: Pankaj Thakkar
Date: Wed, 14 Jul 2010 10:18:22 -0700
> The plugin is guest agnostic and hence we did not want to rely on
> any kernel provided functions.
While I disagree entirely with this kind of approach, even that
doesn't justify what you're doing here.
memcpy() and memset() are on a
The plugin is guest agnostic and hence we did not want to rely on any kernel
provided functions. The plugin uses only the interface provided by the shell.
The assumption is that since the plugin is really simple and straight forward
(all the control/init complexity lies in the PF driver in the h
On Wed, 14 Jul 2010, Greg KH wrote:
> On Mon, Jul 12, 2010 at 08:06:28PM -0700, Shreyas Bhatewara wrote:
> > drivers/net/vmxnet3/vmxnet3_drv.c | 1845
> > +++--
>
> Your patch is line-wrapped and can not be applied :(
>
> Care to fix your email client?
>
> One
Hi,
I would like to remind everybody that the deadline for submitting a
proposal to Linux Plumbers 2010 is nearing, so this is the time to get
your proposals in. The deadline is July 19th!
There has been some confusion about the submission process and I have
only just found out myself what is the
On Mon, Jul 12, 2010 at 08:06:28PM -0700, Shreyas Bhatewara wrote:
> drivers/net/vmxnet3/vmxnet3_drv.c | 1845
> +++--
Your patch is line-wrapped and can not be applied :(
Care to fix your email client?
One thing just jumped out at me when glancing at this:
> +st
