Re: [PATCH 14/18] virtio: add api for delayed callbacks

On Wed, 4 May 2011 23:52:33 +0300, Michael S. Tsirkin m...@redhat.com wrote: Add an API that tells the other side that callbacks should be delayed until a lot of work has been done. Implement using the new used_event feature. Since you're going to add a capacity query anyway, why not add the

Re: [PATCH 3/3] virtio_ring: need_event api comment fix

On Thu, 5 May 2011 18:08:17 +0300, Michael S. Tsirkin m...@redhat.com wrote: fix typo in a comment: size - side Reported-by: Stefan Hajnoczi stefa...@gmail.com Signed-off-by: Michael S. Tsirkin m...@redhat.com I could smerge these together for you, but I *really* want benchmarks in these

RE: various vmbus review comments

-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Sunday, May 08, 2011 11:05 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org Subject: Re: various vmbus review comments On Mon, May

Re: various vmbus review comments

On Fri, May 06, 2011 at 01:10:38PM +, KY Srinivasan wrote: I audited the block and the net drivers. As part of their exit routine, they invoke vmbus_child_driver_unregister() after properly cleaning up all the devices they are managing. Do you still see an issue with regards to module

RE: various vmbus review comments

-Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Monday, May 09, 2011 10:34 AM To: KY Srinivasan Cc: Greg KH; gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org Subject: Re: various vmbus review

[PATCH 000/206] Staging: hv: Cleanup hv drivers

This patch-set deals with some of the architectural isues in all of the Hyper-V drivers. Specifically: 1) Fixes a number of locking issues in the block driver. 2) Eliminates all the indirection through the hv_driver abstraction. 3) Simplifies the code across

[PATCH 020/206] Staging: hv: Rename the function stor_vsc_get_major_info()

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |2 +-

[PATCH 005/206] Staging: hv: Rename the device type variable

Rename the variable g_blk_device_type. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |4 ++-- 1

[PATCH 014/206] Staging: hv: Rename the function stor_vsc_on_cleanup

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |5 ++---

[PATCH 016/206] Staging: hv: Rename the function stor_vsc_on_io_request

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |2 +-

[PATCH 004/206] Staging: hv: Rename driver name variable

Rename the variable g_blk_driver_name. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |4 ++-- 1

[PATCH 057/206] Staging: hv: Get rid of the forward declaration of storvsc_probe()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 040/206] Staging: hv: Move the function storvsc_merge_bvec() to earlier in the file

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c | 14 +++---

[PATCH 019/206] Staging: hv: Get rid of the calls to storvsc_cleanup

The storvsc_cleanup() is an empty function; get rid of it. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 003/206] Staging: hv: Fix some locking issues

Additional lock related cleanup. Properly serialize access to state even for command related operations. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen

[PATCH 055/206] Staging: hv: Move the function storvsc_commmand_completion() to earlier in the file

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c | 115

[PATCH 062/206] Staging: hv: Get rid of the indirection in invoking storvsc_dev_remove()

Get rid of the indirection in invoking storvsc_dev_remove() Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 018/206] Staging: hv: Statically initialize pointers for probe etc

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 10 +- 1

[PATCH 035/206] Staging: hv: Rename the struct hv_device * element of struct hv_host_device

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |8 1

[PATCH 013/206] Staging: hv: Get rid of the indirection for removing stor device

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c | 10 ++ 1

[PATCH 001/206] Staging: hv: Get rid of blkvsc_mutex

The blkvsc_mutex is unnecessary as the state it is protecting (blkdev-users) is already protected by the spin lock. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank

[PATCH 002/206] Staging: hv: Cleanup spin lock usage

This spin lock is potentially acquired from interrupt context. Ensure that the interrupts are blocked whenever the lock is held. The current code was not consistent with regards to blocking interrupts - the same lock would be acquired without blocking interrupts in some instance while the

[PATCH 015/206] Staging: hv: Get rid of the indirection for invoking cleanup function

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |4 +--- 1 files

[PATCH 011/206] Staging: hv: Rename the function stor_vsc_device_add

The subject says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/blkvsc_drv.c |2 +-

[PATCH 064/206] Staging: hv: Get rid of the indirection in invoking storvsc_do_io()

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |6 ++ 1 files

[PATCH 022/206] Staging: hv: Use the newly introduced I/O drain synch method

Use the newly introduced I/O drain synch method. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc.c |7

[PATCH 049/206] Staging: hv: Staging: hv: Rename the function stor_vsc_on_host_reset()

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |4 ++-- 1 files

[PATCH 030/206] Staging: hv: Get rid of/change some dated comments

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc.c | 12 +--- 1

[PATCH 025/206] Staging: hv: Rename stor_vsc_channel_init()

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc.c |4 ++-- 1 files

[PATCH 045/206] Staging: hv: Get rid of the forward declaration of copy_from_bounce_buffer()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 042/206] Staging: hv: Get rid of the forwrd declaration of destroy_bounce_buffer

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 046/206] Staging: hv: Get rid of the forward declaration for copy_to_bounce_buffer()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 044/206] Staging: hv: Get rid of the forward declaration for create_bounce_buffer()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 033/206] Staging: hv: Rename struct host_device_context

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c | 27

[PATCH 051/206] Staging: hv: Move the definition of storvsc_host_reset() to earlier in the file

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c | 99

[PATCH 021/206] Staging: hv: Introduce a function to wait to drain outgoing I/O

Rather than busy loop waiting to drain I/O, introduce a function that does not burn CPU cycles waiting. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen

[PATCH 043/206] Staging: hv: Get rid of the forward declaration for do_bounce_buffer()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 063/206] Staging: hv: Get rid of the indirection in invoking storvsc_dev_add()

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |7 +-- 1 files

[PATCH 066/206] Staging: hv: Simplify the code for getting the drive parameters

We are making up the drive parameters; simplify the code. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

Re: [PATCH 077/206] Staging: hv: Get rid of call to cleanup()

On Mon, May 09, 2011 at 02:55:59PM -0700, K. Y. Srinivasan wrote: cleanup() is an empty function; get rid of it. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank

[PATCH 036/206] Staging: hv: Rename variables pointing to struct hv_device

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c | 15 +++

[PATCH 023/206] Staging: hv: Cleanup blkvsc_remove()

The function storvsc_dev_remove() already deals with draining of the outstanding I/O. Cleanup blkvsc_remove() keeping this in mind. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com

[PATCH 059/206] Staging: hv: Move the declaration of the driver variable

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |8 +--- 1

[PATCH 024/206] Staging: hv: Cleanup blkvsc_shutdown()

Use the newly introduced function to wait for draining I/Os to cleanup blkvsc_shutdown(). Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com

[PATCH 053/206] Staging: hv: Move the definition of storvsc_ringbuffer_size to earlier in the file

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |2 +- 1 files

[PATCH 047/206] Staging: hv: Get rid of the forward declaration of storvsc_remove()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 052/206] Staging: hv: Get rid of the forward declaration for storvsc_host_reset_handler()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 039/206] Staging: hv: Get rid of the forward declaration for storvsc_device_alloc()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

RE: [PATCH 077/206] Staging: hv: Get rid of call to cleanup()

-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Monday, May 09, 2011 6:53 PM To: KY Srinivasan Cc: gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; Abhishek Kane (Mindtree Consulting PVT LTD);

Re: [PATCH 077/206] Staging: hv: Get rid of call to cleanup()

On Mon, May 09, 2011 at 11:53:35PM +, KY Srinivasan wrote: Note, I wouldn't recommend sending that many patches to lkml, it's not needed, just stick to the de...@linuxdriverproject.org list as I really doubt anyone else cares about this code at the moment. Agreed; I will do that.

[PATCH 029/206] Staging: hv: Rename stor_vsc_connect_to_vsp

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc.c |4 ++-- 1 files

[PATCH 050/206] Staging: hv: Rename stor_vsc_initialize()

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |6 +++--- 1 files

[PATCH 048/206] Staging: hv: Get rid of the forward declaration of storvsc_get_chs()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 110/206] Staging: hv: Rename the variable messageHandler

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/channel_mgmt.c |6 +++--- 1 files

[PATCH 071/206] Staging: hv: Make rndis_filter_device_remove() non static

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/netvsc_api.h |1 +

[PATCH 034/206] Staging: hv: Rename variables pointing to struct hv_host_device

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c | 50

[PATCH 056/206] Staging: hv: Get rid of the forward declaration of storvsc_queuecommand()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 031/206] Staging: hv: Get rid of some unnecessary DPRINTS

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc.c | 116

[PATCH 082/206] Staging: hv: Get rid of the mouse cleanup() function

mousevsc_on_cleanup() is an empty function; get rid of it. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 037/206] Staging: hv: Get rid of some dated comments

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |3 --- 1 files

[PATCH 054/206] Staging: hv: Move module parameters to earlier in the file

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |6 +++--- 1 files

[PATCH 069/206] Staging: hv: Get rid of netvsc_cleanup()

netvsc_cleanup() is an empty function; get rid of it. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/netvsc.c |

[PATCH 119/206] Staging: hv: Get rid of some dead code in connection.c

Get rid some commented code and dated comments.T Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/connection.c |

[PATCH 116/206] Staging: hv: Use the completion abstraction in struct rndis_request

Use the completion abstraction in struct rndis_request to synchronize. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 028/206] Staging: hv: Rename stor_vsc_on_channel_callback

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc.c |4 ++-- 1 files

[PATCH 038/206] Staging: hv: Get rid of some DPRINTS

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c | 65

[PATCH 109/206] Staging: hv: Rename the variable gSupportedDeviceClasses

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/channel_mgmt.c |5 +++-- 1 files

[PATCH 112/206] Staging: hv: Rename the variable gChannelMessageTable

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/channel_mgmt.c |6 +++--- 1 files

[PATCH 114/206] Staging: hv: Get rid of some unnecessary state from struct vmbus_msginfo

This state is not used anywhere; get rid of it. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/vmbus_private.h |

[PATCH 058/206] Staging: hv: Rename the driver variable

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c | 10 +- 1

[PATCH 115/206] Staging: hv: Use completion abstraction in struct netvsc_device

Use completion abstraction in struct netvsc_device instead of struct wait_queue_head_t to synchronize. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen

[PATCH 108/206] Staging: hv: Cleanup ring_buffer.h

Access to these variables is already serialized via a spin lock. Get rid of the unnecessary volatile qualifier. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen

[PATCH 120/206] Staging: hv: Get rid of some dead code from hv.c

Get rid of some commented code. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/hv.c | 31

[PATCH 075/206] Staging: hv: Get rid of the indirection in invoking rndis_filter_device_remove()

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/netvsc_drv.c | 11 ++- 1

[PATCH 118/206] Staging: hv: Change Cleanup to cleanup

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/connection.c | 20

[PATCH 041/206] Staging: hv: Get rid of the forward declaration for storvsc_device_configure()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 095/206] Staging: hv: Rename the function ringbuffer_init

Rename the function ringbuffer_init to not pollute the namespace. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 032/206] Staging: hv: Rename g_driver_name

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/storvsc_drv.c |4 ++-- 1 files

[PATCH 103/206] Staging: hv: Rename all static functions in ring_buffer.c

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/ring_buffer.c | 88

[PATCH 084/206] Staging: hv: Get rid of dev_add from struct hv_driver

Now that we have gotten rid of the indirection, get rid of the unnecessary state struct hv_driver. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen

[PATCH 090/206] Staging: hv: Move the declaration of the variable netvsc_drv

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/netvsc_drv.c |6 +++--- 1 files

[PATCH 111/206] Staging: hv: Rename the variable messageType

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/channel_mgmt.c |2 +- 1 files

[PATCH 101/206] Staging: hv: Rename dump_ring_info

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/channel.c |4 ++--

[PATCH 121/206] Staging: hv: Change Cleanup to cleanup

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/hv.c | 18 +- 1

[PATCH 068/206] Staging: hv: Make netvsc_device_remove non static

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/netvsc.c |2 +-

[PATCH 094/206] Staging: hv: Statically initialize probe/remove

Statically initialize probe/remove. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/hv_mouse.c |8 1

[PATCH 072/206] Staging: hv: Get rid of rndis_filter_cleanup()

rndis_filter_cleanup() is an empty function; get rid of it. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 081/206] Staging: hv: Get rid of the indirection to invoke mousevsc_on_device_remove

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/hv_mouse.c |8 +--- 1 files

[PATCH 074/206] Staging: hv: Get rid of the indirection to invoke netvsc_device_add()

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/rndis_filter.c |2 +- 1 files

[PATCH 097/206] Staging: hv: Rename ringbuffer_write

Rename ringbuffer_write. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/channel.c |6 +++---

[PATCH 100/206] Staging: hv: Rename get_ringbuffer_interrupt_mask

The subject line says it all. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com --- drivers/staging/hv/channel.c |6 +++---

[PATCH 106/206] Staging: hv: Get rid of the forward declaration of hv_copyto_ringbuffer()

Get rid of the forward declaration by moving the code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

[PATCH 105/206] Staging: hv: Get rid of the forward declaration of hv_copyfrom_ringbuffer

Get rid of the forward declaration by moving code around. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com Signed-off-by: Abhishek Kane v-abk...@microsoft.com Signed-off-by: Hank Janssen hjans...@microsoft.com ---

Re: various vmbus review comments

On Mon, May 09, 2011 at 02:56:52PM +, KY Srinivasan wrote: I will address this. Greg had a concern about module reference counting and looking at the current code, it did not appear to be an issue. The change you are suggesting will not affect the vmbus core which is what I want to focus