Re: [PATCHv2 11/14] virtio: don't delay avail index update

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:12:19 +0300, "Michael S. Tsirkin" wrote: > Update avail index immediately instead of upon kick: > for virtio-net RX this helps parallelism with the host. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/virtio/virtio_ring.c | 28 +++- > 1 f

Re: [PATCHv2 10/14] virtio_net: limit xmit polling

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:11:56 +0300, "Michael S. Tsirkin" wrote: > Current code might introduce a lot of latency variation > if there are many pending bufs at the time we > attempt to transmit a new one. This is bad for > real-time applications and can't be good for TCP either. Do we have more th

Re: [PATCHv2 05/14] virtio_test: support event index

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:11:05 +0300, "Michael S. Tsirkin" wrote: > Add ability to test the new event idx feature, > enable by default. Applied. Thanks, Rusty. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux

Re: [PATCHv2 01/14] virtio: event index interface

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:10:17 +0300, "Michael S. Tsirkin" wrote: > Define a new feature bit for the guest and host to utilize > an event index (like Xen) instead if a flag bit to enable/disable > interrupts and kicks. Applied. Thanks, Rusty. ___ Virtua

Re: [PATCHv2 02/14] virtio ring: inline function to check for events

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:10:27 +0300, "Michael S. Tsirkin" wrote: > With the new used_event and avail_event and features, both > host and guest need similar logic to check whether events are > enabled, so it helps to put the common code in the header. > > Note that Xen has similar logic for notifi

Re: [PATCHv2 04/14] vhost: support event index

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:10:54 +0300, "Michael S. Tsirkin" wrote: > Support the new event index feature. When acked, > utilize it to reduce the # of interrupts sent to the guest. > > Signed-off-by: Michael S. Tsirkin Applied, even though it'd normally be in your tree, it's easier for me to push

Re: [PATCHv2 09/14] virtio_net: fix TX capacity checks using new API

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:11:47 +0300, "Michael S. Tsirkin" wrote: > virtio net uses the number of sg entries to > check for TX ring capacity freed. But this > gives incorrect results when indirect buffers > are used. Use the new capacity API instead. OK, but this explanation needs enhancement, suc

Re: [PATCHv2 03/14] virtio_ring: support event idx feature

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:10:44 +0300, "Michael S. Tsirkin" wrote: > Support for the new event idx feature: > 1. When enabling interrupts, publish the current avail index >value to the host to get interrupts on the next update. > 2. Use the new avail_event feature to reduce the number >of ex

Re: [PATCHv2 06/14] virtio: add api for delayed callbacks

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:11:14 +0300, "Michael S. Tsirkin" wrote: > Add an API that tells the other side that callbacks > should be delayed until a lot of work has been done. > Implement using the new event_idx feature. > > Note: it might seem advantageous to let the drivers > ask for a callback a

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-20 Thread Arnd Bergmann
On Friday 20 May 2011 17:13:25 Arnd Bergmann wrote: > On Friday 20 May 2011 17:00:47 Chris Metcalf wrote: > > > Any chance you can still restructure the information? I would recommend > > > making it a first-class procfs member, since the data is really per-task. > > > > > > You can add a condition

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-20 Thread Arnd Bergmann
On Friday 20 May 2011 17:00:47 Chris Metcalf wrote: > > Any chance you can still restructure the information? I would recommend > > making it a first-class procfs member, since the data is really per-task. > > > > You can add a conditional entry to tgid_base_stuff[] in fs/proc/base.c > > to make it

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-20 Thread Chris Metcalf
On 5/20/2011 10:37 AM, Arnd Bergmann wrote: > On Friday 20 May 2011 16:26:57 Chris Metcalf wrote: >> /proc/tile/hardwall >> Information on the set of currently active hardwalls (note that >> the implementation is already present in arch/tile/kernel/hardwall.c; >> this change j

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-20 Thread Arnd Bergmann
On Friday 20 May 2011 16:26:57 Chris Metcalf wrote: > /proc/tile/hardwall > Information on the set of currently active hardwalls (note that > the implementation is already present in arch/tile/kernel/hardwall.c; > this change just enables it) > >> This one is not a hypervi

Re: [PATCH] arch/tile: add /proc/tile, /proc/sys/tile, and a sysfs cpu attribute

2011-05-20 Thread Chris Metcalf
On 5/19/2011 11:22 AM, Arnd Bergmann wrote: > On Thursday 19 May 2011, Chris Metcalf wrote: /proc/tile/board Information on part numbers, serial numbers, etc., of the hardware that the kernel is executing on /proc/tile/switch The type of control path for the onbo

RE: vmbus driver

2011-05-20 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Friday, May 20, 2011 9:22 AM > To: KY Srinivasan > Cc: Christoph Hellwig; gre...@suse.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org > Subject: Re: vmbus dri

RE: vmbus driver

2011-05-20 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Friday, May 20, 2011 8:27 AM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org > Subject: Re: vmbus driver > > On Thu, Ma

Re: vmbus driver

2011-05-20 Thread Christoph Hellwig
On Fri, May 20, 2011 at 01:12:32PM +, KY Srinivasan wrote: > Well, the util driver that implements a range of other services such as KVP, > time synch, heartbeat etc. is also a client of the vmbus driver (perhaps not > in the The KVP driver is a different module as far as I can see. But it

RE: vmbus driver

2011-05-20 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Friday, May 20, 2011 9:05 AM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org > Subject: Re: vmbus driver > > On Thu, May 19, 2011 at

RE: vmbus driver

2011-05-20 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Friday, May 20, 2011 8:27 AM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org > Subject: Re: vmbus driver > > On Thu, Ma

Re: vmbus driver

2011-05-20 Thread Greg KH
On Thu, May 19, 2011 at 03:06:25PM -0700, K. Y. Srinivasan wrote: > > Greg, > > A few days ago you applied all the outstanding patches for the Hyper-V > drivers. With these patches, I have addressed all of the known review > comments for the vmbus driver (and a lot of comments/issues in other

Re: vmbus driver

2011-05-20 Thread Christoph Hellwig
On Thu, May 19, 2011 at 03:06:25PM -0700, K. Y. Srinivasan wrote: > A few days ago you applied all the outstanding patches for the Hyper-V > drivers. With these patches, I have addressed all of the known review > comments for the vmbus driver (and a lot of comments/issues in other > drivers as we

Re: [PATCHv2 00/14] virtio and vhost-net performance enhancements

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:10:07 +0300, "Michael S. Tsirkin" wrote: > OK, here is the large patchset that implements the virtio spec update > that I sent earlier (the spec itself needs a minor update, will send > that out too next week, but I think we are on the same page here > already). It superced

Re: [PATCH 14/18] virtio: add api for delayed callbacks

2011-05-20 Thread Rusty Russell
On Thu, 19 May 2011 10:24:12 +0300, "Michael S. Tsirkin" wrote: > On Mon, May 16, 2011 at 04:43:21PM +0930, Rusty Russell wrote: > > On Sun, 15 May 2011 15:48:18 +0300, "Michael S. Tsirkin" > > wrote: > > > On Mon, May 09, 2011 at 03:27:33PM +0930, Rusty Russell wrote: > > > > On Wed, 4 May 201