Re: virtio scsi host draft specification, v3

2011-06-09 Thread Paolo Bonzini
On 06/09/2011 01:28 AM, Rusty Russell wrote: >> > after some preliminary discussion on the QEMU mailing list, I present a >> > draft specification for a virtio-based SCSI host (controller, HBA, you >> > name it). > > OK, I'm impressed. This is very well written and it doesn't make any of > the

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Arnd Bergmann
On Thursday 09 June 2011 01:10:09 Randy Dunlap wrote: > On Wed, 8 Jun 2011 17:45:54 -0500 Timur Tabi wrote: > > > Add the drivers/virt directory, which houses drivers that support > > virtualization environments, and add the Freescale hypervisor management > > driver. > > It can't go in linux/vir

Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index

2011-06-09 Thread Tejun Heo
Hello, On Thu, Jun 09, 2011 at 08:51:05AM +0930, Rusty Russell wrote: > On Wed, 08 Jun 2011 09:08:29 -0400, Mark Wu wrote: > > Hi Rusty, > > Yes, I can't figure out an instance of disk probing in parallel either, but > > as > > per the following commit, I think we still need use lock for safety.

Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index

2011-06-09 Thread Mark Wu
On 06/09/2011 05:14 AM, Tejun Heo wrote: > Hello, > > On Thu, Jun 09, 2011 at 08:51:05AM +0930, Rusty Russell wrote: >> On Wed, 08 Jun 2011 09:08:29 -0400, Mark Wu wrote: >>> Hi Rusty, >>> Yes, I can't figure out an instance of disk probing in parallel either, but >>> as >>> per the following co

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Randy Dunlap
On 06/09/11 00:38, Arnd Bergmann wrote: > On Thursday 09 June 2011 01:10:09 Randy Dunlap wrote: >> On Wed, 8 Jun 2011 17:45:54 -0500 Timur Tabi wrote: >> >>> Add the drivers/virt directory, which houses drivers that support >>> virtualization environments, and add the Freescale hypervisor managemen

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Randy Dunlap
On 06/09/11 09:36, Timur Tabi wrote: > Randy Dunlap wrote: >> But it sounds like virt/ needs virt/host/ and virt/guest/ to me. > > I'm okay with that idea, except there's a consensus that drivers should be in > drivers/. > Like sound/ ? but what makes it a "driver"? -- ~Randy *** Remember to

Re: [PATCH 1/3] Staging: hv: netvsc: Fix a bug in accounting transmit slots

2011-06-09 Thread Greg KH
On Mon, Jun 06, 2011 at 03:57:35PM -0700, K. Y. Srinivasan wrote: I only got 2 of these three patches, what happened to the third one? Care to resend all 3 of these to ensure that I get them all? thanks, greg k-h ___ Virtualization mailing list Virtua

RE: [PATCH 1/3] Staging: hv: netvsc: Fix a bug in accounting transmit slots

2011-06-09 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Thursday, June 09, 2011 1:05 PM > To: KY Srinivasan > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; > Abhishek Kane (Mindtree Consulting PVT

Re: [PATCH 1/3] Staging: hv: netvsc: Fix a bug in accounting transmit slots

2011-06-09 Thread Greg KH
On Thu, Jun 09, 2011 at 05:23:50PM +, KY Srinivasan wrote: > > -Original Message- > > From: Greg KH [mailto:g...@kroah.com] > > Sent: Thursday, June 09, 2011 1:05 PM > > To: KY Srinivasan > > Cc: gre...@suse.de; linux-ker...@vger.kernel.org; > > de...@linuxdriverproject.org; virtualizat

[PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Timur Tabi
Add the drivers/virt directory, which houses drivers that support virtualization environments, and add the Freescale hypervisor management driver. The Freescale hypervisor management driver provides several services to drivers and applications related to the Freescale hypervisor: 1. An ioctl inte

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Randy Dunlap
On Thu, 9 Jun 2011 14:13:14 -0500 Timur Tabi wrote: > Add the drivers/virt directory, which houses drivers that support > virtualization environments, and add the Freescale hypervisor management > driver. > > The Freescale hypervisor management driver provides several services to > drivers and ap

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Timur Tabi
Randy Dunlap wrote: >> > +enum fsl_hv_ioctl_cmd { >> > + FSL_HV_IOCTL_PARTITION_RESTART = _IOWR(0, 1, struct >> > fsl_hv_ioctl_restart), >> > + FSL_HV_IOCTL_PARTITION_GET_STATUS = _IOWR(0, 2, struct >> > fsl_hv_ioctl_status), >> > + FSL_HV_IOCTL_PARTITION_START = _IOWR(0, 3, struct fsl_hv_ioct

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Randy Dunlap
On 06/09/11 12:47, Timur Tabi wrote: > Randy Dunlap wrote: +enum fsl_hv_ioctl_cmd { + FSL_HV_IOCTL_PARTITION_RESTART = _IOWR(0, 1, struct fsl_hv_ioctl_restart), + FSL_HV_IOCTL_PARTITION_GET_STATUS = _IOWR(0, 2, struct fsl_hv_ioctl_status), + FSL_HV_IOCTL_PARTITION

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Arnd Bergmann
Hi Timur, thanks for addressing the issues I pointed out. Unfortunately, I have found a few more now: On Thursday 09 June 2011 21:13:14 Timur Tabi wrote: > + /* Make sure the application is called the right driver. */ > + if (_IOC_TYPE(cmd) != 0) { > + pr_debug("fsl-hv: i

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Timur Tabi
Arnd Bergmann wrote: > As mentioned, it would be easier and more readable to just do > > switch(cmd) { > case FSL_HV_IOCTL_PARTITION_RESTART: > ... > > case FSL_HV_IOCTL_PARTITION_GET_STATUS; > ... > > There is no need to check the bits individually

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Arnd Bergmann
On Thursday 09 June 2011 21:48:58 Randy Dunlap wrote: > > So is it okay to stick with 0, or do I need to pick a new number? > > I wasn't suggesting that you change the 0, just note that it has conflicts, > like other ioctls do. We normally don't try to maintain binary compatibility with out of tr

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Greg KH
On Thu, Jun 09, 2011 at 03:18:28PM -0500, Timur Tabi wrote: > > More importantly, the code you have chose (0) conflicts with existing > > drivers > > (frame buffer, scsi and wavefront among others). Please chose a free one and > > add it to Documentation/ioctl/ioctl-number.txt in the same patch. >

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Arnd Bergmann
On Thursday 09 June 2011 22:18:28 Timur Tabi wrote: > > More importantly, the code you have chose (0) conflicts with existing > > drivers > > (frame buffer, scsi and wavefront among others). Please chose a free one and > > add it to Documentation/ioctl/ioctl-number.txt in the same patch. > > Ok,

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Timur Tabi
Greg KH wrote: > Why is binary compatibility important? Isn't this a brand new driver > for a brand new system? What userspace tools are out there in the wild > for such a thing? This driver (and the hypervisor it talks to, plus the apps, etc) has been in internal development for three years. T

[PATCH 7/7] [v6] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Timur Tabi
Add the drivers/virt directory, which houses drivers that support virtualization environments, and add the Freescale hypervisor management driver. The Freescale hypervisor management driver provides several services to drivers and applications related to the Freescale hypervisor: 1. An ioctl inte

Re: [PATCH 7/7] [v6] drivers/virt: introduce Freescale hypervisor management driver

2011-06-09 Thread Arnd Bergmann
On Thursday 09 June 2011 22:52:06 Timur Tabi wrote: > Add the drivers/virt directory, which houses drivers that support > virtualization environments, and add the Freescale hypervisor management > driver. > > The Freescale hypervisor management driver provides several services to > drivers and app