[PATCH] virtio_net: introduce VIRTIO_NET_HDR_F_DATA_VALID

2011-06-10 Thread Jason Wang
There's no need for the guest to validate the checksum if it have been validated by host nics. So this patch introduces a new flag - VIRTIO_NET_HDR_F_DATA_VALID which is used to bypass the checksum examing in guest. The backend (tap/macvtap) may set this flag when met skbs with

Re: virtio scsi host draft specification, v3

2011-06-10 Thread Rusty Russell
On Thu, 09 Jun 2011 08:59:27 +0200, Paolo Bonzini pbonz...@redhat.com wrote: On 06/09/2011 01:28 AM, Rusty Russell wrote: after some preliminary discussion on the QEMU mailing list, I present a draft specification for a virtio-based SCSI host (controller, HBA, you name it). OK,

Re: virtio scsi host draft specification, v3

2011-06-10 Thread Stefan Hajnoczi
On Fri, Jun 10, 2011 at 12:33 PM, Rusty Russell ru...@rustcorp.com.au wrote: On Thu, 09 Jun 2011 08:59:27 +0200, Paolo Bonzini pbonz...@redhat.com wrote: On 06/09/2011 01:28 AM, Rusty Russell wrote:  after some preliminary discussion on the QEMU mailing list, I present a  draft

Re: virtio scsi host draft specification, v3

2011-06-10 Thread Paolo Bonzini
On 06/10/2011 02:14 PM, Stefan Hajnoczi wrote: Paolo, I'll switch the Linux guest LLD and QEMU virtio-scsi skeleton that I have to comply with the spec. Does this sound good or did you want to write these from scratch? Why should I want to write things from scratch? :) Just send me again a

Re: virtio scsi host draft specification, v3

2011-06-10 Thread Hannes Reinecke
On 06/07/2011 03:43 PM, Paolo Bonzini wrote: Hi all, after some preliminary discussion on the QEMU mailing list, I present a draft specification for a virtio-based SCSI host (controller, HBA, you name it). The virtio SCSI host is the basis of an alternative storage stack for KVM. This

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-10 Thread Chris Metcalf
On 6/9/2011 3:38 AM, Arnd Bergmann wrote: On Thursday 09 June 2011 01:10:09 Randy Dunlap wrote: On Wed, 8 Jun 2011 17:45:54 -0500 Timur Tabi wrote: Add the drivers/virt directory, which houses drivers that support virtualization environments, and add the Freescale hypervisor management

Re: virtio scsi host draft specification, v3

2011-06-10 Thread Paolo Bonzini
If requests are placed on arbitrary queues you'll inevitably run on locking issues to ensure strict request ordering. I would add here: If a device uses more than one queue it is the responsibility of the device to ensure strict request ordering. Applied with s/device/guest/g. Please do

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-10 Thread Arnd Bergmann
On Friday 10 June 2011, Chris Metcalf wrote: This still leaves open the question of what really should go in this new directory. Is it just for drivers that manage/control the hypervisor? Or is it also for drivers that just use the hypervisor to do I/O of some kind, but aren't related to any

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-10 Thread Timur Tabi
Randy Dunlap wrote: But it sounds like virt/ needs virt/host/ and virt/guest/ to me. I'm okay with that idea, except there's a consensus that drivers should be in drivers/. -- Timur Tabi Linux kernel developer at Freescale ___ Virtualization mailing

Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

2011-06-10 Thread Timur Tabi
Randy Dunlap wrote: I'm okay with that idea, except there's a consensus that drivers should be in drivers/. Like sound/ ? My understanding is that this is something that's considered broken and should be fixed, but I don't know what the holdup is. but what makes it a driver? That's

Re: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisor management driver

2011-06-10 Thread Mark Brown
On Thu, Jun 09, 2011 at 10:33:07PM +0200, Arnd Bergmann wrote: On Thursday 09 June 2011 22:18:28 Timur Tabi wrote: Ok, I was really hoping to avoid doing this. Like I said, binary compatibility is important, and changing the type will break my existing apps. Are you insisting that I

RE: [PATCH 7/7] [v5] drivers/virt: introduce Freescale hypervisormanagement driver

2011-06-10 Thread David Laight
+enum fsl_hv_ioctl_cmd { + FSL_HV_IOCTL_PARTITION_RESTART = _IOWR(0, 1, struct fsl_hv_ioctl_restart), ... +}; Using a #define here is usually preferred because then you can use #ifdef in a user application to check if a given value has been assigned. It is also possible to