[PATCH] Modpost section mismatch fix

2011-07-03 Thread Raghavendra D Prabhu
[Sorry if duplicate, one earlier was corrupt] Hi, I got section mismatches reported by modpost in latest build. It got reported for xen_register_pirq and xen_unplug_emulated_devices functions. xen_register_pirq makes reference to acpi_sci_override_gsi in init.data section; marking

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Sasha Levin
On Sun, 2011-07-03 at 16:44 +0300, Michael S. Tsirkin wrote: > On Sun, Jul 03, 2011 at 03:32:36PM +0300, Sasha Levin wrote: > > On Sun, 2011-07-03 at 15:11 +0300, Michael S. Tsirkin wrote: > > > On Sun, Jul 03, 2011 at 01:52:29PM +0300, Sasha Levin wrote: > > > > On Sun, 2011-07-03 at 13:30 +0300,

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Sasha Levin
On Sun, 2011-07-03 at 15:11 +0300, Michael S. Tsirkin wrote: > On Sun, Jul 03, 2011 at 01:52:29PM +0300, Sasha Levin wrote: > > On Sun, 2011-07-03 at 13:30 +0300, Michael S. Tsirkin wrote: > > > On Sun, Jul 03, 2011 at 12:46:59PM +0300, Sasha Levin wrote: > > > > On Sun, 2011-07-03 at 11:27 +0300,

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Sasha Levin
On Sun, 2011-07-03 at 13:30 +0300, Michael S. Tsirkin wrote: > On Sun, Jul 03, 2011 at 12:46:59PM +0300, Sasha Levin wrote: > > On Sun, 2011-07-03 at 11:27 +0300, Michael S. Tsirkin wrote: > > > Doesn't this basically just revert > > > bf50e69f63d21091e525185c3ae761412be0ba72? > > > > > > > Yes.

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Sasha Levin
On Sun, 2011-07-03 at 11:27 +0300, Michael S. Tsirkin wrote: > Doesn't this basically just revert > bf50e69f63d21091e525185c3ae761412be0ba72? > Yes. I haven't noticed that commit. Ignoring the VIRTIO_BALLOON_F_MUST_TELL_HOST feature flag causes an unnecessary delay due to having to kick and wait

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Michael S. Tsirkin
On Sun, Jul 03, 2011 at 06:12:41PM +0300, Sasha Levin wrote: > If we choose to > leave it this way we can just go ahead and remove MUST_TELL_HOST. It probably needs to stay so that the host can detect that the guest does guarantee telling it first. -- MST _

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Michael S. Tsirkin
On Sun, Jul 03, 2011 at 03:32:36PM +0300, Sasha Levin wrote: > On Sun, 2011-07-03 at 15:11 +0300, Michael S. Tsirkin wrote: > > On Sun, Jul 03, 2011 at 01:52:29PM +0300, Sasha Levin wrote: > > > On Sun, 2011-07-03 at 13:30 +0300, Michael S. Tsirkin wrote: > > > > On Sun, Jul 03, 2011 at 12:46:59PM

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Michael S. Tsirkin
On Sun, Jul 03, 2011 at 01:52:29PM +0300, Sasha Levin wrote: > On Sun, 2011-07-03 at 13:30 +0300, Michael S. Tsirkin wrote: > > On Sun, Jul 03, 2011 at 12:46:59PM +0300, Sasha Levin wrote: > > > On Sun, 2011-07-03 at 11:27 +0300, Michael S. Tsirkin wrote: > > > > Doesn't this basically just revert

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Michael S. Tsirkin
On Sun, Jul 03, 2011 at 12:46:59PM +0300, Sasha Levin wrote: > On Sun, 2011-07-03 at 11:27 +0300, Michael S. Tsirkin wrote: > > Doesn't this basically just revert > > bf50e69f63d21091e525185c3ae761412be0ba72? > > > > Yes. I haven't noticed that commit. > > Ignoring the VIRTIO_BALLOON_F_MUST_TELL

Re: [PATCH] virtio_balloon: Notify guest only after deflating the balloon

2011-07-03 Thread Michael S. Tsirkin
Doesn't this basically just revert bf50e69f63d21091e525185c3ae761412be0ba72? On Sat, Jul 02, 2011 at 06:06:56AM +0300, Sasha Levin wrote: > Unless the host requires that requested pages won't be used until > he us notified (VIRTIO_BALLOON_F_MUST_TELL_HOST), only notify after > deflating the ball