Re: [RFC PATCH net-next v2] enable virtio_net to return bus_info in ethtool -i consistent with emulated NICs

2011-11-16 Thread David Miller
From: r...@tardy.cup.hp.com (Rick Jones) Date: Mon, 14 Nov 2011 16:17:08 -0800 (PST) > From: Rick Jones > > Add a new .bus_name to virtio_config_ops then modify virtio_net to > call through to it in an ethtool .get_drvinfo routine to report > bus_info in ethtool -i output which is consistent wi

Re: [PATCH] virtio-mmio: Devices parameter parsing

2011-11-16 Thread Pawel Moll
On Wed, 2011-11-16 at 00:42 +, Rusty Russell wrote: > On Tue, 15 Nov 2011 13:53:05 +, Pawel Moll wrote: > > +static char *virtio_mmio_cmdline_devices; > > +module_param_named(devices, virtio_mmio_cmdline_devices, charp, 0); > > This is the wrong way to do this. > > Don't put things in a

Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-16 Thread Sasha Levin
On Wed, 2011-11-16 at 13:21 +, Pawel Moll wrote: > On Tue, 2011-11-15 at 17:56 +, Sasha Levin wrote: > > Hmm... If thats the plan, it should probably be a virtio thing (not > > virtio-mmio specific). > > > > Either way, it could also use some clarification in the spec. > > Well, the spec

Re: [RFC] kvm tools: Add support for virtio-mmio

2011-11-16 Thread Pawel Moll
On Tue, 2011-11-15 at 17:56 +, Sasha Levin wrote: > Hmm... If thats the plan, it should probably be a virtio thing (not > virtio-mmio specific). > > Either way, it could also use some clarification in the spec. Well, the spec (p. 2.1) says: "The Subsystem Vendor ID should reflect the PCI Vend

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-16 Thread jason wang
On 11/16/2011 05:09 PM, Krishna Kumar2 wrote: > jason wang wrote on 11/16/2011 11:40:45 AM: > > Hi Jason, > >> Have any thought in mind to solve the issue of flow handling? > So far nothing concrete. > >> Maybe some performance numbers first is better, it would let us know >> where we are. During

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-16 Thread Krishna Kumar2
jason wang wrote on 11/16/2011 11:40:45 AM: Hi Jason, > Have any thought in mind to solve the issue of flow handling? So far nothing concrete. > Maybe some performance numbers first is better, it would let us know > where we are. During the test of my patchset, I find big regression of > small

Re: [PATCHv2 RFC] virtio-spec: flexible configuration layout

2011-11-16 Thread Michael S. Tsirkin
On Wed, Nov 16, 2011 at 10:17:39AM +0200, Sasha Levin wrote: > On Wed, 2011-11-16 at 09:21 +0200, Michael S. Tsirkin wrote: > > On Wed, Nov 16, 2011 at 10:28:52AM +1030, Rusty Russell wrote: > > > On Fri, 11 Nov 2011 09:39:13 +0200, Sasha Levin > > > wrote: > > > > On Fri, Nov 11, 2011 at 6:24 AM

Re: [PATCHv2 RFC] virtio-spec: flexible configuration layout

2011-11-16 Thread Sasha Levin
On Wed, 2011-11-16 at 09:21 +0200, Michael S. Tsirkin wrote: > On Wed, Nov 16, 2011 at 10:28:52AM +1030, Rusty Russell wrote: > > On Fri, 11 Nov 2011 09:39:13 +0200, Sasha Levin > > wrote: > > > On Fri, Nov 11, 2011 at 6:24 AM, Rusty Russell > > > wrote: > > > > (2) There's no huge win in keepi