Re: [PATCH 5 of 5] virtio: expose added descriptors immediately

2011-11-21 Thread Michael S. Tsirkin
On Tue, Nov 22, 2011 at 11:03:04AM +1030, Rusty Russell wrote: > On Mon, 21 Nov 2011 13:57:04 +0200, "Michael S. Tsirkin" > wrote: > > On Mon, Nov 21, 2011 at 12:18:45PM +1030, Rusty Russell wrote: > > > On Wed, 16 Nov 2011 09:18:38 +0200, "Michael S. Tsirkin" > > > wrote: > > > > My unlocked k

Re: [PATCH] virtio-mmio: Devices parameter parsing

2011-11-21 Thread Rusty Russell
On Mon, 21 Nov 2011 17:56:50 +, Pawel Moll wrote: > On Mon, 2011-11-21 at 14:44 +, Pawel Moll wrote: > > I'll post v3 tonight or tomorrow. > > Ok, it won't be v3 then... > > I tried again, using your suggestions - see below (just the crucial bit, > however I have the kernel-parameters.tx

Re: [PATCH] virtio-mmio: Devices parameter parsing

2011-11-21 Thread Rusty Russell
On Mon, 21 Nov 2011 14:44:48 +, Pawel Moll wrote: > On Mon, 2011-11-21 at 03:32 +, Rusty Russell wrote: > > 2) Doesn't leak mem on error paths. > > Em, I don't think my code was leaking memory in any error case? (no > offence meant or taken ;-) You're right, I'm wrong. In your original

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

2011-11-21 Thread Rusty Russell
On Mon, 21 Nov 2011 14:16:38 -0800, Miche Baker-Harvey wrote: > Thanks, Rusty. I'm not using QEMU though, just KVM. I create the device, > wait > for the message from the guest that the device is ready, and then add ports. > > Miche OK, since Amit was the one who implemented multi-port conso

Re: [PATCH 5 of 5] virtio: expose added descriptors immediately

2011-11-21 Thread Rusty Russell
On Mon, 21 Nov 2011 13:57:04 +0200, "Michael S. Tsirkin" wrote: > On Mon, Nov 21, 2011 at 12:18:45PM +1030, Rusty Russell wrote: > > On Wed, 16 Nov 2011 09:18:38 +0200, "Michael S. Tsirkin" > > wrote: > > > My unlocked kick patches will trip this warning: they make > > > virtio-net do add + get

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

2011-11-21 Thread Miche Baker-Harvey
Thanks, Rusty. I'm not using QEMU though, just KVM. I create the device, wait for the message from the guest that the device is ready, and then add ports. Miche On Sun, Nov 20, 2011 at 9:01 PM, Rusty Russell wrote: > On Thu, 17 Nov 2011 10:57:37 -0800, Miche Baker-Harvey > wrote: >> Rusty,

Re: [RFC] [ver3 PATCH 3/6] virtio_net: virtio_net driver changes

2011-11-21 Thread Ben Hutchings
On Fri, 2011-11-18 at 18:18 +0200, Sasha Levin wrote: > On Fri, 2011-11-18 at 15:40 +, Ben Hutchings wrote: > > On Fri, 2011-11-18 at 08:24 +0200, Sasha Levin wrote: > > > On Fri, 2011-11-18 at 01:08 +, Ben Hutchings wrote: > > > > On Fri, 2011-11-11 at 18:34 +0530, Krishna Kumar wrote: > >

Re: [RFC] [ver3 PATCH 3/6] virtio_net: virtio_net driver changes

2011-11-21 Thread Ben Hutchings
On Fri, 2011-11-18 at 08:24 +0200, Sasha Levin wrote: > On Fri, 2011-11-18 at 01:08 +, Ben Hutchings wrote: > > On Fri, 2011-11-11 at 18:34 +0530, Krishna Kumar wrote: > > > Changes for multiqueue virtio_net driver. > > [...] > > > @@ -677,25 +730,35 @@ static struct rtnl_link_stats64 *virtnet

Re: [RFC] [ver3 PATCH 3/6] virtio_net: virtio_net driver changes

2011-11-21 Thread Ben Hutchings
On Fri, 2011-11-11 at 18:34 +0530, Krishna Kumar wrote: > Changes for multiqueue virtio_net driver. [...] > @@ -677,25 +730,35 @@ static struct rtnl_link_stats64 *virtnet > { > struct virtnet_info *vi = netdev_priv(dev); > int cpu; > - unsigned int start; > > for_each_possi

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

2011-11-21 Thread Miche Baker-Harvey
Rusty, Michael, Stephen, et al, Thanks for your comments on these patches. For what I'm trying to do, all three patches are necessary, but maybe I'm going about it the wrong way. Your input would be appreciated. I'm in no way claiming that these patches are "right", just that it's working for me,

Re: [PATCH] virtio-mmio: Devices parameter parsing

2011-11-21 Thread Pawel Moll
On Mon, 2011-11-21 at 14:44 +, Pawel Moll wrote: > I'll post v3 tonight or tomorrow. Ok, it won't be v3 then... I tried again, using your suggestions - see below (just the crucial bit, however I have the kernel-parameters.txt bits ready as well). Parsing works like charm, however when it gets

Re: [PATCH] virtio-mmio: Devices parameter parsing

2011-11-21 Thread Pawel Moll
On Mon, 2011-11-21 at 03:32 +, Rusty Russell wrote: > No it's not; I didn't bother when I converted things across, and it > shows. 546970bc (Rusty Russell 2010-08-11 23:04:20 -0600 133) #define module_param_cb Now I understand... :-) > But we expect virtio hackers to be smarter than aver

Re: [PATCH 5 of 5] virtio: expose added descriptors immediately

2011-11-21 Thread Michael S. Tsirkin
On Mon, Nov 21, 2011 at 12:18:45PM +1030, Rusty Russell wrote: > On Wed, 16 Nov 2011 09:18:38 +0200, "Michael S. Tsirkin" > wrote: > > My unlocked kick patches will trip this warning: they make > > virtio-net do add + get without kick. > > Heh, it's a good sign if they do, since that means you'r