Re: [PATCHv3 RFC] virtio-pci: flexible configuration layout

2011-11-28 Thread Michael S. Tsirkin
On Mon, Nov 28, 2011 at 11:25:43AM +1030, Rusty Russell wrote: But I'm *terrified* of making the spec more complex; All you do is move stuff around. Why do you think it simplifies the spec so much? No, but it reduces the yuk factor. Which has been important to adoption. Sorry if I'm

Re: [PATCHv3 RFC] virtio-pci: flexible configuration layout

2011-11-28 Thread Sasha Levin
On Mon, 2011-11-28 at 11:25 +1030, Rusty Russell wrote: I'd like to see kvmtools remove support for legacy mode altogether, but they probably have existing users. While we can't simply remove it right away, instead of mixing our implementation for both legacy and new spec in the same code we

Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first

2011-11-28 Thread Stephen Hemminger
On Mon, 28 Nov 2011 12:25:15 +0800 Jason Wang jasow...@redhat.com wrote: I'm using ixgbe for testing also, for host, its driver seems provide irq affinity hint, so no binding or irqbalance is needed. The hint is for irqbalance to use. You need to still do manual affinity or use irqbalance.

[PATCH 28/62] vhost: remove the second argument of k[un]map_atomic()

2011-11-28 Thread Cong Wang
Signed-off-by: Cong Wang amw...@redhat.com --- drivers/vhost/vhost.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index c14c42b..bdb2d64 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -937,9 +937,9 @@

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

2011-11-28 Thread Miche Baker-Harvey
Amit, You said that the work would be serialized due to port additions being on work items on the same workqueue. I'm not seeing that. I've double checked this by using a mutex_trylock in hvc_console::hvc_alloc(), and here's the relevant output from dmesg: root@myubuntu:~# dmesg | grep MBH