Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Andrew Morton
On Fri, 20 Jan 2012 18:55:08 -0500 Konrad Rzeszutek Wilk wrote: > On Fri, Jan 20, 2012 at 03:11:49PM -0800, Andrew Morton wrote: > > On Fri, 20 Jan 2012 11:09:38 -0500 > > Konrad Rzeszutek Wilk wrote: > > > > > > > > > > > Did you test this patch with a large amount of minors? > > > > > > > >

[PATCH] include/checkpatch: Prefer __scanf to __attribute__((format(scanf, ...)

2012-01-20 Thread Joe Perches
It's equivalent to __printf, so prefer __scanf. Signed-off-by: Joe Perches --- include/linux/compiler-gcc.h |3 ++- include/linux/kernel.h |8 include/xen/xenbus.h |4 ++-- scripts/checkpatch.pl|6 ++ 4 files changed, 14 insertions(+), 7 deletio

Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Konrad Rzeszutek Wilk
On Fri, Jan 20, 2012 at 03:11:49PM -0800, Andrew Morton wrote: > On Fri, 20 Jan 2012 11:09:38 -0500 > Konrad Rzeszutek Wilk wrote: > > > > > > > > Did you test this patch with a large amount of minors? > > > > > > Sorry I didn't do runtime test. > > > > Please do. > > The poor guy probably do

Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Andrew Morton
On Fri, 20 Jan 2012 11:09:38 -0500 Konrad Rzeszutek Wilk wrote: > > > > > Did you test this patch with a large amount of minors? > > > > Sorry I didn't do runtime test. > > Please do. The poor guy probably doesn't know how to test it and surely it would be quite a lot of work for him to do so

Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Konrad Rzeszutek Wilk
On Sat, Jan 21, 2012 at 12:41:56AM +0900, Akinobu Mita wrote: > 2012/1/21 Konrad Rzeszutek Wilk : > > On Sat, Jan 21, 2012 at 12:15:26AM +0900, Akinobu Mita wrote: > >> Use bitmap_set and bitmap_clear rather than modifying individual bits > >> in a memory region. > >> > >> Signed-off-by: Akinobu Mi

Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Akinobu Mita
2012/1/21 Konrad Rzeszutek Wilk : > On Sat, Jan 21, 2012 at 12:15:26AM +0900, Akinobu Mita wrote: >> Use bitmap_set and bitmap_clear rather than modifying individual bits >> in a memory region. >> >> Signed-off-by: Akinobu Mita >> Cc: Jeremy Fitzhardinge >> Cc: Konrad Rzeszutek Wilk >> Cc: xen-d

Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Konrad Rzeszutek Wilk
On Sat, Jan 21, 2012 at 12:15:26AM +0900, Akinobu Mita wrote: > Use bitmap_set and bitmap_clear rather than modifying individual bits > in a memory region. > > Signed-off-by: Akinobu Mita > Cc: Jeremy Fitzhardinge > Cc: Konrad Rzeszutek Wilk > Cc: xen-de...@lists.xensource.com > Cc: virtualizat

Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Akinobu Mita
I used Jeremy Fitzhardinge's old email address... 2012/1/21 Akinobu Mita : > Use bitmap_set and bitmap_clear rather than modifying individual bits > in a memory region. > > Signed-off-by: Akinobu Mita > Cc: Jeremy Fitzhardinge Cc: Jeremy Fitzhardinge > Cc: Konrad Rzeszutek Wilk > Cc: xen-de.

[PATCH] xen-blkfront: use bitmap_set() and bitmap_clear()

2012-01-20 Thread Akinobu Mita
Use bitmap_set and bitmap_clear rather than modifying individual bits in a memory region. Signed-off-by: Akinobu Mita Cc: Jeremy Fitzhardinge Cc: Konrad Rzeszutek Wilk Cc: xen-de...@lists.xensource.com Cc: virtualization@lists.linux-foundation.org --- drivers/block/xen-blkfront.c |7 +++---

Re: [PATCH RFC V4 5/5] Documentation/kvm : Add documentation on Hypercalls and features used for PV spinlock

2012-01-20 Thread Srivatsa Vaddagiri
* Marcelo Tosatti [2012-01-17 13:53:03]: > on tue, jan 17, 2012 at 05:32:33pm +0200, gleb natapov wrote: > > on tue, jan 17, 2012 at 07:58:18pm +0530, srivatsa vaddagiri wrote: > > > * gleb natapov [2012-01-17 15:20:51]: > > > > > > > > having the hypercall makes the intent of vcpu (to sleep on

[PATCH 2/2] virtio: correct the memory barrier in virtqueue_kick_prepare()

2012-01-20 Thread Jason Wang
Use virtio_mb() to make sure the available index to be exposed before checking the the avail event. Otherwise we may get stale value of avail event in guest and never kick the host after. Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c |6 +++--- 1 files changed, 3 insertions(+),

[PATCH 1/2] virtio: fix typos of memory barriers

2012-01-20 Thread Jason Wang
Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 79e1b29..78428a8 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -