Re: [Xen-devel] [PATCH 0001/001] xen: multi page ring support for block devices

2012-03-15 Thread Jan Beulich
>>> On 14.03.12 at 18:01, Justin Gibbs wrote: > While we're talking about fixing ring data structures, can RING_IDX > be defined as a "uint32_t" instead of "unsigned int". The structure > padding in the ring macros assumes RING_IDX is exactly 4 bytes, > so this should be made explicit. ILP64 mac

Re: [Xen-devel] [PATCH 0001/001] xen: multi page ring support for block devices

2012-03-15 Thread Jan Beulich
>>> On 14.03.12 at 18:17, "Justin T. Gibbs" wrote: > On Mar 6, 2012, at 1:34 AM, Jan Beulich wrote: > > On 05.03.12 at 22:49, Santosh Jodh wrote: > > … > >>> + } >>> + >>>/* Create shared ring, alloc event channel. */ >>>err = setup_blkring(dev, info); >>>if (

Re: [Xen-devel] [PATCH 0001/001] xen: multi page ring support for block devices

2012-03-15 Thread Ian Campbell
On Thu, 2012-03-15 at 08:03 +, Jan Beulich wrote: > >>> On 14.03.12 at 18:01, Justin Gibbs wrote: > > While we're talking about fixing ring data structures, can RING_IDX > > be defined as a "uint32_t" instead of "unsigned int". The structure > > padding in the ring macros assumes RING_IDX is

Re: [Xen-devel] [PATCH 0001/001] xen: multi page ring support for block devices

2012-03-15 Thread Jan Beulich
>>> On 15.03.12 at 09:51, Ian Campbell wrote: > On Thu, 2012-03-15 at 08:03 +, Jan Beulich wrote: >> >>> On 14.03.12 at 18:01, Justin Gibbs wrote: >> > While we're talking about fixing ring data structures, can RING_IDX >> > be defined as a "uint32_t" instead of "unsigned int". The structure

Re: [Xen-devel] [PATCH 2/4 v2] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps

2012-03-15 Thread Konrad Rzeszutek Wilk
On Wed, Jan 11, 2012 at 11:29:20AM -0500, Andrew Jones wrote: > > > - Original Message - > > On Mon, Jan 09, 2012 at 06:51:41PM +0100, Andrew Jones wrote: > > > PV-on-HVM guests may want to use the xen keyboard/mouse frontend, > > > but > > > they don't use the xen frame buffer frontend.

Re: [Xen-devel] [PATCH 2/4 v2] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps

2012-03-15 Thread Dmitry Torokhov
On Thu, Mar 15, 2012 at 01:23:05PM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Jan 11, 2012 at 11:29:20AM -0500, Andrew Jones wrote: > > > > > > - Original Message - > > > On Mon, Jan 09, 2012 at 06:51:41PM +0100, Andrew Jones wrote: > > > > PV-on-HVM guests may want to use the xen keyb