Re: Re: [PATCH 3/5] trace-cmd: Support trace-agent of virtio-trace

2012-08-22 Thread Yoshihiro YUNOMAE
Hi Steven, (2012/08/22 22:51), Steven Rostedt wrote: On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote: Add read path and control path to use trace-agent of virtio-trace. When we use trace-agent, trace-cmd will be used as follows: # AGENT_READ_DIR=/tmp/virtio-trace/tracing \

Re: [PATCH 2/5] trace-cmd: Use tracing directory to count CPUs

2012-08-22 Thread Masami Hiramatsu
(2012/08/23 11:01), Masami Hiramatsu wrote: > (2012/08/22 22:41), Steven Rostedt wrote: >> On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote: >>> From: Masami Hiramatsu >>> >>> Count debugfs/tracing/per_cpu/cpu* to determine the >>> number of CPUs. >> >> I'm curious, do you find that sysc

Re: [PATCH v8 1/5] mm: introduce a common interface for balloon pages mobility

2012-08-22 Thread Rafael Aquini
On Wed, Aug 22, 2012 at 12:33:17PM +0300, Michael S. Tsirkin wrote: > Hmm, so this will busy wait which is unelegant. > We need some event IMO. No, it does not busy wait. leak_balloon() is mutual exclusive with migration steps, so for the case we have one racing against the other, we really want l

Re: [PATCH 2/5] trace-cmd: Use tracing directory to count CPUs

2012-08-22 Thread Masami Hiramatsu
(2012/08/22 22:41), Steven Rostedt wrote: > On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote: >> From: Masami Hiramatsu >> >> Count debugfs/tracing/per_cpu/cpu* to determine the >> number of CPUs. > > I'm curious, do you find that sysconf doesn't return the # of CPUs the > system has?

Re: [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-22 Thread Paolo Bonzini
Il 22/08/2012 15:13, Stefan Hajnoczi ha scritto: > http://lists.gnu.org/archive/html/qemu-devel/2010-12/msg01741.html > > "This is a real problem in practice. IE. the USB CD-ROM on this POWER7 > blade limits transfers to 0x1e000 bytes for example and the Linux "sr" > driver on the guest is going t

Re: [PATCH 3/5] trace-cmd: Support trace-agent of virtio-trace

2012-08-22 Thread Steven Rostedt
On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote: > Add read path and control path to use trace-agent of virtio-trace. > When we use trace-agent, trace-cmd will be used as follows: > # AGENT_READ_DIR=/tmp/virtio-trace/tracing \ > AGENT_CTL=/tmp/virtio-trace/agent-ctl-path.in

Re: [PATCH 2/5] trace-cmd: Use tracing directory to count CPUs

2012-08-22 Thread Steven Rostedt
On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote: > From: Masami Hiramatsu > > Count debugfs/tracing/per_cpu/cpu* to determine the > number of CPUs. I'm curious, do you find that sysconf doesn't return the # of CPUs the system has? I've had boxes where the per_cpu/cpu* had more cpus th

Re: [PATCH 1/5] trace-cmd: Use TRACE_DIR envrionment variable if defined

2012-08-22 Thread Steven Rostedt
On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote: > From: Masami Hiramatsu > > Use TRACE_DIR environment variable for setting TRACING_DIR would be better, as we are searching for /debug/tracing and not /debug/trace. Perhaps DEBUG_TRACING_DIR would be even better as to be less of a gene

Re: [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-22 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 02:09:28PM +0200, Paolo Bonzini wrote: > Il 22/08/2012 13:04, Cong Meng ha scritto: > >> > >> Cong, what is the limit that the host HBA enforces (and what is the > >> HBA)? What commands see a problem? Is it fixed by using scsi-block > >> instead of scsi-generic (if you ca

Re: [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-22 Thread Paolo Bonzini
Il 22/08/2012 13:04, Cong Meng ha scritto: >> >> Cong, what is the limit that the host HBA enforces (and what is the >> HBA)? What commands see a problem? Is it fixed by using scsi-block >> instead of scsi-generic (if you can use scsi-block at all, i.e. it's not >> a tape or similar device)? >> >

Re: [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-22 Thread Cong Meng
On 08/21/2012 06:14 PM, Paolo Bonzini wrote: Il 21/08/2012 11:52, Stefan Hajnoczi ha scritto: Using /sys/dev/block or /sys/dev/char seems easier, and lets you retrieve the parameters for block devices too. what do you mean with "block devices"? Using "/dev/sda" instead of "/dev/sg0"? Yes

Re: [PATCH v8 1/5] mm: introduce a common interface for balloon pages mobility

2012-08-22 Thread Michael S. Tsirkin
On Tue, Aug 21, 2012 at 10:19:31PM -0300, Rafael Aquini wrote: > On Wed, Aug 22, 2012 at 03:07:41AM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 21, 2012 at 05:45:56PM -0300, Rafael Aquini wrote: > > > On Tue, Aug 21, 2012 at 10:30:31PM +0300, Michael S. Tsirkin wrote: > > > > On Tue, Aug 21, 2

[PATCH 5/5] trace-cmd: Use polling function

2012-08-22 Thread Yoshihiro YUNOMAE
Use poll() for avoiding a busy loop to read trace data of a guest from FIFO. Signed-off-by: Yoshihiro YUNOMAE --- trace-recorder.c | 42 -- 1 files changed, 36 insertions(+), 6 deletions(-) diff --git a/trace-recorder.c b/trace-recorder.c index 6577fe8

[PATCH 4/5] trace-cmd: Add non-blocking option for open() and splice_read()

2012-08-22 Thread Yoshihiro YUNOMAE
Add non-blocking option for open() and splice_read() for avoiding block to read trace data of a guest from FIFO. If SIGINT comes to read/write processes from the parent process in the case where FIFO as a read I/F is assigned, then reading is normally blocked for splice_read(). So, we added nonblo

[PATCH 3/5] trace-cmd: Support trace-agent of virtio-trace

2012-08-22 Thread Yoshihiro YUNOMAE
Add read path and control path to use trace-agent of virtio-trace. When we use trace-agent, trace-cmd will be used as follows: # AGENT_READ_DIR=/tmp/virtio-trace/tracing \ AGENT_CTL=/tmp/virtio-trace/agent-ctl-path.in \ TRACING_DIR=/tmp/virtio-trace/debugfs/tracing \

[PATCH 2/5] trace-cmd: Use tracing directory to count CPUs

2012-08-22 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Count debugfs/tracing/per_cpu/cpu* to determine the number of CPUs. Signed-off-by: Masami Hiramatsu Signed-off-by: Yoshihiro YUNOMAE --- trace-record.c | 41 + 1 files changed, 41 insertions(+), 0 deletions(-) diff --git a/tra

[PATCH 1/5] trace-cmd: Use TRACE_DIR envrionment variable if defined

2012-08-22 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Use TRACE_DIR environment variable for setting debugfs/tracing directory if defined. This is for controlling guest(or remote) ftrace. Signed-off-by: Masami Hiramatsu Signed-off-by: Yoshihiro YUNOMAE --- trace-util.c |9 + 1 files changed, 9 insertions(+), 0

[PATCH 0/5] trace-cmd: Add a recorder readable feature for virtio-trace

2012-08-22 Thread Yoshihiro YUNOMAE
Hi Steven, The following patch set provides a feature which can read trace data of a guest using virtio-trace (https://lkml.org/lkml/2012/8/9/210) for a recorder function of trace-cmd. This patch set depends on the trace-agent running on a guest in the virtio-trace system. To translate raw data o

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-22 Thread Stefan Hajnoczi
On Tue, Aug 21, 2012 at 7:31 PM, Blue Swirl wrote: > On Tue, Aug 21, 2012 at 8:23 AM, Cong Meng wrote: >> diff --git a/block_int.h b/block_int.h >> index d72317f..a9d07a2 100644 >> --- a/block_int.h >> +++ b/block_int.h >> @@ -333,6 +333,10 @@ struct BlockDriverState { >> >> /* long-running