PCI device not properly reset after VFIO

2012-10-17 Thread Hannes Reinecke
Hi Alex, I've been playing around with VFIO and megasas (of course). What I did now was switching between VFIO and 'normal' operation, ie emulated access. megasas is happily running under VFIO, but when I do an emergency stop like killing the Qemu session the PCI device is not properly reset.

Re: [PATCH] vhost-blk: Add vhost-blk support v2

2012-10-17 Thread Michael S. Tsirkin
On Thu, Oct 18, 2012 at 02:50:56PM +1030, Rusty Russell wrote: > Asias He writes: > >>> +#define BLK_HDR 0 > >> > >> What's this for, exactly? Please add a comment. > > > > The block headr is in the first and separate buffer. > > Please don't assume this! We're trying to fix all the assumption

Re: [PATCH] vhost-blk: Add vhost-blk support v2

2012-10-17 Thread Rusty Russell
Asias He writes: >>> +#define BLK_HDR0 >> >> What's this for, exactly? Please add a comment. > > The block headr is in the first and separate buffer. Please don't assume this! We're trying to fix all the assumptions in qemu at the moment. vhost_net handles this correctly, taking bytes off

Re: [PATCH] virtio: 9p: correctly pass physical address to userspace for high pages

2012-10-17 Thread Rusty Russell
Will Deacon writes: > When using a virtio transport, the 9p net device allocates pages to back > the descriptors inserted into the virtqueue. These allocations may be > performed from atomic context (under the channel lock) and can therefore > return high mappings which aren't suitable for virt_to