Re: [PATCH -next] tcm_vhost: remove unused variable in vhost_scsi_allocate_cmd()

2012-11-08 Thread Nicholas A. Bellinger
Hello Wei, On Wed, 2012-11-07 at 20:53 +0800, Wei Yongjun wrote: > From: Wei Yongjun > > The variable se_sess is initialized but never used > otherwise, so remove the unused variable. > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by:

Re: [PATCH] virtio: Don't access index after unregister.

2012-11-08 Thread Michael S. Tsirkin
On Thu, Nov 08, 2012 at 11:43:47AM +0100, Cornelia Huck wrote: > Virtio wants to release used indices after the corresponding > virtio device has been unregistered. However, virtio does not > hold an extra reference, giving up its last reference with > device_unregister(), making accessing dev->ind

Re: [PATCH v3] virtio-mmio: Fix irq parsing in command line parameter

2012-11-08 Thread Rusty Russell
Pawel Moll writes: > When the resource_size_t is 64-bit long, the sscanf() on > the virtio device command line paramter string may return > wrong value because its format was defined as "%u". Fixed > by using an intermediate local value of a known length. > > Also added cleaned up the resource cre

Re: [PATCH] virtio: Don't access index after unregister.

2012-11-08 Thread Rusty Russell
Cornelia Huck writes: > Virtio wants to release used indices after the corresponding > virtio device has been unregistered. However, virtio does not > hold an extra reference, giving up its last reference with > device_unregister(), making accessing dev->index afterwards > invalid. > > I actually

Re: [rfc net-next v6 3/3] virtio-net: change the number of queues through ethtool

2012-11-08 Thread Ben Hutchings
On Tue, 2012-10-30 at 18:03 +0800, Jason Wang wrote: > This patch implement the {set|get}_channels method of ethool to allow user to > change the number of queues dymaically when the device is running. This would > let the user to tune the device for specific applications. > > Signed-off-by: Jason

[PATCH v3] virtio-mmio: Fix irq parsing in command line parameter

2012-11-08 Thread Pawel Moll
When the resource_size_t is 64-bit long, the sscanf() on the virtio device command line paramter string may return wrong value because its format was defined as "%u". Fixed by using an intermediate local value of a known length. Also added cleaned up the resource creation and added extra comments

Re: [Pv-drivers] [PATCH 0/6] VSOCK for Linux upstreaming

2012-11-08 Thread Andy King
Hi Gerd, >> Also, there was some interest from RedHat into using vSockets as >> a unified interface, routed over a hypervisor-specific transport >> (virtio or otherwise, although for now VMCI is the only one >> implemented). > > Can you outline how this can be done? From a quick look over the >

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-08 Thread Rusty Russell
Lee Jones writes: >> > Resorted to poaching now have we Pawel? > >> I hope you were joking! > > Yes, of course. I thought that was clearly indicated by the jovial winking > smiley. :) > > I realise it wasn't obvious soley by this exchange, but Pawel and I are > actually ol' friends. > >> Doing yo

Re: [PATCH] virtio: Don't access index after unregister.

2012-11-08 Thread Sjur Brændeland
On Thu, Nov 8, 2012 at 11:43 AM, Cornelia Huck wrote: > Virtio wants to release used indices after the corresponding > virtio device has been unregistered. However, virtio does not > hold an extra reference, giving up its last reference with > device_unregister(), making accessing dev->index after

[PATCH] virtio: Don't access index after unregister.

2012-11-08 Thread Cornelia Huck
Virtio wants to release used indices after the corresponding virtio device has been unregistered. However, virtio does not hold an extra reference, giving up its last reference with device_unregister(), making accessing dev->index afterwards invalid. I actually saw problems when testing my (not-ye

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-08 Thread Lee Jones
> > Resorted to poaching now have we Pawel? > I hope you were joking! Yes, of course. I thought that was clearly indicated by the jovial winking smiley. :) I realise it wasn't obvious soley by this exchange, but Pawel and I are actually ol' friends. > Doing your work for you isn't poaching. Th

Re: [PATCH resend] virtio_console: Free buffers from out-queue upon close

2012-11-08 Thread Sjur Brændeland
>> > Note: This patch is compile tested only. I have done the removal >> > of buffers from out-queue in handle_control_message() >> > when host has acked the close request. This seems less >> > racy than doing it in the release function. >> >> This confuses me... why are we doing this in case >> VI

[[PATCH v9 3/3] 1/1] virtio_console: Remove buffers from out_vq at port removal

2012-11-08 Thread Amit Shah
From: Sjur Brændeland Remove buffers from the out-queue when a port is removed. Rproc_serial communicates with remote processors that may crash and leave buffers in the out-queue. The virtio serial ports may have buffers in the out-queue as well, e.g. for non-blocking ports and the host didn't co

Re: [PATCHv8 0/3]virtio_console: Add rproc_serial driver

2012-11-08 Thread Amit Shah
On (Tue) 30 Oct 2012 [09:51:50], Sjur Brændeland wrote: > From: Sjur Brændeland > > This patch-set introduces a new virtio type "rproc_serial" for communicating > with remote processors over shared memory. The driver depends on the > the remoteproc framework. As preparation for introducing "rproc

Re: [PATCH resend] virtio_console: Free buffers from out-queue upon close

2012-11-08 Thread Amit Shah
On (Thu) 08 Nov 2012 [10:28:53], Rusty Russell wrote: > sjur.brandel...@stericsson.com writes: > > > From: Sjur Brændeland > > > > Free pending output buffers from the virtio out-queue when > > host has acknowledged port_close. Also removed WARN_ON() > > in remove_port_data(). > > > > Signed-off-