Re: [net-next rfc v7 2/3] virtio_net: multiqueue support

2012-12-02 Thread Michael S. Tsirkin
On Tue, Nov 27, 2012 at 06:15:59PM +0800, Jason Wang wrote: > This addes multiqueue support to virtio_net driver. In multiple queue modes, > the > driver expects the number of queue paris is equal to the number of vcpus. To > eliminate the contention bettwen vcpus and virtqueues, per-cpu virtqueue

Re: [net-next rfc v7 3/3] virtio-net: change the number of queues through ethtool

2012-12-02 Thread Michael S. Tsirkin
On Tue, Nov 27, 2012 at 06:16:00PM +0800, Jason Wang wrote: > This patch implement the {set|get}_channels method of ethool to allow user to > change the number of queues dymaically when the device is running. This would > let the user to configure it on demand. > > Signed-off-by: Jason Wang > ---

Re: [PATCHv4] virtio-spec: virtio network device RFS support

2012-12-02 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Add RFS support to virtio network device. > Add a new feature flag VIRTIO_NET_F_RFS for this feature, a new > configuration field max_virtqueue_pairs to detect supported number of > virtqueues as well as a new command VIRTIO_NET_CTRL_RFS to program > packet steering

Re: [net-next rfc v7 2/3] virtio_net: multiqueue support

2012-12-02 Thread Rusty Russell
Jason Wang writes: > +static const struct ethtool_ops virtnet_ethtool_ops; > + > +/* > + * Converting between virtqueue no. and kernel tx/rx queue no. > + * 0:rx0 1:tx0 2:cvq 3:rx1 4:tx1 ... 2N+1:rxN 2N+2:txN > + */ > +static int vq2txq(struct virtqueue *vq) > +{ > + int index = virtqueue_get_

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-02 Thread Rusty Russell
Jason Wang writes: > To support multiqueue transmitq/receiveq, the first step is to separate queue > related structure from virtnet_info. This patch introduce send_queue and > receive_queue structure and use the pointer to them as the parameter in > functions handling sending/receiving. OK, seems

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-02 Thread Jason Wang
On Monday, December 03, 2012 12:25:42 PM Rusty Russell wrote: > Jason Wang writes: > > To support multiqueue transmitq/receiveq, the first step is to separate > > queue related structure from virtnet_info. This patch introduce > > send_queue and receive_queue structure and use the pointer to them

Re: [net-next rfc v7 2/3] virtio_net: multiqueue support

2012-12-02 Thread Jason Wang
On Sunday, December 02, 2012 06:06:31 PM Michael S. Tsirkin wrote: > On Tue, Nov 27, 2012 at 06:15:59PM +0800, Jason Wang wrote: > > This addes multiqueue support to virtio_net driver. In multiple queue > > modes, the driver expects the number of queue paris is equal to the > > number of vcpus. To

Re: [net-next rfc v7 2/3] virtio_net: multiqueue support

2012-12-02 Thread Jason Wang
On Monday, December 03, 2012 12:34:08 PM Rusty Russell wrote: > Jason Wang writes: > > +static const struct ethtool_ops virtnet_ethtool_ops; > > + > > +/* > > + * Converting between virtqueue no. and kernel tx/rx queue no. > > + * 0:rx0 1:tx0 2:cvq 3:rx1 4:tx1 ... 2N+1:rxN 2N+2:txN > > + */ > > +s

Re: [net-next rfc v7 3/3] virtio-net: change the number of queues through ethtool

2012-12-02 Thread Jason Wang
On Sunday, December 02, 2012 06:09:06 PM Michael S. Tsirkin wrote: > On Tue, Nov 27, 2012 at 06:16:00PM +0800, Jason Wang wrote: > > This patch implement the {set|get}_channels method of ethool to allow user > > to change the number of queues dymaically when the device is running. > > This would le

Re: [net-next RFC] pktgen: don't wait for the device who doesn't free skb immediately after sent

2012-12-02 Thread Jason Wang
On Tuesday, November 27, 2012 08:49:19 AM Stephen Hemminger wrote: > On Tue, 27 Nov 2012 14:45:13 +0800 > > Jason Wang wrote: > > On 11/27/2012 01:37 AM, Stephen Hemminger wrote: > > > On Mon, 26 Nov 2012 15:56:52 +0800 > > > > > > Jason Wang wrote: > > >> Some deivces do not free the old tx sk