Re: [PATCH v2 0/5] Multiqueue virtio-scsi, and API for piecewise buffer submission

2012-12-19 Thread Paolo Bonzini
Il 18/12/2012 23:18, Rolf Eike Beer ha scritto: > Paolo Bonzini wrote: >> Hi all, >> >> this series adds multiqueue support to the virtio-scsi driver, based >> on Jason Wang's work on virtio-net. It uses a simple queue steering >> algorithm that expects one queue per CPU. LUNs in the same target

Re: [PATCH v2 0/5] Multiqueue virtio-scsi, and API for piecewise buffer submission

2012-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2012 at 09:52:59AM +0100, Paolo Bonzini wrote: > Il 18/12/2012 23:18, Rolf Eike Beer ha scritto: > > Paolo Bonzini wrote: > >> Hi all, > >> > >> this series adds multiqueue support to the virtio-scsi driver, based > >> on Jason Wang's work on virtio-net. It uses a simple queue stee

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Paolo Bonzini
Il 19/12/2012 11:47, Stefan Hajnoczi ha scritto: > On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: >> +/** >> + * virtqueue_start_buf - start building buffer for the other end >> + * @vq: the struct virtqueue we're talking about. >> + * @buf: a struct keeping the state of the buffer

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Stefan Hajnoczi
On Wed, Dec 19, 2012 at 1:04 PM, Paolo Bonzini wrote: > Il 19/12/2012 11:47, Stefan Hajnoczi ha scritto: >> On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: >> What is the purpose of count_sg? > > It is needed to decide whether to use an indirect or a direct buffer. > The idea is to

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2012 at 01:04:08PM +0100, Paolo Bonzini wrote: > Il 19/12/2012 11:47, Stefan Hajnoczi ha scritto: > > On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: > >> +/** > >> + * virtqueue_start_buf - start building buffer for the other end > >> + * @vq: the struct virtqueue we

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2012 at 06:51:30PM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2012 at 01:04:08PM +0100, Paolo Bonzini wrote: > > Il 19/12/2012 11:47, Stefan Hajnoczi ha scritto: > > > On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: > > >> +/** > > >> + * virtqueue_start_buf -

[PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-19 Thread Alexander Graf
When a file system is mounted on a virtio-blk disk, we then remove it and then reattach it, the reattached disk gets the same disk name and ids as the hot removed one. This leads to very nasty effects - mostly rendering the newly attached device completely unusable. Trying what happens when I do

Re: [Xen-devel] [PATCH 1/1] xen/xenbus: Remove duplicate inclusion of asm/xen/hypervisor.h

2012-12-19 Thread Konrad Rzeszutek Wilk
On Tue, Nov 27, 2012 at 09:03:26AM +0530, Sachin Kamat wrote: > ping I think I have this in my tree. > > On 19 November 2012 16:52, Sachin Kamat wrote: > > asm/xen/hypervisor.h was included twice. > > > > Signed-off-by: Sachin Kamat > > --- > > drivers/xen/xenbus/xenbus_xs.c |1 - > > 1 fi

Re: [PATCH v2 0/5] Multiqueue virtio-scsi, and API for piecewise buffer submission

2012-12-19 Thread Rolf Eike Beer
Paolo Bonzini wrote: > Hi all, > > this series adds multiqueue support to the virtio-scsi driver, based > on Jason Wang's work on virtio-net. It uses a simple queue steering > algorithm that expects one queue per CPU. LUNs in the same target always > use the same queue (so that commands are not

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2012-12-19 Thread Stefan Hajnoczi
On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: > +/** > + * virtqueue_start_buf - start building buffer for the other end > + * @vq: the struct virtqueue we're talking about. > + * @buf: a struct keeping the state of the buffer > + * @data: the token identifying the buffer. > + * @c

Re: [PATCH v2 5/5] virtio-scsi: introduce multiqueue support

2012-12-19 Thread Stefan Hajnoczi
On Tue, Dec 18, 2012 at 01:32:52PM +0100, Paolo Bonzini wrote: > struct virtio_scsi_target_state { > - /* Never held at the same time as vq_lock. */ > + /* This spinlock ever held at the same time as vq_lock. */ s/ever/is never/ ___ Virtualiza

Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-19 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Tue, Dec 18, 2012 at 03:57:17PM +0100, Stefan Hajnoczi wrote: >> > > @@ -407,6 +409,14 @@ static void virtio_blk_handle_output(VirtIODevice >> > > *vdev, VirtQueue *vq) >> > > .num_writes = 0, >> > > }; >> > > >> > > +/* Some guests kick befor

Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-19 Thread Rusty Russell
Alexander Graf writes: > When a file system is mounted on a virtio-blk disk, we then remove it > and then reattach it, the reattached disk gets the same disk name and > ids as the hot removed one. > > This leads to very nasty effects - mostly rendering the newly attached > device completely unusa