Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-20 Thread Asias He
On 12/20/2012 12:15 PM, Rusty Russell wrote: > Alexander Graf writes: > >> When a file system is mounted on a virtio-blk disk, we then remove it >> and then reattach it, the reattached disk gets the same disk name and >> ids as the hot removed one. >> >> This leads to very nasty effects - mostly

Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-20 Thread Alexander Graf
On 20.12.2012, at 09:46, Asias He wrote: > On 12/20/2012 12:15 PM, Rusty Russell wrote: >> Alexander Graf writes: >> >>> When a file system is mounted on a virtio-blk disk, we then remove it >>> and then reattach it, the reattached disk gets the same disk name and >>> ids as the hot removed o

Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-20 Thread Michael S. Tsirkin
On Wed, Dec 19, 2012 at 08:40:15PM +0100, Alexander Graf wrote: > When a file system is mounted on a virtio-blk disk, we then remove it > and then reattach it, the reattached disk gets the same disk name and > ids as the hot removed one. > > This leads to very nasty effects - mostly rendering the

Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-20 Thread Alexander Graf
On 20.12.2012, at 11:54, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2012 at 08:40:15PM +0100, Alexander Graf wrote: >> When a file system is mounted on a virtio-blk disk, we then remove it >> and then reattach it, the reattached disk gets the same disk name and >> ids as the hot removed one. >>

Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-20 Thread Michael S. Tsirkin
On Thu, Dec 20, 2012 at 12:27:53PM +0100, Alexander Graf wrote: > > On 20.12.2012, at 11:54, Michael S. Tsirkin wrote: > > > On Wed, Dec 19, 2012 at 08:40:15PM +0100, Alexander Graf wrote: > >> When a file system is mounted on a virtio-blk disk, we then remove it > >> and then reattach it, the re

Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-20 Thread Alexander Graf
On 20.12.2012, at 12:38, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2012 at 12:27:53PM +0100, Alexander Graf wrote: >> >> On 20.12.2012, at 11:54, Michael S. Tsirkin wrote: >> >>> On Wed, Dec 19, 2012 at 08:40:15PM +0100, Alexander Graf wrote: When a file system is mounted on a virtio-blk

Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-20 Thread Asias He
On 12/20/2012 05:41 PM, Alexander Graf wrote: > > > On 20.12.2012, at 09:46, Asias He wrote: > >> On 12/20/2012 12:15 PM, Rusty Russell wrote: >>> Alexander Graf writes: >>> When a file system is mounted on a virtio-blk disk, we then remove it and then reattach it, the reattached dis

Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-20 Thread Asias He
On 12/20/2012 06:54 PM, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2012 at 08:40:15PM +0100, Alexander Graf wrote: >> When a file system is mounted on a virtio-blk disk, we then remove it >> and then reattach it, the reattached disk gets the same disk name and >> ids as the hot removed one. >> >>

Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-20 Thread Asias He
On 12/20/2012 07:27 PM, Alexander Graf wrote: > > On 20.12.2012, at 11:54, Michael S. Tsirkin wrote: > >> On Wed, Dec 19, 2012 at 08:40:15PM +0100, Alexander Graf wrote: >>> When a file system is mounted on a virtio-blk disk, we then remove it >>> and then reattach it, the reattached disk gets th

Re: [PATCH] virtio-blk: Don't free ida when disk is in use

2012-12-20 Thread Asias He
On 12/20/2012 07:47 PM, Alexander Graf wrote: > > On 20.12.2012, at 12:38, Michael S. Tsirkin wrote: > >> On Thu, Dec 20, 2012 at 12:27:53PM +0100, Alexander Graf wrote: >>> >>> On 20.12.2012, at 11:54, Michael S. Tsirkin wrote: >>> On Wed, Dec 19, 2012 at 08:40:15PM +0100, Alexander Graf wr

Re: [RFCv2 00/12] Introduce host-side virtio queue and CAIF Virtio.

2012-12-20 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Wed, Dec 05, 2012 at 03:36:58PM +0100, Sjur Brændeland wrote: >> Feedback on this patch-set is appreciated, particularly on structure >> and code-reuse between vhost.c and the host-side virtio-queue. >> I'd also like some suggestions on how to handle the build co

Re: [PATCH] virtio_console: correct error message on failure of debugfs_create_dir

2012-12-20 Thread Amit Shah
On (Thu) 20 Dec 2012 [14:11:21], Sasha Levin wrote: > debugfs_create_dir() returns NULL if it fails, there's little point in > calling PTR_ERR on it. > > Signed-off-by: Sasha Levin > --- > drivers/char/virtio_console.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --gi