Re: [PATCH v2] virtio-spec: set mac address by a new vq command

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 06:25:47PM +0800, ak...@redhat.com wrote: > From: Amos Kong > > Virtio-net driver currently programs MAC address byte by byte, > this means that we have an intermediate step where mac is wrong. > This patch introduced a new control command to set MAC address > in one time,

Re: [PATCH v3 2/2] virtio-net: introduce a new control to set macaddr

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 06:40:12PM +0800, ak...@redhat.com wrote: > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 395ab4f..837c978 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -802,14 +802,32 @@ static int virtnet_set_mac_address(struct ne

[PATCH v3] virtio-spec: set mac address by a new vq command

2013-01-18 Thread akong
From: Amos Kong Virtio-net driver currently programs MAC address byte by byte, this means that we have an intermediate step where mac is wrong. This patch introduced a new control command to set MAC address in one time, and added a new feature flag VIRTIO_NET_F_MAC_ADDR for this feature. "mac" f

[PATCH] virtio: suppress kmemleak false positive

2013-01-18 Thread Alexandru Copot
While doing simple IPv6 tests in KVM virtual machines, (add an IPv6 address to eth0) kmemleak complains about an unreferenced object: unreferenced object 0x88001e804120 (size 32): comm "softirq", pid 0, jiffies 4294900928 (age 631.544s) hex dump (first 32 bytes): 28 cb fd 1d 00 00 00 0

[RFC] remoteproc: Add support for host-side (reversed) vrings

2013-01-18 Thread sjur . brandeland
From: Sjur Brændeland Hi Ohad, Ido and Rusty. Rusty has implemented host-side virtio ring. I will be using vringh for the caif_virtio driver. But we need to figure out how to integrate the vringh into remoteproc. Below is my initial stab on this. This code is completely untested, but I'd love t

Re: [RFCv2 00/12] Introduce host-side virtio queue and CAIF Virtio.

2013-01-18 Thread Rusty Russell
Rusty Russell writes: > "Michael S. Tsirkin" writes: >> On Wed, Jan 16, 2013 at 01:43:32PM +1030, Rusty Russell wrote: >>> "Michael S. Tsirkin" writes: >>> >> +static int resize_iovec(struct vringh_iov *iov, gfp_t gfp) >>> >> +{ >>> >> +struct iovec *new; >>> >> +unsigned int new

[QEMU PATCH v4 0/3] virtio-net: fix of ctrl commands

2013-01-18 Thread akong
From: Amos Kong Currently virtio-net code relys on the layout of descriptor, this patchset removed the assumptions and introduced a control command to set mac address. Last patch is a trivial renaming. V2: check guest's iov_len V3: fix of migration compatibility make mac field in config spac

[QEMU PATCH v4 1/3] virtio-net: remove layout assumptions for ctrl vq

2013-01-18 Thread akong
From: "Michael S. Tsirkin" Virtio-net code makes assumption about virtqueue descriptor layout (e.g. sg[0] is the header, sg[1] is the data buffer). This patch makes code not rely on the layout of descriptors. Signed-off-by: Michael S. Tsirkin Signed-off-by: Amos Kong --- hw/virtio-net.c | 12

[QEMU PATCH v4 2/3] virtio-net: introduce a new macaddr control

2013-01-18 Thread akong
From: Amos Kong In virtio-net guest driver, currently we write MAC address to pci config space byte by byte, this means that we have an intermediate step where mac is wrong. This patch introduced a new control command to set MAC address, it's atomic. VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature b

[QEMU PATCH v4 3/3] virtio-net: rename ctrl rx commands

2013-01-18 Thread akong
From: Amos Kong This patch makes rx commands consistent with specification. Signed-off-by: Amos Kong --- hw/virtio-net.c | 14 +++--- hw/virtio-net.h | 14 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index cf40ff2..5

Re: [Qemu-devel] [QEMU PATCH v4 1/3] virtio-net: remove layout assumptions for ctrl vq

2013-01-18 Thread Amos Kong
On Sat, Jan 19, 2013 at 09:54:26AM +0800, ak...@redhat.com wrote: > From: "Michael S. Tsirkin" > > Virtio-net code makes assumption about virtqueue descriptor layout > (e.g. sg[0] is the header, sg[1] is the data buffer). > > This patch makes code not rely on the layout of descriptors. > > Sign