Re: [PATCH v4 2/3] net: split eth_mac_addr for better error handling

2013-01-20 Thread David Miller
From: ak...@redhat.com Date: Sun, 20 Jan 2013 10:43:08 +0800 > From: Stefan Hajnoczi > > When we set mac address, software mac address in system and hardware mac > address all need to be updated. Current eth_mac_addr() doesn't allow > callers to implement error handling nicely. > > This patch s

Re: [PATCH v3] virtio-spec: set mac address by a new vq command

2013-01-20 Thread Rusty Russell
ak...@redhat.com writes: > From: Amos Kong > > Virtio-net driver currently programs MAC address byte by byte, > this means that we have an intermediate step where mac is wrong. > This patch introduced a new control command to set MAC address > in one time, and added a new feature flag VIRTIO_NET_F

Re: [PATCH 1/6] virtio_host: host-side implementation of virtio rings.

2013-01-20 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Thu, Jan 17, 2013 at 08:59:38PM +1030, Rusty Russell wrote: >> +/* Returns vring->num if empty, -ve on error. */ >> +static inline int __vringh_get_head(const struct vringh *vrh, >> +int (*getu16)(u16 *val, const u16 *p), > > I thin

Re: [PATCH 1/6] virtio_host: host-side implementation of virtio rings.

2013-01-20 Thread Rusty Russell
Sjur Brændeland writes: > On Thu, Jan 17, 2013 at 12:23 PM, Michael S. Tsirkin wrote: >> in otgher words, we might need to split a single desc to multiple >> iov entries. > > Splitting descriptors doesn't work for me. As described earlier, I > receive one IP-frame for each descriptor. So I need t