Re: [PATCH 1/1] VSOCK: Introduce VM Sockets

2013-01-25 Thread Neil Horman
On Fri, Jan 25, 2013 at 09:37:50AM -0800, ack...@vmware.com wrote: > From: Andy King > > VM Sockets allows communication between virtual machines and the hypervisor. > User level applications both in a virtual machine and on the host can use the > VM Sockets API, which facilitates fast and effici

Re: [Pv-drivers] [PATCH 1/1] VSOCK: Introduce VM Sockets

2013-01-25 Thread Greg KH
On Fri, Jan 25, 2013 at 04:15:19PM -0800, Dmitry Torokhov wrote: > Hi Neil, > > On Friday, January 25, 2013 06:59:53 PM Neil Horman wrote: > > On Fri, Jan 25, 2013 at 09:37:50AM -0800, ack...@vmware.com wrote: > > > + > > > +config VMWARE_VSOCK > > > + tristate "Virtual Socket protocol" > > > + de

Re: [Pv-drivers] [PATCH 1/1] VSOCK: Introduce VM Sockets

2013-01-25 Thread Dmitry Torokhov
Hi Neil, On Friday, January 25, 2013 06:59:53 PM Neil Horman wrote: > On Fri, Jan 25, 2013 at 09:37:50AM -0800, ack...@vmware.com wrote: > > + > > +config VMWARE_VSOCK > > + tristate "Virtual Socket protocol" > > + depends on VMWARE_VMCI > > What is CONFIG_VMWARE_VMCI? I don't find that in a

Re: [Pv-drivers] [PATCH 0/6] VSOCK for Linux upstreaming

2013-01-25 Thread Andy King
> > > Our position is that VSOCK feature set is more complete and that > > > it > > > should be possible to use transports other than VMCI for VSOCK > > > traffic, should interested parties implement them, > > > > Implementing other transports requires restructing vsock (and vmci) > > first as the

[PATCH 0/1] VM Sockets for Linux upstreaming

2013-01-25 Thread acking
From: Andy King ** Introduce VM Sockets *** In an effort to improve the out-of-the-box experience with Linux kernels for VMware users, VMware is working on readying the VM Sockets (VSOCK, formerly VMCI Sockets) (vmw_vsock) kernel module for inclusion in the Linux kernel. The purpose of this post

Re: [PATCH 35/35] x86: Don't panic if can not alloc buffer for swiotlb

2013-01-25 Thread Konrad Rzeszutek Wilk
On Thu, Jan 24, 2013 at 12:20:16PM -0800, Yinghai Lu wrote: > Normal boot path on system with iommu support: > swiotlb buffer will be allocated early at first and then try to initialize > iommu, if iommu for intel or AMD could setup properly, swiotlb buffer > will be freed. > > The early allocatin

RE: [PATCH] virtio_console: Let unconnected rproc device receive data.

2013-01-25 Thread Sjur BRENDELAND
Hi Amit, > > @@ -1763,8 +1763,11 @@ static void in_intr(struct virtqueue *vq) > > * tty is spawned) and the host sends out data to console > > * ports. For generic serial ports, the host won't > > * (shouldn't) send data till the guest is connected. > > +* However a remote devi

[PATCH V8 3/3] virtio-net: reset virtqueue affinity when doing cpu hotplug

2013-01-25 Thread Wanlong Gao
Add a cpu notifier to virtio-net, so that we can reset the virtqueue affinity if the cpu hotplug happens. It improve the performance through enabling or disabling the virtqueue affinity after doing cpu hotplug. Cc: Rusty Russell Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Eric Dumazet Cc: "Dav

[PATCH V8 2/3] virtio-net: split out clean affinity function

2013-01-25 Thread Wanlong Gao
Split out the clean affinity function to virtnet_clean_affinity(). Cc: Rusty Russell Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Eric Dumazet Cc: "David S. Miller" Cc: virtualization@lists.linux-foundation.org Cc: net...@vger.kernel.org Signed-off-by: Wanlong Gao Acked-by: Michael S. Tsirkin

[PATCH V8 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-25 Thread Wanlong Gao
As Michael mentioned, set affinity and select queue will not work very well when CPU IDs are not consecutive, this can happen with hot unplug. Fix this bug by traversal the online CPUs, and create a per cpu variable to find the mapping from CPU to the preferable virtual-queue. Cc: Rusty Russell C

Re: [RFC] virtio_console: Add DRIVER and INTERFACE to uevent.

2013-01-25 Thread Amit Shah
On (Thu) 24 Jan 2013 [08:51:39], Greg KH wrote: > On Thu, Jan 24, 2013 at 02:30:59PM +0100, Sjur Brændeland wrote: > > Another approach could perhaps be to change the way port-names are > > generated by virtio_console... > > How would that help here? > > The way to solve this is to provide users

Re: [PATCH] virtio_console: Use virtio device index to generate port name

2013-01-25 Thread Amit Shah
On (Thu) 17 Jan 2013 [13:23:17], sjur.brandel...@stericsson.com wrote: > From: Sjur Brændeland > > Use virtio device index for creating unique device port names. > Current index allocation in virtio is based on a monotonically > increasing variable "index". A better handling of this is to > use d

Re: [PATCH V7 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-25 Thread Wanlong Gao
- for (i = 0; i < vi->max_queue_pairs; i++) { - int cpu = set ? i : -1; - virtqueue_set_affinity(vi->rq[i].vq, cpu); - virtqueue_set_affinity(vi->sq[i].vq, cpu); - } + if (set) { + i = 0; + for_each_onli

Re: [PATCH V7 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-25 Thread Jason Wang
On 01/25/2013 05:05 PM, Wanlong Gao wrote: > On 01/25/2013 05:00 PM, Jason Wang wrote: >> On 01/25/2013 04:36 PM, Wanlong Gao wrote: >>> As Michael mentioned, set affinity and select queue will not work very >>> well when CPU IDs are not consecutive, this can happen with hot unplug. >>> Fix this bu

Re: [PATCH] virtio_console: Let unconnected rproc device receive data.

2013-01-25 Thread Amit Shah
On (Thu) 17 Jan 2013 [13:22:42], sjur.brandel...@stericsson.com wrote: > From: Sjur Brændeland > > Allow rproc serial ports to receive data before the port > is connected. > > Rproc serial ports usually talk to very simple remote devices > with no control queue managing open/close events. So we

Re: [PATCH] virtio_console: Don't access uninitialized data.

2013-01-25 Thread Amit Shah
On (Thu) 17 Jan 2013 [13:21:32], sjur.brandel...@stericsson.com wrote: > From: Sjur Brændeland > > Don't access uninitialized work-queue when removing device. > The work queue is initialized only if the device multi-queue. > So don't call cancel_work unless this is a multi-queue device. > > This

Re: [PATCH V7 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-25 Thread Wanlong Gao
On 01/25/2013 05:00 PM, Jason Wang wrote: > On 01/25/2013 04:36 PM, Wanlong Gao wrote: >> As Michael mentioned, set affinity and select queue will not work very >> well when CPU IDs are not consecutive, this can happen with hot unplug. >> Fix this bug by traversal the online CPUs, and create a per

Re: [PATCH V7 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-25 Thread Jason Wang
On 01/25/2013 04:36 PM, Wanlong Gao wrote: > As Michael mentioned, set affinity and select queue will not work very > well when CPU IDs are not consecutive, this can happen with hot unplug. > Fix this bug by traversal the online CPUs, and create a per cpu variable > to find the mapping from CPU to

[PATCH V7 2/3] virtio-net: split out clean affinity function

2013-01-25 Thread Wanlong Gao
Split out the clean affinity function to virtnet_clean_affinity(). Cc: Rusty Russell Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Eric Dumazet Cc: "David S. Miller" Cc: virtualization@lists.linux-foundation.org Cc: net...@vger.kernel.org Signed-off-by: Wanlong Gao Acked-by: Michael S. Tsirkin

[PATCH V7 3/3] virtio-net: reset virtqueue affinity when doing cpu hotplug

2013-01-25 Thread Wanlong Gao
Add a cpu notifier to virtio-net, so that we can reset the virtqueue affinity if the cpu hotplug happens. It improve the performance through enabling or disabling the virtqueue affinity after doing cpu hotplug. Cc: Rusty Russell Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Eric Dumazet Cc: "Dav

[PATCH V7 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-25 Thread Wanlong Gao
As Michael mentioned, set affinity and select queue will not work very well when CPU IDs are not consecutive, this can happen with hot unplug. Fix this bug by traversal the online CPUs, and create a per cpu variable to find the mapping from CPU to the preferable virtual-queue. Cc: Rusty Russell C