Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-13 Thread Paolo Bonzini
Il 12/02/2013 21:49, Michael S. Tsirkin ha scritto: On Tue, Feb 12, 2013 at 09:08:27PM +0100, Paolo Bonzini wrote: Il 12/02/2013 19:23, Michael S. Tsirkin ha scritto: On Tue, Feb 12, 2013 at 07:04:27PM +0100, Paolo Bonzini wrote: Perhaps, but 3 or 4 arguments (in/out/nsg or

Re: [RFC PATCH 0/8] virtio: new API for addition of buffers, scatterlist changes

2013-02-13 Thread Rusty Russell
Jens Axboe ax...@kernel.dk writes: On Fri, Feb 08 2013, Rusty Russell wrote: Paolo Bonzini pbonz...@redhat.com writes: The virtqueue_add_buf function has two limitations: 1) it requires the caller to provide all the buffers in a single call; 2) it does not support chained scatterlists:

RE: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-13 Thread Rusty Russell
Sjur BRENDELAND sjur.brandel...@stericsson.com writes: Hi Rusty, From: Rusty Russell [mailto:ru...@rustcorp.com.au] sjur.brandel...@stericsson.com writes: +struct cfv_napi_context { + struct vringh_kiov riov; + unsigned short head; +}; Usually we use an int, and -1. I imagine

Re: [PATCH 1/9] virtio: add functions for piecewise addition of buffers

2013-02-13 Thread Michael S. Tsirkin
On Wed, Feb 13, 2013 at 09:06:27AM +0100, Paolo Bonzini wrote: Il 12/02/2013 21:49, Michael S. Tsirkin ha scritto: On Tue, Feb 12, 2013 at 09:08:27PM +0100, Paolo Bonzini wrote: Il 12/02/2013 19:23, Michael S. Tsirkin ha scritto: On Tue, Feb 12, 2013 at 07:04:27PM +0100, Paolo Bonzini

Re: [PATCH 1/1] VSOCK: Introduce VM Sockets

2013-02-13 Thread Gerd Hoffmann
On 02/12/13 16:21, Andy King wrote: Hi Gerd, +struct vsock_transport { ... Whoa. This has grown *alot*. Care to explain this please? Patch creating a Documentation/virtual/vsock.txt would be cool. Yes, it grew because of the notification stuff, which I'd forgotten about until I

CFP Workshop ICT4Mobility-ICT4Mobility 2013

2013-02-13 Thread CalendarSites
CALL FOR PAPERS http://www.smartgreens.org/workshops.aspx#ICT4Mobility Workshop ICT4Mobility- ICT4Mobility 2013 In conjunction with the 2nd International Conference on Smart Grids and Green IT Systems- SMARTGREENS 2013 Website: http://www.smartgreens.org May 9 - 10, 2013 Aachen,

CFP Special Session CloudSecGov

2013-02-13 Thread CalendarSites
CALL FOR PAPERS Special Session on Security Governance and SLAs in Cloud Computing - CloudSecGov 2013 In conjunction with the 3rd International Conference on Cloud Computing and Services Science - CLOSER 2013 Website: http:// http://closer.scitevents.org/CloudSecGov.aspx May 8 - 10,

CFP Cloud Service Analytics Workshop-CSAW 2013

2013-02-13 Thread CalendarSites
CALL FOR PAPERS http://closer.scitevents.org/workshops.aspx#CSAW Cloud Service Analytics Workshop - CSAW 2013 In conjunction with the 3rd International Conference on Cloud Computing and Services Science - CLOSER 2013 Website: http://closer.scitevents.org/CSAW.aspx May 8 - 10, 2013

Re: [PATCH 1/1] VSOCK: Introduce VM Sockets

2013-02-13 Thread Gerd Hoffmann
On 02/07/13 01:23, Andy King wrote: +static int vsock_create(struct net *net, struct socket *sock, + int protocol, int kern) +{ + if (!sock) + return -EINVAL; + + if (protocol) + return -EPROTONOSUPPORT; + IMO protocol == PF_VSOCK

Re: [PATCH vringh 2/2] caif_virtio: Introduce caif over virtio

2013-02-13 Thread Sjur Brændeland
Hi Rusty, On Wed, Feb 13, 2013 at 11:16 AM, Rusty Russell ru...@rustcorp.com.au wrote: Sjur BRENDELAND sjur.brandel...@stericsson.com writes: +static inline void ctx_prep_iov(struct cfv_napi_context *ctx) +{ + if (ctx-riov.allocated) { + kfree(ctx-riov.iov); +

[RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Marc Zyngier
Using readl() to read the magic value and then memcmp() to check it fails on BE, as bytes will be the other way around (by virtue of the registers to follow the endianess of the guest). Fix it by encoding the magic as an integer instead of a string. Cc: Rusty Russell ru...@rustcorp.com.au Cc:

Re: [RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Pawel Moll
On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote: Using readl() to read the magic value and then memcmp() to check it fails on BE, as bytes will be the other way around (by virtue of the registers to follow the endianess of the guest). Hm. Interesting. I missed the fact that readl() as a

Re: [RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Marc Zyngier
On 13/02/13 15:08, Pawel Moll wrote: On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote: Using readl() to read the magic value and then memcmp() to check it fails on BE, as bytes will be the other way around (by virtue of the registers to follow the endianess of the guest). Hm.

Re: [RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Pawel Moll
On Wed, 2013-02-13 at 15:28 +, Marc Zyngier wrote: Fix it by encoding the magic as an integer instead of a string. So I'm not completely sure this is the right fix, It seems right, however... - Using __raw_readl() instead. Is that a generic enough API? ... this implies that

Re: [RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Marc Zyngier
On 13/02/13 15:46, Pawel Moll wrote: On Wed, 2013-02-13 at 15:28 +, Marc Zyngier wrote: Fix it by encoding the magic as an integer instead of a string. So I'm not completely sure this is the right fix, It seems right, however... - Using __raw_readl() instead. Is that a generic enough

Re: [RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Michael S. Tsirkin
On Wed, Feb 13, 2013 at 03:28:52PM +, Marc Zyngier wrote: On 13/02/13 15:08, Pawel Moll wrote: On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote: Using readl() to read the magic value and then memcmp() to check it fails on BE, as bytes will be the other way around (by virtue of

Re: [RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Marc Zyngier
On 13/02/13 16:53, Michael S. Tsirkin wrote: On Wed, Feb 13, 2013 at 03:28:52PM +, Marc Zyngier wrote: On 13/02/13 15:08, Pawel Moll wrote: On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote: Using readl() to read the magic value and then memcmp() to check it fails on BE, as bytes will

Re: [PATCH 1/6] virtio_host: host-side implementation of virtio rings.

2013-02-13 Thread Rusty Russell
Sjur Brændeland sjurb...@gmail.com writes: Hi Rusty, On Mon, Feb 4, 2013 at 10:44 PM, Rusty Russell ru...@rustcorp.com.au wrote: Sjur Brændeland sjurb...@gmail.com writes: ... I guess my vringh related stuff should go into your tree together with your vringh patches... Would you be willing

Re: [PATCH] virtio_console: Initialize guest_connected=true for rproc_serial

2013-02-13 Thread Rusty Russell
sjur.brandel...@stericsson.com writes: From: Sjur Brændeland sjur.brandel...@stericsson.com When rproc_serial is initialized, guest_connected should be set to true. We can then revert the extra checks introduced in commit: virtio_console: Let unconnected rproc device receive data.

Re: [PATCH 1/1] VSOCK: Introduce VM Sockets

2013-02-13 Thread Andy King
+ if (protocol) + return -EPROTONOSUPPORT; + IMO protocol == PF_VSOCK should not get rejected here. Agreed, let me fix that too. Thanks! - Andy ___ Virtualization mailing list Virtualization@lists.linux-foundation.org

Re: [PATCH 1/1] VSOCK: Introduce VM Sockets

2013-02-13 Thread Andy King
I've seen you have a notify_ops in the vmci bits. Do you have different notify ops depending on socket type or something? Does it make sense to move the notify ops ptr into struct vsock_sock maybe? The notify stuff only applies to STREAMs. However, we have two different notify impls, one

Re: [RFC PATCH] virt_mmio: fix signature checking for BE guests

2013-02-13 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Wed, Feb 13, 2013 at 03:28:52PM +, Marc Zyngier wrote: On 13/02/13 15:08, Pawel Moll wrote: On Wed, 2013-02-13 at 14:25 +, Marc Zyngier wrote: Using readl() to read the magic value and then memcmp() to check it fails on BE, as bytes

Re: [PATCH 0/9] virtio: new API for addition of buffers, scatterlist changes

2013-02-13 Thread Rusty Russell
Paolo Bonzini pbonz...@redhat.com writes: This series adds a different set of APIs for adding a buffer to a virtqueue. The new API lets you pass the buffers piecewise, wrapping multiple calls to virtqueue_add_sg between virtqueue_start_buf and virtqueue_end_buf. Letting drivers call

Re: linux-next: Tree for Feb 13 (virtio_console)

2013-02-13 Thread Rusty Russell
Randy Dunlap rdun...@infradead.org writes: On 02/13/13 00:35, Stephen Rothwell wrote: Hi all, Changes since 20130212: on i386: drivers/built-in.o: In function `in_intr': virtio_console.c:(.text+0x2dd31): undefined reference to `hvc_poll' virtio_console.c:(.text+0x2dd41): undefined

Re: linux-next: Tree for Feb 13 (virtio_console)

2013-02-13 Thread Stephen Rothwell
Hi Rusty, On Thu, 14 Feb 2013 13:30:37 +1030 Rusty Russell ru...@rustcorp.com.au wrote: This looks like an impossible config. CONFIG_VIRTIO_CONSOLE=y, but CONFIG_HVC_DRIVER isn't set. From drivers/char/Kconfig: config VIRTIO_CONSOLE tristate Virtio console