Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-22 Thread Asias He
On Tue, Apr 23, 2013 at 01:48:51PM +0930, Rusty Russell wrote: > Asias He writes: > > On Mon, Apr 22, 2013 at 04:17:04PM +0300, Michael S. Tsirkin wrote: > >> > > > > > > > +evt = kzalloc(sizeof(*evt), GFP_KERNEL); > >> > > > > > > > >> > > > > > > I think kzalloc not needed here, you init al

Re: [PATCHv2 virtio-next] remoteproc: Add support for host virtio rings (vringh)

2013-04-22 Thread Rusty Russell
Ohad Ben-Cohen writes: > Hi Sjur and Rusty, > Stuff which will be nice to change along these lines: > > - maintain the vrh_callback_t pointer in struct vringh, similarly to > what struct virtqueue does today for callbacks of regular rings > - when kicked, just call vring_interrupt, and let it demu

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-22 Thread Rusty Russell
Asias He writes: > On Mon, Apr 22, 2013 at 04:17:04PM +0300, Michael S. Tsirkin wrote: >> > > > > > > > + evt = kzalloc(sizeof(*evt), GFP_KERNEL); >> > > > > > > >> > > > > > > I think kzalloc not needed here, you init all fields. >> > > > > > >> > > > > > Not really! evt->event.lun[4-7] is

Re: suggesting wording fixes for virtio-spec 0.9.5

2013-04-22 Thread Rusty Russell
Laszlo Ersek writes: > Hi, > > (I'm not subscribed to either list,) > > using the word "descriptor" is misleading in the following sections: Yes, I like the use of 'descriptor chains'. This is a definite improvement. Here's the diff I ended up with (massaged to minimize it). Thanks! Rusty. --

RE: [PATCH 1/2] remoteproc: fix kconfig dependencies for VIRTIO

2013-04-22 Thread Anna, Suman
> On Thu, Apr 18, 2013 at 6:51 PM, Anna, Suman wrote: > >> > >> On Tue, Apr 16, 2013 at 8:25 PM, Suman Anna wrote: > >> > remoteproc configuration selects VIRTIO, but VIRTIO is now > >> > subordinate to VIRTUALIZATION. VIRTUALIZATION has to be selected as > >> > well to honor the kconfig menu hie

2013 Linux Plumbers ACPI/PM, PCI Microconference proposal call for participaton

2013-04-22 Thread Myron Stowe
All: We would like to hold a combined ACPI/PM, PCI focused microconference as part of this year's Linux Plumbers conference but first we need to show that there is enough interest and material that needs covered. There is a lot of activity in these subsystems so please respond by submitting prese

2013 Linux Plumbers ACPI/PM, PCI Microconference proposal call for participaton

2013-04-22 Thread Myron Stowe
All: We would like to hold a combined ACPI/PM, PCI focused microconference as part of this year's Linux Plumbers conference but first we need to show that there is enough interest and material that needs covered. There is a lot of activity in these subsystems so please respond by submitting prese

RE: [PATCH 1/2] remoteproc: fix kconfig dependencies for VIRTIO

2013-04-22 Thread Anna, Suman
> > On Tue, Apr 16, 2013 at 8:25 PM, Suman Anna wrote: > > remoteproc configuration selects VIRTIO, but VIRTIO is now subordinate > > to VIRTUALIZATION. VIRTUALIZATION has to be selected as well to honor > > the kconfig menu hierarchy and fix the dependency warnings. > > Thanks Suman. Is this st

[PATCH 2/2] rpmsg: fix kconfig dependencies for VIRTIO

2013-04-22 Thread Suman Anna
rpmsg configuration selects VIRTIO, but VIRTIO is now subordinate to VIRTUALIZATION. RPMSG is currently selected by OMAP_REMOTEPROC, and the dependency warning is not seen with the fix in remoteproc config, but the kconfig menu hierarchy dependency has to be honored nevertheless. warning: (VIRTIO_

[PATCH 1/2] remoteproc: fix kconfig dependencies for VIRTIO

2013-04-22 Thread Suman Anna
remoteproc configuration selects VIRTIO, but VIRTIO is now subordinate to VIRTUALIZATION. VIRTUALIZATION has to be selected as well to honor the kconfig menu hierarchy and fix the dependency warnings. warning: (VIRTIO_PCI && VIRTIO_MMIO && REMOTEPROC && RPMSG) selects VIRTIO which has unmet direc

[PATCH 0/2] remoteproc/rpmsg: fix kconfig dependencies for VIRTIO

2013-04-22 Thread Suman Anna
Hi, This fixes the Kconfig dependency warnings for VIRTIO when remoteproc and/or rpmsg are enabled. I have intentionally split the change into two patches, based on testing by enabling STE-MODEM-RPROC and OMAP_REMOTEPROC separately. The former selects just REMOTEPROC, while the latter selects both

suggesting wording fixes for virtio-spec 0.9.5

2013-04-22 Thread Laszlo Ersek
Hi, (I'm not subscribed to either list,) using the word "descriptor" is misleading in the following sections: 2.4.1.2 Updating The Available Ring [...] However, in general we can add many descriptors before we update the idx field (at which point they become visible to the device), s

Re: [PATCH v7 2/3] tcm_vhost: Add helper to check if endpoint is setup

2013-04-22 Thread Michael S. Tsirkin
On Mon, Apr 22, 2013 at 11:00:19PM +0800, Asias He wrote: > On Mon, Apr 22, 2013 at 04:28:07PM +0300, Michael S. Tsirkin wrote: > > On Mon, Apr 22, 2013 at 04:53:27PM +0800, Asias He wrote: > > > On Thu, Apr 18, 2013 at 10:38:23AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 18, 2013 at 04:

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-22 Thread Asias He
On Mon, Apr 22, 2013 at 04:17:04PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 22, 2013 at 05:20:24PM +0800, Asias He wrote: > > On Sat, Apr 20, 2013 at 10:01:31PM +0300, Michael S. Tsirkin wrote: > > > On Fri, Apr 19, 2013 at 10:34:10AM +0800, Asias He wrote: > > > > On Thu, Apr 18, 2013 at 11:

Re: [PATCH v7 2/3] tcm_vhost: Add helper to check if endpoint is setup

2013-04-22 Thread Asias He
On Mon, Apr 22, 2013 at 04:28:07PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 22, 2013 at 04:53:27PM +0800, Asias He wrote: > > On Thu, Apr 18, 2013 at 10:38:23AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 18, 2013 at 04:32:30PM +0800, Asias He wrote: > > > > On Thu, Apr 18, 2013 at 10:

Re: [PATCH v7 2/3] tcm_vhost: Add helper to check if endpoint is setup

2013-04-22 Thread Michael S. Tsirkin
On Mon, Apr 22, 2013 at 04:53:27PM +0800, Asias He wrote: > On Thu, Apr 18, 2013 at 10:38:23AM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 18, 2013 at 04:32:30PM +0800, Asias He wrote: > > > On Thu, Apr 18, 2013 at 10:09:53AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 18, 2013 at 09:

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-22 Thread Michael S. Tsirkin
On Mon, Apr 22, 2013 at 05:20:24PM +0800, Asias He wrote: > On Sat, Apr 20, 2013 at 10:01:31PM +0300, Michael S. Tsirkin wrote: > > On Fri, Apr 19, 2013 at 10:34:10AM +0800, Asias He wrote: > > > On Thu, Apr 18, 2013 at 11:21:54AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 18, 2013 at 04:

Re: [PATCHv2 virtio-next] remoteproc: Add support for host virtio rings (vringh)

2013-04-22 Thread Ohad Ben-Cohen
Hi Sjur and Rusty, On Wed, Apr 10, 2013 at 12:39 AM, Sjur Brændeland wrote: > Implement the vringh callback functions in order > to manage host virito rings and handle kicks. > This allows virtio device to request host-virtio-rings. > > Signed-off-by: Sjur Brændeland Thanks for pushing this. I

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-22 Thread Asias He
On Sat, Apr 20, 2013 at 10:01:31PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 19, 2013 at 10:34:10AM +0800, Asias He wrote: > > On Thu, Apr 18, 2013 at 11:21:54AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 18, 2013 at 04:59:08PM +0800, Asias He wrote: > > > > On Thu, Apr 18, 2013 at 10:

Re: [PATCH v7 2/3] tcm_vhost: Add helper to check if endpoint is setup

2013-04-22 Thread Asias He
On Thu, Apr 18, 2013 at 10:38:23AM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 18, 2013 at 04:32:30PM +0800, Asias He wrote: > > On Thu, Apr 18, 2013 at 10:09:53AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 18, 2013 at 09:05:53AM +0800, Asias He wrote: > > > > Signed-off-by: Asias He >