Re: [PATCH] vhost-scsi: Enable VIRTIO_RING_F_EVENT_IDX

2013-05-07 Thread Paolo Bonzini
Il 07/05/2013 08:51, Asias He ha scritto: > It is disabled as a workaround. Now userspace bits works fine with it. > So, let's enable it. > > Signed-off-by: Asias He > --- > drivers/vhost/scsi.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/vhost/scsi.c

[PULL] vhost: more fixes for 3.10

2013-05-07 Thread Michael S. Tsirkin
I didn't do any back-merging tricks this time, as a result this is behind master by quite a lot. But I did a test merge and it came out correctly, so this shouldn't be an issue. The following changes since commit 181c04a357bb791587c55a99362c2fdde2c64f18: vhost_scsi: module rename (2013-05-02 13

Re: [PATCH 0/4] vhost private_data rcu removal

2013-05-07 Thread Michael S. Tsirkin
On Tue, May 07, 2013 at 02:54:32PM +0800, Asias He wrote: > Asias He (4): > vhost-net: Always access vq->private_data under vq mutex > vhost-test: Always access vq->private_data under vq mutex > vhost-scsi: Always access vq->private_data under vq mutex > vhost: Remove custom vhost rcu usage

Re: [PATCH] vhost-test: Make vhost/test.c work

2013-05-07 Thread Michael S. Tsirkin
On Tue, May 07, 2013 at 02:52:45PM +0800, Asias He wrote: > Fix it by: > 1) switching to use the new device specific fields per vq > 2) not including vhost.c, instead make vhost-test.ko depend on vhost.ko. Please split this up. 1. make test work for 3.10 2. make test work for 3.11 thanks! > ---

Re: [PATCH 0/3] vhost cleanups and separate module

2013-05-07 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Mon, May 06, 2013 at 03:41:36PM +0930, Rusty Russell wrote: >> Asias He writes: >> > Asias He (3): >> > vhost: Remove vhost_enable_zcopy in vhost.h >> > vhost: Move VHOST_NET_FEATURES to net.c >> > vhost: Make vhost a separate module >> >> I like these cle

Re: [PATCH 0/3] vhost cleanups and separate module

2013-05-07 Thread Michael S. Tsirkin
On Tue, May 07, 2013 at 02:13:44PM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > On Mon, May 06, 2013 at 03:41:36PM +0930, Rusty Russell wrote: > >> Asias He writes: > >> > Asias He (3): > >> > vhost: Remove vhost_enable_zcopy in vhost.h > >> > vhost: Move VHOST_NET_FEATURES

[PATCH] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Asias He
In commit a0f155e96 'KVM: Initialize irqfd from kvm_init()', when kvm_init() is called the second time (e.g kvm-amd.ko and kvm-intel.ko), kvm_arch_init() will fail with -EEXIST, then kvm_irqfd_exit() will be called on the error handling path. This way, the kvm_irqfd system will not be ready. This

Re: [PATCH] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Michael S. Tsirkin
On Tue, May 07, 2013 at 10:54:16PM +0800, Asias He wrote: > In commit a0f155e96 'KVM: Initialize irqfd from kvm_init()', when > kvm_init() is called the second time (e.g kvm-amd.ko and kvm-intel.ko), > kvm_arch_init() will fail with -EEXIST, Wow. Is this intentional? > then kvm_irqfd_exit() will

Re: [PATCH] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Asias He
On Tue, May 07, 2013 at 05:59:38PM +0300, Michael S. Tsirkin wrote: > On Tue, May 07, 2013 at 10:54:16PM +0800, Asias He wrote: > > In commit a0f155e96 'KVM: Initialize irqfd from kvm_init()', when > > kvm_init() is called the second time (e.g kvm-amd.ko and kvm-intel.ko), > > kvm_arch_init() will

Re: [PATCH] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Michael S. Tsirkin
On Tue, May 07, 2013 at 11:05:12PM +0800, Asias He wrote: > On Tue, May 07, 2013 at 05:59:38PM +0300, Michael S. Tsirkin wrote: > > On Tue, May 07, 2013 at 10:54:16PM +0800, Asias He wrote: > > > In commit a0f155e96 'KVM: Initialize irqfd from kvm_init()', when > > > kvm_init() is called the second

Re: [PATCH] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Gleb Natapov
On Tue, May 07, 2013 at 06:11:33PM +0300, Michael S. Tsirkin wrote: > On Tue, May 07, 2013 at 11:05:12PM +0800, Asias He wrote: > > On Tue, May 07, 2013 at 05:59:38PM +0300, Michael S. Tsirkin wrote: > > > On Tue, May 07, 2013 at 10:54:16PM +0800, Asias He wrote: > > > > In commit a0f155e96 'KVM: I

Re: [PATCH] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Michael S. Tsirkin
On Tue, May 07, 2013 at 06:16:09PM +0300, Gleb Natapov wrote: > On Tue, May 07, 2013 at 06:11:33PM +0300, Michael S. Tsirkin wrote: > > On Tue, May 07, 2013 at 11:05:12PM +0800, Asias He wrote: > > > On Tue, May 07, 2013 at 05:59:38PM +0300, Michael S. Tsirkin wrote: > > > > On Tue, May 07, 2013 at

Re: [PATCH] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Gleb Natapov
On Tue, May 07, 2013 at 06:24:48PM +0300, Michael S. Tsirkin wrote: > On Tue, May 07, 2013 at 06:16:09PM +0300, Gleb Natapov wrote: > > On Tue, May 07, 2013 at 06:11:33PM +0300, Michael S. Tsirkin wrote: > > > On Tue, May 07, 2013 at 11:05:12PM +0800, Asias He wrote: > > > > On Tue, May 07, 2013 at

Re: [PATCH] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Cornelia Huck
On Tue, 7 May 2013 22:54:16 +0800 Asias He wrote: > In commit a0f155e96 'KVM: Initialize irqfd from kvm_init()', when > kvm_init() is called the second time (e.g kvm-amd.ko and kvm-intel.ko), > kvm_arch_init() will fail with -EEXIST, then kvm_irqfd_exit() will be > called on the error handling p

Re: [PATCH] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Michael S. Tsirkin
On Tue, May 07, 2013 at 05:54:20PM +0200, Cornelia Huck wrote: > On Tue, 7 May 2013 22:54:16 +0800 > Asias He wrote: > > > In commit a0f155e96 'KVM: Initialize irqfd from kvm_init()', when > > kvm_init() is called the second time (e.g kvm-amd.ko and kvm-intel.ko), > > kvm_arch_init() will fail w

[PATCH v2] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Asias He
In commit a0f155e96 'KVM: Initialize irqfd from kvm_init()', when kvm_init() is called the second time (e.g kvm-amd.ko and kvm-intel.ko), kvm_arch_init() will fail with -EEXIST, then kvm_irqfd_exit() will be called on the error handling path. This way, the kvm_irqfd system will not be ready. This

Re: [PATCH v2] KVM: Fix kvm_irqfd_init initialization

2013-05-07 Thread Cornelia Huck
On Wed, 8 May 2013 10:57:29 +0800 Asias He wrote: > In commit a0f155e96 'KVM: Initialize irqfd from kvm_init()', when > kvm_init() is called the second time (e.g kvm-amd.ko and kvm-intel.ko), > kvm_arch_init() will fail with -EEXIST, then kvm_irqfd_exit() will be > called on the error handling p