Re: [PATCH] virtio-net: Reporting traffic queue distribution statistics through ethtool

2013-05-21 Thread Michael S. Tsirkin
On Tue, May 21, 2013 at 01:11:28PM +0800, Jason Wang wrote: > On 05/21/2013 09:26 AM, Narasimhan, Sriram wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Monday, May 20, 2013 2:59 AM > > To: Narasimhan, Sriram > > Cc: ru...@rustcorp.com.au;

Re: [PATCH] virtio-spec: tweak wording for console control vq

2013-05-21 Thread Rusty Russell
"Michael S. Tsirkin" writes: > control vq is only used if feature bit is > negotiated - it's not enough that device supports > it. Clarify this in the spec. Thanks, applied. Cheers, Rusty. > Signed-off-by: Michael S. Tsirkin > --- > virtio-spec.lyx | 9 +++-- > 1 file changed, 7 insertion

Re: [PATCH 1/2 V4] virtio-spec: dynamic network offloads configuration

2013-05-21 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Mon, May 20, 2013 at 03:43:51PM +0200, Paolo Bonzini wrote: >> Is there a story behind skipping virtio-net feature bits 2..4? >> >> Paolo > > Bits 3-4 now :) > I'm curious too. Not a good one :) The year is 2007. virtio_net was the posterchild of free expressi

[PATCH] virtio_net: enable napi after enabling new queues

2013-05-21 Thread Jason Wang
Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx queues which are being used) forgets to enable napi for new enabled queues which breaks the multiqueue receiving. This patch fixes it. Cc: Sasha Levin Signed-off-by: Jason Wang --- drivers/net/virtio_net.c |4 +++- 1

Re: [PATCH] virtio_net: enable napi after enabling new queues

2013-05-21 Thread Jason Wang
On 05/22/2013 01:22 PM, Jason Wang wrote: > Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx > queues which are being used) forgets to enable napi for new enabled queues > which > breaks the multiqueue receiving. This patch fixes it. > > Cc: Sasha Levin > Signed-off-by: J

[PATCH V2] virtio_net: enable napi for all possible queues during open

2013-05-21 Thread Jason Wang
Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx queues which are being used) only does the napi enabling during open for curr_queue_pairs. This will break multiqueue receiving since napi of new queues were still disabled after changing the number of queues. This patch fix