Re: [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready

2013-10-17 Thread Rusty Russell
David Miller writes: > From: Rusty Russell > Date: Fri, 18 Oct 2013 11:30:15 +1030 > >> Asking people to express 'CC: stable' in words is error-prone; if Dave >> wants to filter it, he's quite capable. > > Filtering it one time is one thing. > > Potentially acting on that filter 100 or so times a

Re: [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready

2013-10-17 Thread David Miller
From: Rusty Russell Date: Fri, 18 Oct 2013 11:30:15 +1030 > Asking people to express 'CC: stable' in words is error-prone; if Dave > wants to filter it, he's quite capable. Filtering it one time is one thing. Potentially acting on that filter 100 or so times a day... That's completely another.

Re: [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready

2013-10-17 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Thu, Oct 17, 2013 at 09:57:41AM +1030, Rusty Russell wrote: >> Jason Wang writes: >> > We're trying to re-configure the affinity unconditionally in cpu hotplug >> > callback. This may lead the issue during resuming from s3/s4 since >> > >> > - virt queues haven't

Re: [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready

2013-10-17 Thread David Miller
From: Jason Wang Date: Tue, 15 Oct 2013 11:18:58 +0800 > We're trying to re-configure the affinity unconditionally in cpu hotplug > callback. This may lead the issue during resuming from s3/s4 since > > - virt queues haven't been allocated at that time. > - it's unnecessary since thaw method wil

Re: [PATCH net V2 2/2] virtio-net: refill only when device is up during setting queues

2013-10-17 Thread David Miller
From: Jason Wang Date: Tue, 15 Oct 2013 11:18:59 +0800 > We used to schedule the refill work unconditionally after changing the > number of queues. This may lead an issue if the device is not > up. Since we only try to cancel the work in ndo_stop(), this may cause > the refill work still work aft