Re: [PATCH net-next 1/3] virtio_net: set multicast filter list to host

2013-12-10 Thread David Miller
From: Stephen Hemminger Date: Mon, 9 Dec 2013 16:16:32 -0800 > The virtio_net driver never sends the multicast address list to > the host. This is because send command takes a pointer to scatter list > to send but only inserts that one entry into the outgoing scatter list. > > This bug has been

Re: [PATCH net-next 2/3] virtio_net: remove unused parameter to send_command

2013-12-10 Thread David Miller
From: Stephen Hemminger Date: Mon, 9 Dec 2013 16:17:40 -0800 > All the code passes NULL for the last sg list (in). > Simplify by just removing it. > > Signed-off-by: Stephen Hemminger Applied. ___ Virtualization mailing list Virtualization@lists.linu

Re: [PATCH net-next 3/3] virtio_net: spelling fixes

2013-12-10 Thread David Miller
From: Stephen Hemminger Date: Mon, 9 Dec 2013 16:18:45 -0800 > Signed-off-by: Stephen Hemminger Applied. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH net-next 1/3] virtio_net: set multicast filter list to host

2013-12-10 Thread Michael S. Tsirkin
On Tue, Dec 10, 2013 at 05:24:29PM +0200, Michael S. Tsirkin wrote: > On Mon, Dec 09, 2013 at 04:16:32PM -0800, Stephen Hemminger wrote: > > The virtio_net driver never sends the multicast address list to > > the host. This is because send command takes a pointer to scatter list > > to send but onl

Re: [PATCH net-next 1/3] virtio_net: set multicast filter list to host

2013-12-10 Thread Vlad Yasevich
On 12/09/2013 07:16 PM, Stephen Hemminger wrote: > The virtio_net driver never sends the multicast address list to > the host. This is because send command takes a pointer to scatter list > to send but only inserts that one entry into the outgoing scatter list. > > This bug has been there since: >

Re: [PATCH net-next 3/3] virtio_net: spelling fixes

2013-12-10 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 04:18:45PM -0800, Stephen Hemminger wrote: > > > Signed-off-by: Stephen Hemminger > Acked-by: Michael S. Tsirkin > --- a/drivers/net/virtio_net.c2013-12-09 16:12:41.409051865 -0800 > +++ b/drivers/net/virtio_net.c2013-12-09 16:12:43.872996856 -0800 >

Re: [PATCH net-next 1/3] virtio_net: set multicast filter list to host

2013-12-10 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 04:16:32PM -0800, Stephen Hemminger wrote: > The virtio_net driver never sends the multicast address list to > the host. This is because send command takes a pointer to scatter list > to send but only inserts that one entry into the outgoing scatter list. > > This bug has b

Re: [PATCH net-next 2/3] virtio_net: remove unused parameter to send_command

2013-12-10 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 04:17:40PM -0800, Stephen Hemminger wrote: > All the code passes NULL for the last sg list (in). > Simplify by just removing it. > > Signed-off-by: Stephen Hemminger When we need it we can re-add it. Acked-by: Michael S. Tsirkin > > --- a/drivers/net/virtio_net.c