Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c

2013-12-16 Thread Josh Triplett
On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote: > Mark the function virtballoon_migratepage() as static in > virtio_balloon.c because it is not used outside this file. > > This eliminates the following warning in virtio_balloon.c: > drivers/virtio/virtio_balloon.c:372:5: warning: n

Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c

2013-12-16 Thread Michael S. Tsirkin
On Mon, Dec 16, 2013 at 06:23:38AM -0800, Josh Triplett wrote: > On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote: > > Mark the function virtballoon_migratepage() as static in > > virtio_balloon.c because it is not used outside this file. > > > > This eliminates the following warning

ICAC2014 CFP: 11th International Conference on Autonomic Computing

2013-12-16 Thread Ming Zhao
CAC 2014 Call for Papers - 11th International Conference on Autonomic Computing June 18-20, 2014 Philadelphia, PA Co-held with the 2015 USENIX Federated Conferences Week (June 17-20, 2014) Sponsored by USENIX, the Advanced Computing Systems Association https://www.usenix.

Re: [PATCH v3 [resend] 14/18] smp, x86, xen: kill SMP single function call interrupt

2013-12-16 Thread Konrad Rzeszutek Wilk
On Mon, Dec 16, 2013 at 04:24:41AM +, Liu, Jinsong wrote: > Konrad Rzeszutek Wilk wrote: > > On Mon, Dec 16, 2013 at 12:36:36AM +0800, Jiang Liu wrote: > >> Commit 9a46ad6d6df3b54 "smp: make smp_call_function_many() use logic > >> similar to smp_call_function_single()" has unified the way to ha

[PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c

2013-12-16 Thread Rashika Kheria
Mark the function virtballoon_migratepage() as static in virtio_balloon.c because it is not used outside this file. This eliminates the following warning in virtio_balloon.c: drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes]

[PATCH net-next 2/3] virtio-net: use per-receive queue page frag alloc for mergeable bufs

2013-12-16 Thread Michael Dalton
The virtio-net driver currently uses netdev_alloc_frag() for GFP_ATOMIC mergeable rx buffer allocations. This commit migrates virtio-net to use per-receive queue page frags for GFP_ATOMIC allocation. This change unifies mergeable rx buffer memory allocation, which now will use skb_refill_frag() for

[PATCH net-next 1/3] net: allow > 0 order atomic page alloc in skb_page_frag_refill

2013-12-16 Thread Michael Dalton
skb_page_frag_refill currently permits only order-0 page allocs unless GFP_WAIT is used. Change skb_page_frag_refill to attempt higher-order page allocations whether or not GFP_WAIT is used. If memory cannot be allocated, the allocator will fall back to successively smaller page allocs (down to ord

[PATCH net-next 3/3] net: auto-tune mergeable rx buffer size for improved performance

2013-12-16 Thread Michael Dalton
Commit 2613af0ed18a ("virtio_net: migrate mergeable rx buffers to page frag allocators") changed the mergeable receive buffer size from PAGE_SIZE to MTU-size, introducing a single-stream regression for benchmarks with large average packet size. There is no single optimal buffer size for all workloa

Re: [PATCH v4 RFC 0/3] virtio: add 'device_lost' to virtio_device

2013-12-16 Thread Rusty Russell
Heinz Graalfs writes: > Hi, here is my v4 patch-set update to the v3 RFC submitted on Nov 27th. > > When an active virtio block device is hot-unplugged from a KVM guest, > affected guest user applications are not aware of any errors that occur > due to the lost device. This patch-set adds code to

Re: [PATCH] virtio-scsi: Fix hotcpu_notifier use-after-free with virtscsi_freeze

2013-12-16 Thread Rusty Russell
Jason Wang writes: > On 10/28/2013 04:01 PM, Asias He wrote: >> vqs are freed in virtscsi_freeze but the hotcpu_notifier is not >> unregistered. We will have a use-after-free usage when the notifier >> callback is called after virtscsi_freeze. >> >> Signed-off-by: Asias He Please include a Fixes

Re: [PATCH] virtio-scsi: Fix hotcpu_notifier use-after-free with virtscsi_freeze

2013-12-16 Thread Jason Wang
On 12/17/2013 11:09 AM, Rusty Russell wrote: > Jason Wang writes: >> > On 10/28/2013 04:01 PM, Asias He wrote: >>> >> vqs are freed in virtscsi_freeze but the hotcpu_notifier is not >>> >> unregistered. We will have a use-after-free usage when the notifier >>> >> callback is called after virtscsi_

Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c

2013-12-16 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Mon, Dec 16, 2013 at 06:23:38AM -0800, Josh Triplett wrote: >> On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote: >> > Mark the function virtballoon_migratepage() as static in >> > virtio_balloon.c because it is not used outside this file. >> > >> >

[PATCH V2] virtio-scsi: Fix hotcpu_notifier use-after-free with virtscsi_freeze

2013-12-16 Thread Jason Wang
From: Asias He vqs are freed in virtscsi_freeze but the hotcpu_notifier is not unregistered. We will have a use-after-free usage when the notifier callback is called after virtscsi_freeze. Fixes: 285e71ea6f3583a85e27cb2b9a7d8c35d4c0d558 ("virtio-scsi: reset virtqueue affinity when doing cpu hotp