Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-08-31 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 01:41:54PM +0800, Amos Kong wrote: > One VM only has 128 msix interrupt, virtio-config interrupt > has less workload. This patch shares one normal interrupt normal == INT#x? Please don't call it normal. The proper name is "legacy INT#x". So you are trying to use legacy INT

[PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-08-31 Thread Amos Kong
One VM only has 128 msix interrupt, virtio-config interrupt has less workload. This patch shares one normal interrupt for configuration between virtio devices. Signed-off-by: Amos Kong --- drivers/virtio/virtio_pci.c | 41 - 1 file changed, 16 insertions(+

Re: [PATCH 1/3] virtio_ring: Remove sg_next indirection

2014-08-31 Thread Andy Lutomirski
On Sun, Aug 31, 2014 at 5:58 PM, Rusty Russell wrote: > Andy Lutomirski writes: >> The only unusual thing about virtio's use of scatterlists is that >> two of the APIs accept scatterlists that might not be terminated. >> Using function pointers to handle this case is overkill; for_each_sg >> can

Re: [PATCH 1/3] virtio_ring: Remove sg_next indirection

2014-08-31 Thread Rusty Russell
Andy Lutomirski writes: > The only unusual thing about virtio's use of scatterlists is that > two of the APIs accept scatterlists that might not be terminated. > Using function pointers to handle this case is overkill; for_each_sg > can do it. > > There's a small subtlely here: for_each_sg assumes