[PATCH] virtio-pci: also bind to Amazon PCI vendor ID

2014-09-14 Thread Anthony Liguori
From: Anthony Liguori See https://issues.oasis-open.org/browse/VIRTIO-16 although it was prematurely closed. Red Hat has non-redistributable Windows drivers and Microsoft will not allow anyone else to WHQL certify drivers using that vendor ID. That makes it impossible to use virtio drivers with

[PATCH] virtio_pci: properly clean up MSI-X state when initialization fails

2014-09-14 Thread Anthony Liguori
From: Anthony Liguori If MSI-X initialization fails after setting msix_enabled = 1, then the device is left in an inconsistent state. This would normally only happen if there was a bug in the device emulation but it still should be handled correctly. Cc: Matt Wilson Cc: Rusty Russell Cc: Mich

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Michael S. Tsirkin
On Sun, Sep 14, 2014 at 09:11:45AM -0700, Peter Maydell wrote: > On 14 September 2014 08:09, Michael S. Tsirkin wrote: > > On Sun, Sep 14, 2014 at 07:32:21AM -0700, Peter Maydell wrote: > >> Who owns the "master" copy of the header and commits > >> to making sure it builds on other things than Lin

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Peter Maydell
On 14 September 2014 08:09, Michael S. Tsirkin wrote: > On Sun, Sep 14, 2014 at 07:32:21AM -0700, Peter Maydell wrote: >> Who owns the "master" copy of the header and commits >> to making sure it builds on other things than Linux+gcc >> in that case? > For most of virtio neither linux nor QEMU ar

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Michael S. Tsirkin
On Sun, Sep 14, 2014 at 07:32:21AM -0700, Peter Maydell wrote: > On 14 September 2014 07:11, Michael S. Tsirkin wrote: > > On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: > >> On 14 September 2014 06:46, Michael S. Tsirkin wrote: > >> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in Q

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Peter Maydell
On 14 September 2014 07:11, Michael S. Tsirkin wrote: > On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: >> On 14 September 2014 06:46, Michael S. Tsirkin wrote: >> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. >> > You have to stick it in a C file though, so it >> > won't be

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Michael S. Tsirkin
On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: > On 14 September 2014 06:46, Michael S. Tsirkin wrote: > > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > > You have to stick it in a C file though, so it > > won't be visible in this patch. > > Why do you think that? We have se

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Peter Maydell
On 14 September 2014 06:46, Michael S. Tsirkin wrote: > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > You have to stick it in a C file though, so it > won't be visible in this patch. Why do you think that? We have several header files which use QEMU_BUILD_BUG_ON and I don't see any reason w

Re: [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-14 Thread Michael S. Tsirkin
On Fri, Sep 12, 2014 at 12:44:56PM +0200, Gerd Hoffmann wrote: > Hi, > > > > @@ -0,0 +1,158 @@ > > > +#ifndef VIRTGPU_HW_H > > > +#define VIRTGPU_HW_H > > > > Non-trivial file, deserves a copyright and license notice. > > Added. Pls remember to make it consistent with other virtio headers, wh

Re: [virtio-dev] Re: [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-14 Thread Dave Airlie
On 14 September 2014 19:16, Michael S. Tsirkin wrote: > On Thu, Sep 11, 2014 at 05:09:33PM +0200, Gerd Hoffmann wrote: >> Signed-off-by: Gerd Hoffmann >> --- >> docs/specs/virtio-gpu.txt | 165 >> ++ >> 1 file changed, 165 insertions(+) >> create mod

Re: [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-14 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 05:09:33PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > docs/specs/virtio-gpu.txt | 165 > ++ > 1 file changed, 165 insertions(+) > create mode 100644 docs/specs/virtio-gpu.txt Please don't put this hardw

Re: [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2014-09-14 Thread Michael S. Tsirkin
On Fri, Sep 05, 2014 at 12:01:33PM +0930, Rusty Russell wrote: > Andy Lutomirski writes: > > On Sep 2, 2014 11:53 PM, "Rusty Russell" wrote: > >> > >> Andy Lutomirski writes: > >> > There really are virtio devices that are pieces of silicon and not > >> > figments of a hypervisor's imagination [