Re: [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-27 Thread Michael S. Tsirkin
On Fri, Oct 24, 2014 at 10:38:39AM +0200, Cornelia Huck wrote: > On Fri, 24 Oct 2014 00:42:20 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Oct 07, 2014 at 04:39:56PM +0200, Cornelia Huck wrote: > > > This patchset aims to get us some way to implement virtio-1 compliant > > > and transitional

Re: [PATCH RFC 4/4] virtio_net: bigger header when VERSION_1 is set

2014-10-27 Thread Rusty Russell
"Michael S. Tsirkin" writes: > With VERSION_1 virtio_net uses same header size > whether mergeable buffers are enabled or not. > > Signed-off-by: Michael S. Tsirkin These two are great too, thanks: Acked-by: Rusty Russell Cheers, Rusty. > --- > drivers/net/virtio_net.c | 3 ++- > 1 file cha

Re: [PATCH] virtio_blk: fix race at module removal

2014-10-27 Thread Rusty Russell
Ming Lei writes: > On Fri, Oct 24, 2014 at 12:12 AM, Michael S. Tsirkin wrote: >> If a device appears while module is being removed, >> driver will get a callback after we've given up >> on the major number. >> >> In theory this means this major number can get reused >> by something else, resulti

Re: [PATCH RFC 2/4] virtio_net: get rid of virtio_net_hdr/skb_vnet_hdr

2014-10-27 Thread Rusty Russell
"Michael S. Tsirkin" writes: > virtio 1.0 doesn't use virtio_net_hdr anymore, and in fact, it's not > really useful since virtio_net_hdr_mrg_rxbuf includes that as the first > field anyway. > > Let's drop it, precalculate header len and store within vi instead. > > This way we can also remove stru

Re: [PATCH RFC 1/4] virtio_net: pass vi around

2014-10-27 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Too many places poke at [rs]q->vq->vdev->priv just to get > the the vi structure. Let's just pass the pointer around: seems > cleaner, and might even be faster. Agreed, it's neater. Acked-by: Rusty Russell Thanks, Rusty. > > Signed-off-by: Michael S. Tsirkin >

Re: [PATCH v12 09/11] pvqspinlock, x86: Add para-virtualization support

2014-10-27 Thread Waiman Long
On 10/27/2014 02:04 PM, Peter Zijlstra wrote: On Mon, Oct 27, 2014 at 01:38:20PM -0400, Waiman Long wrote: On 10/24/2014 04:54 AM, Peter Zijlstra wrote: On Thu, Oct 16, 2014 at 02:10:38PM -0400, Waiman Long wrote: Since enabling paravirt spinlock will disable unlock function inlining, a jump

Re: [PATCH v12 09/11] pvqspinlock, x86: Add para-virtualization support

2014-10-27 Thread Waiman Long
On 10/27/2014 02:02 PM, Konrad Rzeszutek Wilk wrote: On Mon, Oct 27, 2014 at 01:38:20PM -0400, Waiman Long wrote: On 10/24/2014 04:54 AM, Peter Zijlstra wrote: On Thu, Oct 16, 2014 at 02:10:38PM -0400, Waiman Long wrote: Since enabling paravirt spinlock will disable unlock function inlining,

Re: [PATCH v12 09/11] pvqspinlock, x86: Add para-virtualization support

2014-10-27 Thread Waiman Long
On 10/27/2014 01:27 PM, Peter Zijlstra wrote: On Mon, Oct 27, 2014 at 01:15:53PM -0400, Waiman Long wrote: On 10/24/2014 06:04 PM, Peter Zijlstra wrote: On Fri, Oct 24, 2014 at 04:53:27PM -0400, Waiman Long wrote: The additional register pressure may just cause a few more register moves which

Re: [PATCH v12 09/11] pvqspinlock, x86: Add para-virtualization support

2014-10-27 Thread Peter Zijlstra
On Mon, Oct 27, 2014 at 01:38:20PM -0400, Waiman Long wrote: > On 10/24/2014 04:54 AM, Peter Zijlstra wrote: > >On Thu, Oct 16, 2014 at 02:10:38PM -0400, Waiman Long wrote: > > > >>Since enabling paravirt spinlock will disable unlock function inlining, > >>a jump label can be added to the unlock fu

Re: [PATCH v12 09/11] pvqspinlock, x86: Add para-virtualization support

2014-10-27 Thread Konrad Rzeszutek Wilk
On Mon, Oct 27, 2014 at 01:38:20PM -0400, Waiman Long wrote: > On 10/24/2014 04:54 AM, Peter Zijlstra wrote: > >On Thu, Oct 16, 2014 at 02:10:38PM -0400, Waiman Long wrote: > > > >>Since enabling paravirt spinlock will disable unlock function inlining, > >>a jump label can be added to the unlock fu

Re: [PATCH v12 00/11] qspinlock: a 4-byte queue spinlock with PV support

2014-10-27 Thread Waiman Long
On 10/24/2014 04:57 AM, Peter Zijlstra wrote: On Thu, Oct 16, 2014 at 02:10:29PM -0400, Waiman Long wrote: v11->v12: - Based on PeterZ's version of the qspinlock patch (https://lkml.org/lkml/2014/6/15/63). - Incorporated many of the review comments from Konrad Wilk and Paolo Bonzini.

Re: [PATCH v12 09/11] pvqspinlock, x86: Add para-virtualization support

2014-10-27 Thread Waiman Long
On 10/24/2014 04:54 AM, Peter Zijlstra wrote: On Thu, Oct 16, 2014 at 02:10:38PM -0400, Waiman Long wrote: Since enabling paravirt spinlock will disable unlock function inlining, a jump label can be added to the unlock function without adding patch sites all over the kernel. But you don't have

Re: [PATCH v12 09/11] pvqspinlock, x86: Add para-virtualization support

2014-10-27 Thread Peter Zijlstra
On Mon, Oct 27, 2014 at 01:15:53PM -0400, Waiman Long wrote: > On 10/24/2014 06:04 PM, Peter Zijlstra wrote: > >On Fri, Oct 24, 2014 at 04:53:27PM -0400, Waiman Long wrote: > >>The additional register pressure may just cause a few more register moves > >>which should be negligible in the overall pe

Re: [PATCH v12 09/11] pvqspinlock, x86: Add para-virtualization support

2014-10-27 Thread Waiman Long
On 10/24/2014 06:04 PM, Peter Zijlstra wrote: On Fri, Oct 24, 2014 at 04:53:27PM -0400, Waiman Long wrote: The additional register pressure may just cause a few more register moves which should be negligible in the overall performance . The additional icache pressure, however, may have some impa

Re: [Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-10-27 Thread Li Liu
On 2014/10/27 17:37, Peter Maydell wrote: > On 25 October 2014 09:24, john.liuli wrote: >> To get the interrupt reason to support such VIRTIO_NET_F_STATUS >> features I add a new register offset VIRTIO_MMIO_ISRMEM which >> will help to establish a shared memory region between qemu and >> virtio-

Re: [RFC PATCH 2/2] Assign a new irq handler while irqfd enabled

2014-10-27 Thread Li Liu
On 2014/10/26 19:56, Michael S. Tsirkin wrote: > On Sat, Oct 25, 2014 at 04:24:54PM +0800, john.liuli wrote: >> From: Li Liu >> >> This irq handler will get the interrupt reason from a >> shared memory. And will be assigned only while irqfd >> enabled. >> >> Signed-off-by: Li Liu >> --- >> dri

Re: [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-10-27 Thread Li Liu
On 2014/10/26 19:52, Michael S. Tsirkin wrote: > On Sat, Oct 25, 2014 at 04:24:52PM +0800, john.liuli wrote: >> From: Li Liu >> >> This set of patches try to implemet irqfd support of vhost-net >> based on virtio-mmio. >> >> I had posted a mail to talking about the status of vhost-net >> on kv

[RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-10-27 Thread john.liuli
From: Li Liu This set of patches try to implemet irqfd support of vhost-net based on virtio-mmio. I had posted a mail to talking about the status of vhost-net on kvm-arm refer to http://www.spinics.net/lists/kvm-arm/msg10804.html. Some dependent patches are listed in the mail too. Basically th

[RFC PATCH 2/2] Assign a new irq handler while irqfd enabled

2014-10-27 Thread john.liuli
From: Li Liu This irq handler will get the interrupt reason from a shared memory. And will be assigned only while irqfd enabled. Signed-off-by: Li Liu --- drivers/virtio/virtio_mmio.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/driv

[RFC PATCH 1/2] Add a new register offset let interrupt reason available

2014-10-27 Thread john.liuli
From: Li Liu Add a new register offset VIRTIO_MMIO_ISRMEM which help to estblish a shared memory region between virtio-mmio driver and qemu with two purposes: 1.Guest virtio-mmio driver can get the interrupt reason. 2.Check irqfd enabled or not to register different irq handler. Signed-off-by:

Re: [PATCH v12 09/11] pvqspinlock, x86: Add para-virtualization support

2014-10-27 Thread Mike Galbraith
On Sat, 2014-10-25 at 00:04 +0200, Peter Zijlstra wrote: > On Fri, Oct 24, 2014 at 04:53:27PM -0400, Waiman Long wrote: > > The additional register pressure may just cause a few more register moves > > which should be negligible in the overall performance . The additional > > icache pressure, howe

Re: [RFC PATCH 2/2] Assign a new irq handler while irqfd enabled

2014-10-27 Thread Michael S. Tsirkin
On Mon, Oct 27, 2014 at 07:04:11PM +0800, Li Liu wrote: > > > On 2014/10/26 19:56, Michael S. Tsirkin wrote: > > On Sat, Oct 25, 2014 at 04:24:54PM +0800, john.liuli wrote: > >> From: Li Liu > >> > >> This irq handler will get the interrupt reason from a > >> shared memory. And will be assigned

Re: [Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-10-27 Thread Peter Maydell
On 27 October 2014 11:23, Li Liu wrote: > So you mean virtio-mmio will be replaced by PCI/PCIe on ARM at last? That is the plan, yes. I can't make any promises on timescales at the moment, though... -- PMM ___ Virtualization mailing list Virtualization

Re: [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-10-27 Thread Michael S. Tsirkin
On Mon, Oct 27, 2014 at 05:19:23PM +0800, Li Liu wrote: > > > On 2014/10/26 19:52, Michael S. Tsirkin wrote: > > On Sat, Oct 25, 2014 at 04:24:52PM +0800, john.liuli wrote: > >> From: Li Liu > >> > >> This set of patches try to implemet irqfd support of vhost-net > >> based on virtio-mmio. > >>

Re: [Qemu-devel] [RFC PATCH 0/2] virtio-mmio: add irqfd support for vhost-net based on virtio-mmio

2014-10-27 Thread Peter Maydell
On 25 October 2014 09:24, john.liuli wrote: > To get the interrupt reason to support such VIRTIO_NET_F_STATUS > features I add a new register offset VIRTIO_MMIO_ISRMEM which > will help to establish a shared memory region between qemu and > virtio-mmio device. Then the interrupt reason can be acce